Hi Geert,
Thanks for your feedback!
On Thu, 3 Jan 2019 at 17:13, Geert Uytterhoeven geert@linux-m68k.org wrote:
The generated uapi header file will be included in uapi/- asm/unistd.h and generated system call table header file will be included by kernel/syscalltable.S file.
This doesn't really describe what this patch is doing. This patch switches m68k over to use the common scripts for system call header file generation.
Sure. I'll compose new commit message.
syscall := $(srctree)/$(src)/syscall.tbl -syshdr := $(srctree)/$(src)/syscallhdr.sh -systbl := $(srctree)/$(src)/syscalltbl.sh +syshdr := $(srctree)/scripts/syscallhdr.sh +sysnr := $(srctree)/scripts/syscallnr.sh
What's the purpose of adding sysnr?
Yes. This is not really required here. I planned to change the implementation in some other way, but didn't looks perfect and this was left here unnoticed.
+quiet_cmd_sysnr = SYSNR $@
cmd_sysnr = $(CONFIG_SHELL) '$(sysnr)' '$<' '$@' \'$(sysnr_abis_$(basetarget))' \'$(sysnr_pfx_$(basetarget))' \'$(sysnr_offset_$(basetarget))'What's the purpose of adding this build rule, which is unused?
Sure.
Firoz