On Sat, Nov 7, 2015 at 3:01 AM, Arnd Bergmann arnd@arndb.de wrote:
On Saturday 07 November 2015 02:36:35 Amitoj Kaur Chawla wrote:
diff --git a/drivers/scsi/bfa/bfa_defs_svc.h b/drivers/scsi/bfa/bfa_defs_svc.h index e7acf41..0a31561 100644 --- a/drivers/scsi/bfa/bfa_defs_svc.h +++ b/drivers/scsi/bfa/bfa_defs_svc.h @@ -1211,7 +1211,7 @@ struct bfa_itnim_ioprofile_s { u32 clock_res_mul; u32 clock_res_div; u32 index;
u32 io_profile_start_time; /* IO profile start time */
u64 io_profile_start_time; /* IO profile start time */ u32 iocomps[BFA_IOBUCKET_MAX]; /* IO completed */ struct bfa_itnim_latency_s io_latency;};
How did you determine whether this is a safe change? What code reads the variable and what is done with it afterwards?
Arnd
The only place bfa_itnim_ioprofile_s is used is in the function:
bfa_status_t bfa_itnim_get_ioprofile(struct bfa_itnim_s *itnim, struct bfa_itnim_ioprofile_s *ioprofile) { .... itnim->ioprofile.io_profile_start_time = bfa_io_profile_start_time(itnim->bfa); .... }
bfa_io_profile_start_time is the macro:
#define bfa_io_profile_start_time(_bfa) \ ((_bfa)->modules.fcp_mod.fcpim.io_profile_start_time);
As far as I understood in the above code is that fcpim.io_profile_start_time is the structure bfa_fcpim_s io_profile_start_time variable.
Since we are talking about both structures' io_profile_start_time variable and converting both of them to u64, I thought it would be a safe change.