Re: [Y2038] [PATCH v2] generic/402: Make timestamp range check conditional

...

I understand why you dislike the ext2+loop test, but please hear me out.

From all the fs types that are supported by the test, only btrfs and ext4 with large inode size are y2038 ready. For the rest of the cases, we actually have a way to detect kernel support from the dmesg warning, without the need for hacky ext2 loop mount.

So how about just:

1. moving _scratch_mount before _require_timestamp_range
2. in _require_timestamp_range (untested): if [ $tsmax -lt $((1<<32)) ] && ! _check_dmesg_for "supports

Yeah, this looks fine. I thought about searching for dmesg warning after _scratch_mount as well, but that would _notrun if the fs is 2038-safe. This $tsmax check fixes my concern. Thanks!

Deepa,

Do you intend to post the simplified version or would you like me to re-spin your patch?

Thanks, Amir.