Y2038

y2038@lists.linaro.org

1 participants
1134 discussions

[PATCH] include: ceph: Fix encode and decode type conversions

by Deepa Dinamani

long/ kernel_time_t is 32 bit on a 32 bit system and 64 bit on a 64 bit system. ceph_encode_timespec() encodes only the lower 32 bits on a 64 bit system and encodes all of 32 bits on a 32bit system. ceph_decode_timespec() decodes 32 bit tv_sec and tv_nsec into kernel_time_t/ long. The encode and decode functions do not match when the values are negative: Consider the following scenario on a 32 bit system: When a negative number is cast to u32 as encode does, the value is positive and is greater than INT_MAX. Decode reads back this value. And, this value cannot be represented by long on 32 bit systems. So by section 6.3.1.3 of the C99 standard, the result is implementation defined. Consider the following scenario on a 64 bit system: When a negative number is cast to u32 as encode does, the value is positive. This value is later assigned by decode function by a cast to long. Since this value can be represented in long data type, this becomes a positive value greater than INT_MAX. But, the value encoded was negative, so the encode and decode functions do not match. Change the decode function as follows to overcome the above bug: The decode should first cast the value to a s64 this will be positive value greater than INT_MAX(in case of a negative encoded value)and then cast this value again as s32, which drops the higher order 32 bits. On 32 bit systems, this is the right value in kernel_time_t/ long. On 64 bit systems, assignment to kernel_time_t/ long will sign extend this value to reflect the signed bit encoded. Assume ceph timestamp ranges permitted are 1902..2038. Suggested-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- include/linux/ceph/decode.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/ceph/decode.h b/include/linux/ceph/decode.h index a6ef9cc..e777e99 100644 --- a/include/linux/ceph/decode.h +++ b/include/linux/ceph/decode.h @@ -137,8 +137,8 @@ bad: static inline void ceph_decode_timespec(struct timespec *ts, const struct ceph_timespec *tv) { - ts->tv_sec = (__kernel_time_t)le32_to_cpu(tv->tv_sec); - ts->tv_nsec = (long)le32_to_cpu(tv->tv_nsec); + ts->tv_sec = (s32)(s64)le32_to_cpu(tv->tv_sec); + ts->tv_nsec = (s32)(s64)le32_to_cpu(tv->tv_nsec); } static inline void ceph_encode_timespec(struct ceph_timespec *tv, const struct timespec *ts) -- 1.9.1

9 years, 3 months

[PATCH 0/4] Convert network timestamps to be y2038 safe

by Deepa Dinamani

Introduction: The series is aimed at transitioning network timestamps to being y2038 safe. All patches can be reviewed and merged independently, except for the [PATCH 2/4], which is dependent on the [PATCH 1/4]. Socket timestamps and ioctl calls will be handled separately. Thanks to Arnd Bergmann for discussing solution options with me. Solution: Data type struct timespec is not y2038 safe. Replace timespec with struct timespec64 which is y2038 safe. Deepa Dinamani (4): kernel: time: Add current_nw_timestamp() for network timestamps net: ipv4: Use y2038 safe functions and data structures net: ipv4: tcp_probe: Replace timespec with timespec64 net: sctp: Convert log timestamps to be y2038 safe include/linux/ip.h | 2 ++ include/linux/time64.h | 3 +++ kernel/time/time.c | 26 ++++++++++++++++++++++++++ net/ipv4/icmp.c | 5 +---- net/ipv4/ip_options.c | 13 +++++-------- net/ipv4/tcp_probe.c | 8 ++++---- net/sctp/probe.c | 10 +++++----- 7 files changed, 46 insertions(+), 21 deletions(-) -- 1.9.1 Cc: Vlad Yasevich <vyasevich(a)gmail.com> Cc: Neil Horman <nhorman(a)tuxdriver.com> Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Alexey Kuznetsov <kuznet(a)ms2.inr.ac.ru> Cc: James Morris <jmorris(a)namei.org> Cc: Hideaki YOSHIFUJI <yoshfuji(a)linux-ipv6.org> Cc: Patrick McHardy <kaber(a)trash.net> Cc: John Stultz <john.stultz(a)linaro.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: linux-sctp(a)vger.kernel.org

9 years, 3 months

[PATCH 0/8] Remove CURRENT_TIME and CURRENT_TIME_SEC - PART 2

by Deepa Dinamani

Introduction This patch series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC macros. The idea for the series evolved from my discussions with Arnd Bergmann. This was originally part of the RFC series[2]: https://lkml.org/lkml/2016/1/7/20 (under discussion). Dave Chinner suggested moving bug fixes out of the feature series to keep the original series simple. There are 354 occurrences of the the above macros in the kernel. The series will be divided into 4 or 5 parts to keep the parts manageable and so that each part could be reviewed and merged independently. This is part 2 of the series. Motivation The macros: CURRENT_TIME and CURRENT_TIME_SEC are primarily used for filesystem timestamps. But, they are not accurate as they do not perform clamping according to filesystem timestamps ranges, nor do they truncate the nanoseconds value to the granularity as required by the filesystem. The series is also viewed as an ancillary to another upcoming series[2] that attempts to transition file system timestamps to use 64 bit time to make these y2038 safe. There will also be another series[3] to add range checks and clamping to filesystem time functions that are meant to substitute the above macros. Solution CURRENT_TIME macro has an equivalent function: struct timespec current_fs_time(struct super_block *sb) These will be the changes to the above function: 1. Function will return the type y2038 safe timespec64 in [2]. 2. Function will use y2038 safe 64 bit functions in [2]. 3. Function will be extended to perform range checks in [3]. A new function will be added to substitute for CURRENT_TIME_SEC macro in the current series: struct timespec current_fs_time_sec(struct super_block *sb) These will be the changes to the above function: 1. Function will return the type y2038 safe timespec64 in [2]. 2. Function will use y2038 safe 64 bit functions in [2]. 3. Function will be extended to perform range checks in [3]. Any use of these macros outside of filesystem timestamps will be replaced by function calls to appropriate time functions. Deepa Dinamani (8): fs: debugfs: Replace CURRENT_TIME by current_fs_time() fs: logfs: Replace CURRENT_TIME by current_fs_time() fs: devpts: Replace CURRENT_TIME by current_fs_time() fs: configfs: Replace CURRENT_TIME by current_fs_time() fs: proc: Replace CURRENT_TIME by current_fs_time() fs: ramfs: Replace CURRENT_TIME by current_fs_time() fs: kernfs: Replace CURRENT_TIME by current_fs_time() net: sunrpc: Replace CURRENT_TIME by current_fs_time() fs/configfs/inode.c | 8 +++++--- fs/debugfs/inode.c | 3 ++- fs/devpts/inode.c | 9 ++++++--- fs/kernfs/dir.c | 8 +++++--- fs/kernfs/inode.c | 15 ++++++++++----- fs/logfs/dir.c | 11 +++++++---- fs/logfs/file.c | 2 +- fs/logfs/inode.c | 3 +-- fs/logfs/readwrite.c | 7 ++++--- fs/proc/base.c | 3 ++- fs/proc/inode.c | 6 ++++-- fs/proc/proc_sysctl.c | 3 ++- fs/proc/self.c | 3 ++- fs/proc/thread_self.c | 3 ++- fs/ramfs/inode.c | 13 ++++++++----- net/sunrpc/rpc_pipe.c | 4 +++- 16 files changed, 64 insertions(+), 37 deletions(-) -- 1.9.1

9 years, 3 months

[PATCH] scsi: gdth: replace struct timeval with ktime_get_real_seconds()

by Alison Schofield

struct timeval will overflow on 32-bit systems in y2038. Replace the use of struct timeval and do_gettimeofday() with 64 bit ktime_get_real_seconds. gdth uses the seconds portion of timeval in two places: 1) in an unsigned-32 timestamp field in the ioctl GDTIOCTL_EVENT 2) in an int defined local var to calculate elapsed time for a debug msg Use ktime_get_real_seconds() cast to u32 to extend these fields to y2106. Signed-off-by: Alison Schofield <amsfield22(a)gmail.com> --- drivers/scsi/gdth.c | 8 +++----- drivers/scsi/gdth_proc.c | 5 ++--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index 71e1380..3da4f43 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -118,6 +118,7 @@ #include <linux/proc_fs.h> #include <linux/time.h> #include <linux/timer.h> +#include <linux/ktime.h> #include <linux/dma-mapping.h> #include <linux/list.h> #include <linux/mutex.h> @@ -2838,7 +2839,6 @@ static gdth_evt_str *gdth_store_event(gdth_ha_str *ha, u16 source, u16 idx, gdth_evt_data *evt) { gdth_evt_str *e; - struct timeval tv; /* no GDTH_LOCK_HA() ! */ TRACE2(("gdth_store_event() source %d idx %d\n", source, idx)); @@ -2854,8 +2854,7 @@ static gdth_evt_str *gdth_store_event(gdth_ha_str *ha, u16 source, !strcmp((char *)&ebuffer[elastidx].event_data.event_string, (char *)&evt->event_string)))) { e = &ebuffer[elastidx]; - do_gettimeofday(&tv); - e->last_stamp = tv.tv_sec; + e->last_stamp = (u32)ktime_get_real_seconds(); ++e->same_count; } else { if (ebuffer[elastidx].event_source != 0) { /* entry not free ? */ @@ -2871,8 +2870,7 @@ static gdth_evt_str *gdth_store_event(gdth_ha_str *ha, u16 source, e = &ebuffer[elastidx]; e->event_source = source; e->event_idx = idx; - do_gettimeofday(&tv); - e->first_stamp = e->last_stamp = tv.tv_sec; + e->first_stamp = e->last_stamp = (u32)ktime_get_real_seconds(); e->same_count = 1; e->event_data = *evt; e->application = 0; diff --git a/drivers/scsi/gdth_proc.c b/drivers/scsi/gdth_proc.c index e66e997..992d325 100644 --- a/drivers/scsi/gdth_proc.c +++ b/drivers/scsi/gdth_proc.c @@ -4,6 +4,7 @@ #include <linux/completion.h> #include <linux/slab.h> +#include <linux/ktime.h> int gdth_set_info(struct Scsi_Host *host, char *buffer, int length) { @@ -148,7 +149,6 @@ int gdth_show_info(struct seq_file *m, struct Scsi_Host *host) gdth_cmd_str *gdtcmd; gdth_evt_str *estr; char hrec[161]; - struct timeval tv; char *buf; gdth_dskstat_str *pds; @@ -540,8 +540,7 @@ int gdth_show_info(struct seq_file *m, struct Scsi_Host *host) if (estr->event_data.eu.driver.ionode == ha->hanum && estr->event_source == ES_ASYNC) { gdth_log_event(&estr->event_data, hrec); - do_gettimeofday(&tv); - sec = (int)(tv.tv_sec - estr->first_stamp); + sec = (int)((u32)ktime_get_real_seconds() - estr->first_stamp); if (sec < 0) sec = 0; seq_printf(m," date- %02d:%02d:%02d\t%s\n", sec/3600, sec%3600/60, sec%60, hrec); -- 2.1.4

9 years, 3 months

[RFC v2] vfs 64 bit time transition proposals

by Deepa Dinamani

Introduction This is a follow on to the series: https://lkml.org/lkml/2016/1/7/20 [1]. This is aimed at reaching a consensus on how to transition the vfs timestamps to use 64 bit time. This demonstrates three ways (2a, 2b and 2c) of solving this problem. Each of the proposals has its own cover letter that explains the individual approach. Proposals 2b and 2c also outline variant approaches which are similar to the respective proposals. This drives the proposal count to 5. All the changes have been discussed with Arnd Bergmann, who posted the original series: https://lkml.org/lkml/2014/5/30/669 [2] The series has been simplified to include only the 64 bit timestamp changes as per Dave Chinner’s suggestion. Motivation The problem is how to change the vfs inode timestamps to use 64 bit times to overcome the 2038 problem. Below table [3] gives an overview of the extent/ type of changes needed of changes needed. The series is aimed at obtaining small manageable patches for all the cases in [3]. Table [3] Terminology: vfs_time – data type of timestamps used in the vfs layer. Access type # of instances 1. timespec_*(struct vfs_time, struct timespec) / 34 timespec_*(struct vfs_time, struct vfs_time) 2. struct vfs_time = struct vfs_time 50 3. vfs_time = current_fs_time/ CURRENT_TIME/ CURRENT_TIME_SEC 312 4. setattr vfs_time assignments 141 5. vfs_time = other data types, outside of setattr() (timespec, s32, s64..) 74 6. other data types, outside of getattr() (timespec, s32, s64..) = vfs_time 85 7. internal individual fs funtions using inode timestamps as args 80 8. extra timestamp fields in individual filesystems ~10 9. VFS callback - int (*update_time)(struct inode *, struct timespec *, int) 3 10. VFS function - void lease_get_mtime(struct inode *inode, struct timespec *time) 3 Each series is used to demonstrate how each of the above cases is solved using their respective approaches. The example filesystems (btrfs, xfs, cifs, and ceph) were selected in such a way so as to showcase all these issues in table [3]. Source Tree The tree is hosted at github.com/deepa-hub/vfs.git The branches for the three approaches are 2a. https://github.com/deepa-hub/vfs.git refs/heads/vfs_time 2b. https://github.com/deepa-hub/vfs.git refs/heads/vfs_time_to_timespec 2c. https://github.com/deepa-hub/vfs.git refs/heads/vfs_time_to_ts64 All the above series are based off of: https://lkml.org/lkml/2016/2/3/34 [4] and a couple of other patches. Only the minimal changes are posted here to keep the series simple. There are a couple of bug fixes like data type conversion bugs that will be sent directly to the corresponding filesystem lists. Next steps The approaches 2a, 2b and 2c are posted as responses to this cover letter. Testing All the approaches have been compile tested only.

9 years, 3 months

[PATCH] isdn: divamnt: use y2038 safe time structures and functions

by Alison Schofield

divamnt stores a start_time at init and uses it to calculate elapsed time. These operations are all internal to divamnt. Address struct timeval overflow on 32-bit systems by replacing: struct timeval with struct timespec64; do_gettimeofday() with getnstimeofday64(); the calculations that yield a safe and normalized elapsed time with timespec64_sub() which provides same. Signed-off-by: Alison Schofield <amsfield22(a)gmail.com> --- drivers/isdn/hardware/eicon/divamnt.c | 35 +++++++++++------------------------ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/isdn/hardware/eicon/divamnt.c b/drivers/isdn/hardware/eicon/divamnt.c index 48db08d..7ac057e 100644 --- a/drivers/isdn/hardware/eicon/divamnt.c +++ b/drivers/isdn/hardware/eicon/divamnt.c @@ -45,7 +45,7 @@ char *DRIVERRELEASE_MNT = "2.0"; static wait_queue_head_t msgwaitq; static unsigned long opened; -static struct timeval start_time; +static struct timespec64 start_time; extern int mntfunc_init(int *, void **, unsigned long); extern void mntfunc_finit(void); @@ -88,28 +88,15 @@ int diva_os_copy_from_user(void *os_handle, void *dst, const void __user *src, */ void diva_os_get_time(dword *sec, dword *usec) { - struct timeval tv; - - do_gettimeofday(&tv); - - if (tv.tv_sec > start_time.tv_sec) { - if (start_time.tv_usec > tv.tv_usec) { - tv.tv_sec--; - tv.tv_usec += 1000000; - } - *sec = (dword) (tv.tv_sec - start_time.tv_sec); - *usec = (dword) (tv.tv_usec - start_time.tv_usec); - } else if (tv.tv_sec == start_time.tv_sec) { - *sec = 0; - if (start_time.tv_usec < tv.tv_usec) { - *usec = (dword) (tv.tv_usec - start_time.tv_usec); - } else { - *usec = 0; - } - } else { - *sec = (dword) tv.tv_sec; - *usec = (dword) tv.tv_usec; - } + struct timespec64 curr_time; + struct timespec64 delta; + + getnstimeofday64(&curr_time); + + delta = timespec64_sub(curr_time, start_time); + + *sec = (dword) delta.tv_sec; + *usec = (dword) (delta.tv_nsec / NSEC_PER_USEC); } /* @@ -213,7 +200,7 @@ static int __init maint_init(void) int ret = 0; void *buffer = NULL; - do_gettimeofday(&start_time); + getnstimeofday64(&start_time); init_waitqueue_head(&msgwaitq); printk(KERN_INFO "%s\n", DRIVERNAME); -- 2.1.4

9 years, 4 months

resend gdth?

by Alison Schofield

Arnd, This one I've had no response. Shall I just do RESEND to maintainers? I don't see a special tree listed in the maintainers file so is it ok that I built this on staging-testing? If I need to rebase it, is it a RESEND or a new send. Does that question make sense? Thanks, alisons ----- Forwarded message from Alison Schofield <amsfield22(a)gmail.com> ----- Date: Mon, 4 Jan 2016 11:12:24 -0800 From: Alison Schofield <amsfield22(a)gmail.com> To: jbottomley(a)odin.com Subject: gdth reviewer/maintainer ? User-Agent: Mutt/1.5.23 (2014-03-12) James, email to Achim is bouncing. Is there another reviewer I should send this patch to? (Arnd has reviewed for y2038 group) Thanks, Alison ----- Forwarded message from Alison Schofield <amsfield22(a)gmail.com> ----- Date: Tue, 24 Nov 2015 16:44:07 -0800 From: Alison Schofield <amsfield22(a)gmail.com> To: achim_leubner(a)adaptec.com, JBottomley(a)odin.com, linux-scsi(a)vger.kernel.org, linux-kernel(a)vger.kernel.org, y2038(a)lists.linaro.org Subject: [PATCH v2] scsi: gdth: replace struct timeval with ktime_get_real_seconds() X-Mailer: git-send-email 2.1.4 struct timeval will overflow on 32-bit systems in y2038 and is being removed from the kernel. Replace the use of struct timeval and

9 years, 4 months

how/when to resend? Re: [PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps]

by Alison Schofield

----- Forwarded message from David Miller <davem(a)davemloft.net> ----- Date: Sun, 17 Jan 2016 19:27:17 -0500 (EST) From: David Miller <davem(a)davemloft.net> To: amsfield22(a)gmail.com Cc: mac(a)melware.de, isdn(a)linux-pingi.de, netdev(a)vger.kernel.org, linux-kernel(a)vger.kernel.org, y2038(a)lists.linaro.org Subject: Re: [PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) From: Alison Schofield <amsfield22(a)gmail.com> Date: Fri, 15 Jan 2016 08:51:25 -0800 > divamnt stores a start_time at module init and uses it to calculate > elapsed time. The elapsed time, stored in secs and usecs, is part of ...............snip > > Signed-off-by: Alison Schofield <amsfield22(a)gmail.com> > Reviewed-by: Arnd Bergmann <arnd(a)arndb.de> Please resubmit this when the net-next tree is open again. Thank you. ----- End forwarded message ----- Arnd, How do I know when the net-next tree is open? And, I guess I need to rebase this on the net-next tree before I resend - right? Thanks! Alison

9 years, 4 months

You have new fax, document 00000334856

by Interfax Service

You have received a new fax. Please download attached fax document. Filesize: 141 Kb Scanned at: Wed, 17 Feb 2016 03:56:36 +0300 Scanned by: Tyler Cassidy Pages sent: 12 Processed in: 58 seconds Document name: task_00000334856.doc Scan quality: 300 DPI Thanks for choosing Interfax!

9 years, 4 months

learning management system-Records

by Tania Cuevas

Hi, I was just going through your website and I see that your company is dealing with open source software So, would you be interested to acquire a list of Canonical and Ubuntu End Users for your marketing initiatives. We can also help you with the users' database of: . Redhat . Linux. . Centos . Mint . Windows and more. Information fields: Contact First Name, Last Name, Job Title, Email Address, Phone Number, Fax Number, Company Name, Company Physical Address, and Company Web Address, SIC Code, NAICS code, Primary Industry, Employee Size, Revenue, Technology Type Let me know if you are focused on any particular titles and application users so that I can get back to you with all the relevant details. Thank you & look forward to hearing from you. Regards, Tania Cuevas - Sr. Marketing Executive ___________________________________________________________________________ We respect your privacy. If you do not wish to receive future e-mail please reply with "REMOVE

9 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038