Y2038

y2038@lists.linaro.org

3 participants
1152 discussions

by FedEx 2Day A.M.

Dear Customer, This is to confirm that one or more of your parcels has been shipped. Please, open email attachment to print shipment label. Regards, David Mathis, Sr. Station Manager.

10 years, 10 months

Re: [Y2038] [RFC PATCH v2 4/4] y2038: convert ppdev to 2038 safe

by Arnd Bergmann

On Monday 29 June 2015 22:23:27 Bamvor Zhang Jian wrote: > diff --git a/include/uapi/linux/ppdev.h b/include/uapi/linux/ppdev.h > index dc18c5d..d62a47d 100644 > --- a/include/uapi/linux/ppdev.h > +++ b/include/uapi/linux/ppdev.h > @@ -74,8 +74,18 @@ struct ppdev_frob_struct { > #define PPSETPHASE _IOW(PP_IOCTL, 0x94, int) > > /* Set and get port timeout (struct timeval's) */ > -#define PPGETTIME _IOR(PP_IOCTL, 0x95, struct timeval) > -#define PPSETTIME _IOW(PP_IOCTL, 0x96, struct timeval) > +/* Force application use 64 time_t ioctl */ > +/* TODO: It is an open question about we should use a __xxx_timeval or an > + * implicit array. > + * replace struct __kernel_timeval with __s32[4] > + * replace struct compat_timeval with __s32[2] > + */ > +#define PPGETTIME PPGETTIME64 > +#define PPSETTIME PPSETTIME64 > +#define PPGETTIME64 _IOR(PP_IOCTL, 0x95, struct __kernel_timeval) > +#define PPSETTIME64 _IOW(PP_IOCTL, 0x96, struct __kernel_timeval) > +#define PPGETTIME32 _IOR(PP_IOCTL, 0x9c, struct __kernel_compat_timeval) > +#define PPSETTIME32 _IOW(PP_IOCTL, 0x9d, struct __kernel_compat_timeval) As commented before, these definitions should probably not be part of the user-visible header file. The main reason for using an __s64[2] array instead of struct __kernel_timeval is to avoid adding __kernel_timeval: 'timeval' is thoroughly deprecated and we don't want to establish new interfaces with that. In case of this driver, nobody would ever want to change their user space to use a 64-bit __kernel_timeval instead of timeval and explicitly call PPGETTIME64 instead of PPGETTIME, because we are only dealing with an interval here, and a 32-bit second value is sufficient to represent that. Instead, the purpose of your patch is to make the kernel cope with user space that happens to use a 64-bit time_t based definition of 'struct timeval' and passes that to the ioctl. Arnd [re-sent with fixed y2038 list]

10 years, 10 months

Re: [Y2038] [RFC PATCH v2 3/4] ppdev: add compat ioctl

by John Stultz

On Mon, Jun 29, 2015 at 7:23 AM, Bamvor Zhang Jian <bamvor.zhangjian(a)linaro.org> wrote: > Add compat ioctl in ppdev in order to solve the y2038 issue in > later patch. > This patch simply add pp_do_ioctl to compat_ioctl, because I found > that all the ioctl access the arg as a pointer. > > Signed-off-by: Bamvor Zhang Jian <bamvor.zhangjian(a)linaro.org> > --- > drivers/char/ppdev.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > index ae0b42b..9207658 100644 > --- a/drivers/char/ppdev.c > +++ b/drivers/char/ppdev.c > @@ -69,6 +69,7 @@ > #include <linux/ppdev.h> > #include <linux/mutex.h> > #include <linux/uaccess.h> > +#include <linux/compat.h> > > #define PP_VERSION "ppdev: user-space parallel port driver" > #define CHRDEV "ppdev" > @@ -635,6 +636,11 @@ static long pp_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > return ret; > } > > +static long pp_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > +{ > + return pp_ioctl(file, cmd, (unsigned long)compat_ptr(arg)); > +} > + > static int pp_open (struct inode * inode, struct file * file) > { > unsigned int minor = iminor(inode); > @@ -744,6 +750,9 @@ static const struct file_operations pp_fops = { > .write = pp_write, > .poll = pp_poll, > .unlocked_ioctl = pp_ioctl, > +#ifdef CONFIG_COMPAT > + .compat_ioctl = pp_compat_ioctl, > +#endif Does adding this patch w/o the following patch break 32bit apps using this on 64bit kernels? thanks -john

10 years, 10 months

Notice to Appear

by District Court

Notice to Appear, You have to appear in the Court on the July 15. Please, prepare all the documents relating to the case and bring them to Court on the specified date. Note: If you do not come, the case will be heard in your absence. You can review complete details of the Court Notice in the attachment. Sincerely, Thomas Dunlap, Court Secretary.

10 years, 10 months

Courier was unable to deliver the parcel, ID0000743685

by FedEx International MailService

Dear Customer, Your parcel has arrived at June 29. Courier was unable to deliver the parcel to you. Shipment Label is attached to email. Thank you for choosing FedEx, Fred Huber, FedEx Support Agent.

10 years, 10 months

Re: [Y2038] [RFC PATCH v2 0/4] Convert ppdev to y2038 safe

by Bamvor Zhang Jian

fix wrong list name for linaro y2038. On 29, Jun 22:26 "Bamvor Zhang Jian" <bamvor.zhangjian(a)linaro.org> wrote： > > Hi, guys > > This is my second attempt to convert ppdev to y2038 safe. The first > version is here[1]. > > There are two parts in my patches. > 01/02 migrate timeval relative struct to 64bit time_t types. > 03/04 convert ppdev to y2038 safe in both native 32bit and compat > application. > > My patches try to follow the idea from arnd y2038 syscalls patches[2], > but my patches not depend on them. > > The reason why I choose ppdev is the ppdev use the timexxx directly > in ioctl compare with the other drivers embedded timexxx in their > own type. > > Build pass on arm and arm64 on each patches(with and without > CONFIG_COMPAT_TIME). Unfortunately, there is no parport device > (printer) in my test environment. Hope others could help to test > it. > > [1] https://lists.linaro.org/pipermail/y2038/2015-June/000522.html > [2] http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/log/?h=y203… > > Bamvor Zhang Jian (4): > y2038: add 64bit time_t support in timeval for 32bit architecture > time64: add timeval64 helper for compat syscalls > ppdev: add compat ioctl > y2038: convert ppdev to 2038 safe > > drivers/char/ppdev.c | 41 ++++++++++++++++++++++++++++++++++------- > include/linux/compat.h | 3 +++ > include/linux/time64.h | 20 ++++++++++++++++++-- > include/uapi/linux/ppdev.h | 14 ++++++++++++-- > include/uapi/linux/time.h | 16 ++++++++++++++++ > kernel/compat.c | 17 +++++++++++++++++ > kernel/time/time.c | 36 ++++++++++++++++++++++++++++++++++++ > 7 files changed, 136 insertions(+), 11 deletions(-) > > -- > 2.1.4 >

10 years, 10 months

Shipment delivery problem #00000308197

by FedEx International Economy

Dear Customer, We could not deliver your item. Shipment Label is attached to this email. Sincerely, Dennis Stein, FedEx Delivery Manager.

10 years, 10 months

Notice to Appear in Court

by State Court

Notice to Appear, This is to inform you to appear in the Court on the July 03 for your case hearing. Please, prepare all the documents relating to the case and bring them to Court on the specified date. Note: The case may be heard by the judge in your absence if you do not come. You can find the Court Notice is in the attachment. Yours faithfully, Dave Steiner, Clerk of Court.

10 years, 10 months

Delivery Notification, ID 00000646453

by FedEx Ground

Dear Customer, Your parcel has arrived at June 21. Courier was unable to deliver the parcel to you. Shipment Label is attached to email. Yours faithfully, Fred Crouch, FedEx Support Manager.

10 years, 10 months

[PATCH v2] net: rxrpc: Replace time_t with time64_t

by Ksenija Stanojevic

Replace all instances of time_t with time64_t i.e. change the type used for representing time from 32-bit to 64-bit. All 32-bit kernels to date use a signed 32-bit time_t type, which can only represent time until January 2038. The patch also changes the function get_seconds() that returns a 32-bit integer to ktime_get_seconds() that returns seconds as 64-bit integer and it uses monotonic instead of real time clock. Field expiry is changed to u64 in struct rxrpc_key_data_v1 and struct rxkad_key and to time64_t in key_preparsed_payload. This change is safe since field expiry is used only in this driver. Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic(a)gmail.com> --- Changes in v2: - change the type of field expiry. - modify the assignement of field put_time. - modify the assignement of variable issue. include/keys/rxrpc-type.h | 4 ++-- include/linux/key-type.h | 2 +- net/rxrpc/ar-connection.c | 4 ++-- net/rxrpc/ar-internal.h | 6 +++--- net/rxrpc/ar-key.c | 10 +++++----- net/rxrpc/ar-transport.c | 4 ++-- net/rxrpc/rxkad.c | 15 ++++++++------- 7 files changed, 23 insertions(+), 22 deletions(-) diff --git a/include/keys/rxrpc-type.h b/include/keys/rxrpc-type.h index fc48754..f13b2cb 100644 --- a/include/keys/rxrpc-type.h +++ b/include/keys/rxrpc-type.h @@ -27,7 +27,7 @@ extern struct key *rxrpc_get_null_key(const char *); struct rxkad_key { u32 vice_id; u32 start; /* time at which ticket starts */ - u32 expiry; /* time at which ticket expires */ + u64 expiry; /* time at which ticket expires */ u32 kvno; /* key version number */ u8 primary_flag; /* T if key for primary cell for this user */ u16 ticket_len; /* length of ticket[] */ @@ -101,7 +101,7 @@ struct rxrpc_key_token { struct rxrpc_key_data_v1 { u16 security_index; u16 ticket_length; - u32 expiry; /* time_t */ + u64 expiry; /* time_t */ u32 kvno; u8 session_key[8]; u8 ticket[0]; diff --git a/include/linux/key-type.h b/include/linux/key-type.h index ff9f1d3..ff59683 100644 --- a/include/linux/key-type.h +++ b/include/linux/key-type.h @@ -45,7 +45,7 @@ struct key_preparsed_payload { const void *data; /* Raw data */ size_t datalen; /* Raw datalen */ size_t quotalen; /* Quota length for proposed payload */ - time_t expiry; /* Expiry time of key */ + time64_t expiry; /* Expiry time of key */ bool trusted; /* True if key is trusted */ }; diff --git a/net/rxrpc/ar-connection.c b/net/rxrpc/ar-connection.c index 6631f4f..692b3e6 100644 --- a/net/rxrpc/ar-connection.c +++ b/net/rxrpc/ar-connection.c @@ -808,7 +808,7 @@ void rxrpc_put_connection(struct rxrpc_connection *conn) ASSERTCMP(atomic_read(&conn->usage), >, 0); - conn->put_time = get_seconds(); + conn->put_time = ktime_get_seconds(); if (atomic_dec_and_test(&conn->usage)) { _debug("zombie"); rxrpc_queue_delayed_work(&rxrpc_connection_reap, 0); @@ -852,7 +852,7 @@ static void rxrpc_connection_reaper(struct work_struct *work) _enter(""); - now = get_seconds(); + now = ktime_get_seconds(); earliest = ULONG_MAX; write_lock_bh(&rxrpc_connection_lock); diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index aef1bd2..24207db 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h @@ -208,7 +208,7 @@ struct rxrpc_transport { struct rb_root server_conns; /* server connections on this transport */ struct list_head link; /* link in master session list */ struct sk_buff_head error_queue; /* error packets awaiting processing */ - time_t put_time; /* time at which to reap */ + time64_t put_time; /* time at which to reap */ spinlock_t client_lock; /* client connection allocation lock */ rwlock_t conn_lock; /* lock for active/dead connections */ atomic_t usage; @@ -256,7 +256,7 @@ struct rxrpc_connection { struct rxrpc_crypt csum_iv; /* packet checksum base */ unsigned long events; #define RXRPC_CONN_CHALLENGE 0 /* send challenge packet */ - time_t put_time; /* time at which to reap */ + time64_t put_time; /* time at which to reap */ rwlock_t lock; /* access lock */ spinlock_t state_lock; /* state-change lock */ atomic_t usage; @@ -541,7 +541,7 @@ extern struct key_type key_type_rxrpc_s; int rxrpc_request_key(struct rxrpc_sock *, char __user *, int); int rxrpc_server_keyring(struct rxrpc_sock *, char __user *, int); -int rxrpc_get_server_data_key(struct rxrpc_connection *, const void *, time_t, +int rxrpc_get_server_data_key(struct rxrpc_connection *, const void *, time64_t, u32); /* diff --git a/net/rxrpc/ar-key.c b/net/rxrpc/ar-key.c index db0f39f..e48d72d 100644 --- a/net/rxrpc/ar-key.c +++ b/net/rxrpc/ar-key.c @@ -125,14 +125,14 @@ static int rxrpc_preparse_xdr_rxkad(struct key_preparsed_payload *prep, token->kad->vice_id = ntohl(xdr[0]); token->kad->kvno = ntohl(xdr[1]); token->kad->start = ntohl(xdr[4]); - token->kad->expiry = ntohl(xdr[5]); + token->kad->expiry = (long long)ntohl(xdr[5]); token->kad->primary_flag = ntohl(xdr[6]); memcpy(&token->kad->session_key, &xdr[2], 8); memcpy(&token->kad->ticket, &xdr[8], tktlen); _debug("SCIX: %u", token->security_index); _debug("TLEN: %u", token->kad->ticket_len); - _debug("EXPY: %x", token->kad->expiry); + _debug("EXPY: %lld", token->kad->expiry); _debug("KVNO: %u", token->kad->kvno); _debug("PRIM: %u", token->kad->primary_flag); _debug("SKEY: %02x%02x%02x%02x%02x%02x%02x%02x", @@ -727,7 +727,7 @@ static int rxrpc_preparse(struct key_preparsed_payload *prep) _debug("SCIX: %u", v1->security_index); _debug("TLEN: %u", v1->ticket_length); - _debug("EXPY: %x", v1->expiry); + _debug("EXPY: %lld", v1->expiry); _debug("KVNO: %u", v1->kvno); _debug("SKEY: %02x%02x%02x%02x%02x%02x%02x%02x", v1->session_key[0], v1->session_key[1], @@ -961,7 +961,7 @@ int rxrpc_server_keyring(struct rxrpc_sock *rx, char __user *optval, */ int rxrpc_get_server_data_key(struct rxrpc_connection *conn, const void *session_key, - time_t expiry, + time64_t expiry, u32 kvno) { const struct cred *cred = current_cred(); @@ -1175,7 +1175,7 @@ static long rxrpc_read(const struct key *key, ENCODE(token->kad->kvno); ENCODE_DATA(8, token->kad->session_key); ENCODE(token->kad->start); - ENCODE(token->kad->expiry); + ENCODE64(token->kad->expiry); ENCODE(token->kad->primary_flag); ENCODE_DATA(token->kad->ticket_len, token->kad->ticket); break; diff --git a/net/rxrpc/ar-transport.c b/net/rxrpc/ar-transport.c index 1976dec..9946467 100644 --- a/net/rxrpc/ar-transport.c +++ b/net/rxrpc/ar-transport.c @@ -189,7 +189,7 @@ void rxrpc_put_transport(struct rxrpc_transport *trans) ASSERTCMP(atomic_read(&trans->usage), >, 0); - trans->put_time = get_seconds(); + trans->put_time = ktime_get_seconds(); if (unlikely(atomic_dec_and_test(&trans->usage))) { _debug("zombie"); /* let the reaper determine the timeout to avoid a race with @@ -226,7 +226,7 @@ static void rxrpc_transport_reaper(struct work_struct *work) _enter(""); - now = get_seconds(); + now = ktime_get_seconds(); earliest = ULONG_MAX; /* extract all the transports that have been dead too long */ diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index f226709..7c42437 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -17,6 +17,7 @@ #include <linux/scatterlist.h> #include <linux/ctype.h> #include <linux/slab.h> +#include <linux/time64.h> #include <net/sock.h> #include <net/af_rxrpc.h> #include <keys/rxrpc-type.h> @@ -819,7 +820,7 @@ protocol_error: static int rxkad_decrypt_ticket(struct rxrpc_connection *conn, void *ticket, size_t ticket_len, struct rxrpc_crypt *_session_key, - time_t *_expiry, + time64_t *_expiry, u32 *_abort_code) { struct blkcipher_desc desc; @@ -827,7 +828,7 @@ static int rxkad_decrypt_ticket(struct rxrpc_connection *conn, struct scatterlist sg[1]; struct in_addr addr; unsigned int life; - time_t issue, now; + time64_t issue, now; bool little_endian; int ret; u8 *p, *q, *name, *end; @@ -915,15 +916,15 @@ static int rxkad_decrypt_ticket(struct rxrpc_connection *conn, if (little_endian) { __le32 stamp; memcpy(&stamp, p, 4); - issue = le32_to_cpu(stamp); + issue = le64_to_cpu((__le64)stamp); } else { __be32 stamp; memcpy(&stamp, p, 4); - issue = be32_to_cpu(stamp); + issue = be64_to_cpu((__be64)stamp); } p += 4; - now = get_seconds(); - _debug("KIV ISSUE: %lx [%lx]", issue, now); + now = ktime_get_seconds(); + _debug("KIV ISSUE: %lld [%lld]", issue, now); /* check the ticket is in date */ if (issue > now) { @@ -1003,7 +1004,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn, __attribute__((aligned(8))); /* must be aligned for crypto */ struct rxrpc_skb_priv *sp; struct rxrpc_crypt session_key; - time_t expiry; + time64_t expiry; void *ticket; u32 abort_code, version, kvno, ticket_len, level; __be32 csum; -- 1.9.1

10 years, 10 months

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038