- Y2038 - lists.linaro.org

[PATCH 0/5] s390: rework compat wrapper generation

by Arnd Bergmann

Hi Heiko and Martin, As promised, I gave this a go and changed the SYSCALL_DEFINEx() infrastructure to always include the wrappers for doing the 31-bit argument conversion on s390 compat mode. This does three main things: - The UID16 rework saved a lot of duplicated code, and would probably make sense by itself, but is also required as we can no longer call sys_*() functions directly after the last step. - Removing the compat_wrapper.c file is of course the main goal here, in order to remove the need to maintain the compat_wrapper.c file when new system calls get added. Unfortunately, this requires adding some complexity in syscall_wrapper.h, and trades a small reduction in source code lines for a small increase in binary size for unused wrappers. - As an added benefit, the use of syscall_wrapper.h now makes it easy to change the syscall wrappers so they no longer see all user space register contents, similar to changes done in commits fa697140f9a2 ("syscalls/x86: Use 'struct pt_regs' based syscall calling convention for 64-bit syscalls") and 4378a7d4be30 ("arm64: implement syscall wrappers"). I leave the actual implementation of this for you, if you want to do it later. I did not test the changes at runtime, but I looked at the generated object code, which seems fine here and includes the same conversions as before. Arnd Arnd Bergmann (5): s390: open-code s390_personality syscall ipc: introduce ksys_ipc()/compat_ksys_ipc() for s390 s390: use generic UID16 implementation s390: autogenerate compat syscall wrappers s390: remove compat_wrapper.c arch/s390/Kconfig | 2 + arch/s390/include/asm/syscall_wrapper.h | 136 +++++++++++ arch/s390/include/uapi/asm/posix_types.h | 6 + arch/s390/kernel/Makefile | 2 +- arch/s390/kernel/compat_linux.c | 235 +------------------ arch/s390/kernel/compat_wrapper.c | 186 --------------- arch/s390/kernel/entry.S | 4 +- arch/s390/kernel/sys_s390.c | 14 +- arch/s390/kernel/syscalls/syscall.tbl | 286 +++++++++++------------ include/linux/syscalls.h | 4 + ipc/syscall.c | 20 +- 11 files changed, 322 insertions(+), 573 deletions(-) create mode 100644 arch/s390/include/asm/syscall_wrapper.h delete mode 100644 arch/s390/kernel/compat_wrapper.c -- 2.20.0

7 years, 2 months

3
16
0 0

Data structures defined by both linux and musl

by Arnd Bergmann

I recently discussed with Rich about the work needed to get 64-bit time_t support into musl. One of the first steps he identified was to find out which interfaces we would want to abstract or wrap for a new ABI given that we have to make a binary incompatible interface anyway. I have found all the data structures that are provided by both the kernel headers and the musl headers now, and annotated what I think we the path forward could be. I already provided the same list on IRC, but here is a (slightly updated) copy for everyone else. The takeaway is that we probably need to add new definitions for flock64, statfs, stat, termios, {msg,sem,shm}{buf,info,id_ds}, ipc_perm, rlimit, rusage, sched_param, time_t, timeval, timespec, itimerval, itimerspec, and timex, and then wrap all kernel interfaces that use those. The same list can also be helpful when we try to clean up the kernel header files -- my idea was that we may want to prefix each struct tag with __kernel_ as we do for typedefs, and then have a kernel header that redefines them like #ifdef __WANT_KERNEL_STRUCTS #define __kernel_flock flock #endif struct __kernel_flock { ... }; Arnd /* sparc and mips are incompatible, keep wrapping flock64 */ include/uapi/asm-generic/fcntl.h:struct flock { arch/mips/include/uapi/asm/fcntl.h:struct flock { /* pt_regs and sigcontext are arch specific, cannot abstract */ arch/*/include/uapi/asm/ptrace.h:struct pt_regs { arch/*/include/uapi/asm/ptrace.h:struct user_regs_struct { arch/arm64/include/uapi/asm/sigcontext.h:struct _aarch64_ctx { arch/arm64/include/uapi/asm/sigcontext.h:struct esr_context { arch/arm64/include/uapi/asm/sigcontext.h:struct extra_context { arch/arm64/include/uapi/asm/sigcontext.h:struct sve_context { arch/*/include/uapi/asm/sigcontext.h:struct sigcontext { /* arch specific, has wrapper */ arch/*/include/uapi/asm/signal.h:struct sigaction { include/uapi/asm-generic/signal.h:struct sigaction { /* arch specific, maybe add wrapper? */ arch/*/include/uapi/asm/signal.h:typedef struct sigaltstack { include/uapi/asm-generic/signal.h:typedef struct sigaltstack { /* arch specific, need to look closer for incompatibilities */ include/uapi/asm-generic/siginfo.h:typedef struct sigevent { /* arch specific, should add wrapper */ arch/*/include/uapi/asm/statfs.h:struct statfs { include/uapi/asm-generic/statfs.h:struct statfs { /* arch specific, wrap statx instead */ arch/*/include/uapi/asm/stat.h:struct stat { include/uapi/asm-generic/stat.h:struct stat { include/uapi/linux/stat.h:struct statx { include/uapi/linux/stat.h:struct statx_timestamp { /* arch specific, should wrap termios2 where possible, * need to check what musl does now */ arch/*/include/uapi/asm/termbits.h:struct termios { include/uapi/asm-generic/termbits.h:struct termios { /* IPC: wrap them all */ include/uapi/linux/mqueue.h:struct mq_attr { include/uapi/linux/msg.h:struct msgbuf { include/uapi/linux/msg.h:struct msginfo { include/uapi/linux/msg.h:struct msqid_ds { include/uapi/linux/sem.h:struct sembuf { include/uapi/linux/sem.h:struct semid_ds { include/uapi/linux/sem.h:struct seminfo { include/uapi/linux/shm.h:struct shmid_ds { include/uapi/linux/shm.h:struct shm_info { include/uapi/linux/shm.h:struct shminfo { /* rlimit/rlimit64: keep using only rlimit64 */ include/uapi/linux/resource.h:struct rlimit { include/uapi/linux/resource.h:struct rlimit64 { /* rusuage: need to wrap: getrusage, wait4 */ include/uapi/linux/resource.h:struct rusage { /* wrapped already, replace with a more extensible one */ include/uapi/linux/sched/types.h:struct sched_param { /* prctl(PR_SET_MM); broken in kernel compat mode? * could be wrapped if necessary */ include/uapi/linux/prctl.h:struct prctl_mm_map { /* inconsistent amount of padding, maybe wrap */ include/uapi/linux/sysinfo.h:struct sysinfo { /* time64: need to use 64-bit versions of time_t */ include/uapi/linux/time.h:timespec { include/uapi/linux/time.h:struct itimerspec { /* need to wrap */ include/uapi/linux/utime.h:struct utimbuf { include/uapi/linux/time.h:timeval { include/uapi/linux/time.h:struct itimerval { /* no need to change */ include/uapi/linux/time.h:struct timezone { /* probably need to wrap (depending on kernel decision) */ include/uapi/linux/timex.h:struct timex { /* incompatible on x32 */ include/uapi/linux/times.h:struct tms { include/uapi/linux/uio.h:struct iovec { /* tape driver ioctls, musl copy is incompatible * on mips64, sparc64 */ include/uapi/linux/mtio.h:struct mtget { include/uapi/linux/mtio.h:struct mtop { include/uapi/linux/mtio.h:struct mtpos { /* compatible, no need to wrap */ include/uapi/asm-generic/fcntl.h:struct f_owner_ex { include/uapi/asm-generic/poll.h:struct pollfd { include/uapi/asm-generic/termios.h:struct winsize { include/uapi/linux/acct.h:struct acct_v3 include/uapi/linux/eventpoll.h:struct epoll_event { include/uapi/linux/fanotify.h:struct fanotify_event_metadata { include/uapi/linux/fanotify.h:struct fanotify_response { include/uapi/linux/signalfd.h:struct signalfd_siginfo { /* fixed wire format */ include/uapi/linux/udp.h:struct udphdr { include/uapi/linux/icmp.h:struct icmphdr { include/uapi/linux/if_arp.h:struct arphdr { include/uapi/linux/tcp.h:struct tcphdr { include/uapi/linux/if_ether.h:struct ethhdr { include/uapi/linux/ip.h:struct iphdr { /* other network stuff, fixed format */ include/uapi/linux/icmpv6.h:struct icmp6_filter { include/uapi/linux/if_arp.h:struct arpreq { include/uapi/linux/if_arp.h:struct arpreq_old { include/uapi/linux/if.h:struct ifconf { include/uapi/linux/if.h:struct ifmap { include/uapi/linux/if.h:struct ifreq { include/uapi/linux/if_packet.h:struct packet_mreq { include/uapi/linux/if_packet.h:struct sockaddr_ll { include/uapi/linux/in6.h:struct in6_addr { include/uapi/linux/in6.h:struct ipv6_mreq { include/uapi/linux/in6.h:struct sockaddr_in6 { include/uapi/linux/in.h:struct group_filter { include/uapi/linux/in.h:struct group_req { include/uapi/linux/in.h:struct group_source_req { include/uapi/linux/in.h:struct in_addr { include/uapi/linux/in.h:struct in_pktinfo { include/uapi/linux/in.h:struct ip_mreq { include/uapi/linux/in.h:struct ip_mreqn { include/uapi/linux/in.h:struct ip_mreq_source { include/uapi/linux/in.h:struct ip_msfilter { include/uapi/linux/in.h:struct sockaddr_in { include/uapi/linux/inotify.h:struct inotify_event { include/uapi/linux/ipc.h:struct ipc_perm include/uapi/linux/ipv6.h:struct in6_pktinfo { include/uapi/linux/ipv6.h:struct ip6_mtuinfo { include/uapi/linux/ipv6_route.h:struct in6_rtmsg { include/uapi/linux/route.h:struct rtentry { include/uapi/linux/tcp.h:struct tcp_diag_md5sig { include/uapi/linux/tcp.h:struct tcp_info { include/uapi/linux/tcp.h:struct tcp_md5sig { include/uapi/linux/tcp.h:struct tcp_repair_window { include/uapi/linux/un.h:struct sockaddr_un { /* shared typedefs: all in ELF format; can't change */ arch/*/include/uapi/asm/elf.h:typedef ... elf_fpregset_t; arch/*/include/uapi/asm/elf.h:typedef ... elf_greg_t; arch/*/include/uapi/asm/elf.h:typedef elf_greg_t elf_gregset_t[ELF_NGREG]; arch/sparc/include/uapi/asm/uctx.h:} mcontext_t; arch/sparc/include/uapi/asm/uctx.h:typedef struct ucontext ucontext_t; include/uapi/linux/elf.h:typedef struct elf32_hdr Elf32_Ehdr; include/uapi/linux/elf.h:typedef struct elf64_hdr Elf64_Ehdr; include/uapi/linux/elf.h:typedef struct {...} Elf32_Shdr; include/uapi/linux/elf.h:typedef struct {...} Elf64_Shdr; include/uapi/linux/elf.h:typedef struct {...} Elf32_Chdr; include/uapi/linux/elf.h:typedef struct {...} Elf64_Chdr; include/uapi/linux/elf.h:typedef struct {...} Elf32_Nhdr; include/uapi/linux/elf.h:typedef struct {...} Elf64_Nhdr; include/uapi/linux/elf.h:typedef ... include/uapi/linux/elfcore.h:typedef elf_gregset_t gregset_t; include/uapi/linux/elfcore.h: elf_gregset_t pr_reg; /* GP registers */ include/uapi/linux/elfcore.h:typedef elf_greg_t greg_t; include/uapi/linux/elfcore.h:typedef elf_gregset_t gregset_t; include/uapi/linux/elfcore.h:typedef elf_fpregset_t fpregset_t; include/uapi/linux/elfcore.h:struct elf_prpsinfo include/uapi/linux/elfcore.h:struct elf_prstatus include/uapi/linux/elfcore.h:struct elf_siginfo /* sg.h missing from exported kernel headers, can't change */ include/scsi/sg.h:typedef struct sg_iovec sg_iovec_t; include/scsi/sg.h:typedef struct sg_io_hdr sg_io_hdr_t; include/scsi/sg.h-struct sg_scsi_id { include/scsi/sg.h:typedef struct sg_req_info sg_req_info_t; include/scsi/sg.h:typedef struct sg_io_hdr Sg_io_hdr; include/scsi/sg.h:typedef struct sg_io_vec Sg_io_vec; include/scsi/sg.h:typedef struct sg_scsi_id Sg_scsi_id; include/scsi/sg.h:typedef struct sg_req_info Sg_req_info; include/scsi/sg.h-struct sg_header { /* 32-bit on alpha, used in ustat (not provided by musl) */ include/uapi/asm-generic/posix_types.h:typedef __kernel_ulong_t __kernel_ino_t; /* 64-bit on mips64, used in mtio (should fix?) and ustat */ include/uapi/asm-generic/posix_types.h:typedef int __kernel_daddr_t; /* 16 bit on older architectures but only used in IPC interfaces, which will get wrapped anyway */ include/uapi/asm-generic/posix_types.h:typedef unsigned int __kernel_mode_t; include/uapi/asm-generic/posix_types.h:typedef int __kernel_ipc_pid_t; include/uapi/asm-generic/posix_types.h:typedef unsigned int __kernel_uid_t; include/uapi/asm-generic/posix_types.h:typedef unsigned int __kernel_gid_t;

7 years, 2 months

1
2
0 0

[PATCH] input_event: Provide override for sparc64

by Deepa Dinamani

The usec part of the timeval is defined as __kernel_suseconds_t tv_usec; /* microseconds */ Arnd noticed that sparc64 is the only architecture that defines __kernel_suseconds_t as int rather than long. This breaks the current y2038 fix for kernel as we only access and define the timeval struct for non-kernel use cases. But, this was hidden by an another typo in the use of __KERNEL__ qualifier. Fix the typo, and provide an override for sparc64. Fixes: 152194fe9c3f ("Input: extend usable life of event timestamps to 2106 on 32 bit systems") Reported-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- include/uapi/linux/input.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index fb78f6f500f3..ffab958bc512 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h @@ -26,13 +26,17 @@ */ struct input_event { -#if (__BITS_PER_LONG != 32 || !defined(__USE_TIME_BITS64)) && !defined(__KERNEL) +#if (__BITS_PER_LONG != 32 || !defined(__USE_TIME_BITS64)) && !defined(__KERNEL__) struct timeval time; #define input_event_sec time.tv_sec #define input_event_usec time.tv_usec #else __kernel_ulong_t __sec; +#ifdef CONFIG_SPARC64 + unsigned int __usec; +#else __kernel_ulong_t __usec; +#endif #define input_event_sec __sec #define input_event_usec __usec #endif -- 2.17.1

7 years, 2 months

4
6
0 0

[PATCH 00/15] arch: synchronize syscall tables in preparation for y2038

by Arnd Bergmann

The system call tables have diverged a bit over the years, and a number of the recent additions never made it into all architectures, for one reason or another. This is an attempt to clean it up as far as we can without breaking compatibility, doing a number of steps: - Add system calls that have not yet been integrated into all architectures but that we definitely want there. - Add the separate ipc syscalls on all architectures that traditionally only had sys_ipc(). This version is done without support for IPC_OLD that is we have in sys_ipc. The new semtimedop_time64 syscall will only be added here, not in sys_ipc - Add syscall numbers for a couple of syscalls that we probably don't need everywhere, in particular pkey_* and rseq, for the purpose of symmetry: if it's in asm-generic/unistd.h, it makes sense to have it everywhere. - Prepare for having the same system call numbers for any future calls. In combination with the generated tables, this hopefully makes it easier to add new calls across all architectures together. Most of the contents of this series are unrelated to the actual y2038 work, but for the moment, that second series is based on this one. If there are any concerns about changes here, I can drop or rewrite any individual patch in this series. My plan is to merge any patches in this series that are found to be good together with the y2038 patches for linux-5.1, so please review and provide Acks for merging through my tree, or pick them up for 5.0 if they seem urgent enough. Arnd Arnd Bergmann (15): ia64: add __NR_umount2 definition ia64: add statx and io_pgetevents syscalls ia64: assign syscall numbers for perf and seccomp alpha: wire up io_pgetevents system call alpha: update syscall macro definitions ARM: add migrate_pages() system call ARM: add kexec_file_load system call number m68k: assign syscall number for seccomp sh: remove duplicate unistd_32.h file sh: add statx system call mips: fix n32 compat_ipc_parse_version sparc64: fix sparc_ipc type conversion ipc: rename old-style shmctl/semctl/msgctl syscalls arch: add split IPC system calls where needed arch: add pkey and rseq syscall numbers everywhere arch/alpha/include/asm/unistd.h | 10 - arch/alpha/include/uapi/asm/unistd.h | 5 + arch/alpha/kernel/syscalls/syscall.tbl | 15 +- arch/arm/include/asm/unistd.h | 1 - arch/arm/tools/syscall.tbl | 8 +- arch/arm64/include/asm/unistd.h | 2 +- arch/arm64/include/asm/unistd32.h | 10 +- arch/ia64/include/asm/unistd.h | 14 - arch/ia64/include/uapi/asm/unistd.h | 2 + arch/ia64/kernel/syscalls/syscall.tbl | 10 +- arch/m68k/kernel/syscalls/syscall.tbl | 16 + arch/microblaze/kernel/syscalls/syscall.tbl | 6 +- arch/mips/Kconfig | 1 + arch/mips/kernel/syscalls/syscall_n32.tbl | 6 +- arch/mips/kernel/syscalls/syscall_n64.tbl | 6 +- arch/mips/kernel/syscalls/syscall_o32.tbl | 11 + arch/parisc/include/asm/unistd.h | 3 - arch/parisc/kernel/syscalls/syscall.tbl | 4 + arch/powerpc/kernel/syscalls/syscall.tbl | 12 + arch/s390/include/asm/unistd.h | 3 - arch/s390/kernel/syscalls/syscall.tbl | 15 + arch/sh/include/uapi/asm/unistd_32.h | 403 -------------------- arch/sh/kernel/syscalls/syscall.tbl | 16 + arch/sparc/include/asm/unistd.h | 5 - arch/sparc/kernel/sys_sparc_64.c | 2 +- arch/sparc/kernel/syscalls/syscall.tbl | 16 + arch/x86/entry/syscalls/syscall_32.tbl | 11 + arch/xtensa/kernel/syscalls/syscall.tbl | 7 +- include/linux/syscalls.h | 3 + ipc/msg.c | 39 +- ipc/sem.c | 39 +- ipc/shm.c | 40 +- ipc/syscall.c | 12 +- ipc/util.h | 21 +- kernel/sys_ni.c | 3 + 35 files changed, 271 insertions(+), 506 deletions(-) delete mode 100644 arch/sh/include/uapi/asm/unistd_32.h -- 2.20.0 Cc: ink(a)jurassic.park.msu.ru Cc: mattst88(a)gmail.com Cc: linux(a)armlinux.org.uk Cc: catalin.marinas(a)arm.com Cc: will.deacon(a)arm.com Cc: tony.luck(a)intel.com Cc: fenghua.yu(a)intel.com Cc: geert(a)linux-m68k.org Cc: monstr(a)monstr.eu Cc: paul.burton(a)mips.com Cc: deller(a)gmx.de Cc: mpe(a)ellerman.id.au Cc: schwidefsky(a)de.ibm.com Cc: heiko.carstens(a)de.ibm.com Cc: dalias(a)libc.org Cc: davem(a)davemloft.net Cc: luto(a)kernel.org Cc: tglx(a)linutronix.de Cc: mingo(a)redhat.com Cc: hpa(a)zytor.com Cc: x86(a)kernel.org Cc: jcmvbkbc(a)gmail.com Cc: arnd(a)arndb.de Cc: firoz.khan(a)linaro.org Cc: ebiederm(a)xmission.com Cc: deepa.kernel(a)gmail.com Cc: linux(a)dominikbrodowski.net Cc: akpm(a)linux-foundation.org Cc: dave(a)stgolabs.net Cc: linux-alpha(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-ia64(a)vger.kernel.org Cc: linux-m68k(a)lists.linux-m68k.org Cc: linux-mips(a)vger.kernel.org Cc: linux-parisc(a)vger.kernel.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: linux-s390(a)vger.kernel.org Cc: linux-sh(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org Cc: linux-api(a)vger.kernel.org CC: y2038(a)lists.linaro.org

7 years, 2 months

9
46
0 0

Re: [Y2038] [PATCH 0/2] microblaze: Unify the system call scripts

by Firoz Khan

Hi Michal, On Thu, 3 Jan 2019 at 18:00, Michal Simek <monstr(a)monstr.eu> wrote: > > arch/microblaze/kernel/syscall_table.S | 2 +- > > arch/microblaze/kernel/syscalls/Makefile | 11 ++++++-- > > arch/microblaze/kernel/syscalls/syscallhdr.sh | 36 --------------------------- > > arch/microblaze/kernel/syscalls/syscalltbl.sh | 32 ------------------------ > > 4 files changed, 10 insertions(+), 71 deletions(-) > > delete mode 100644 arch/microblaze/kernel/syscalls/syscallhdr.sh > > delete mode 100644 arch/microblaze/kernel/syscalls/syscalltbl.sh > > > > Looks good. Will keep this in my queue till depending patch is applied. Thanks for the feedback. As Geert shared few feedback while m68k review, Hopefully, I may have to include those changes here also. Firoz

7 years, 2 months

1
1
0 0

[PATCH 0/2] parisc: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): parisc: remove nargs from __SYSCALL parisc: generate uapi header and system call table files arch/parisc/kernel/syscall.S | 2 +- arch/parisc/kernel/syscalls/Makefile | 11 ++++++++-- arch/parisc/kernel/syscalls/syscallhdr.sh | 36 ------------------------------- arch/parisc/kernel/syscalls/syscalltbl.sh | 36 ------------------------------- 4 files changed, 10 insertions(+), 75 deletions(-) delete mode 100644 arch/parisc/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/parisc/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 2 months

2
4
0 0

[PATCH 0/2] sh: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): sh: remove nargs from __SYSCALL sh: generate uapi header and syscall table header files arch/sh/kernel/syscalls/Makefile | 11 +++++++++-- arch/sh/kernel/syscalls/syscallhdr.sh | 36 ----------------------------------- arch/sh/kernel/syscalls/syscalltbl.sh | 32 ------------------------------- arch/sh/kernel/syscalls_32.S | 2 +- 4 files changed, 10 insertions(+), 71 deletions(-) delete mode 100644 arch/sh/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/sh/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 2 months

4
6
0 0

[PATCH 00/11] y2038: add time64 syscalls

by Arnd Bergmann

This series finally gets us to the point of having system calls with 64-bit time_t on all architectures, after a long time of incremental preparation patches. There was actually one conversion that I missed during the summer, i.e. Deepa's timex series, which I now updated based the 5.0-rc1 changes and review comments. I hope that the actual conversion should be uncontroversial by now, even if some of the patches are rather large. The one area that may need a little discussion is for the system call numbers assigned in the final patch: Can we get consensus on whether the idea of using the same numbers on all architectures, as well as my choice of numbers makes sense here? So far, I have done a lot of build testing across most architectures, which has found a number of bugs. I have also done an LTP run on arm32 with existing user space, but not on the other architectures. I did LTP tests with a modified musl libc[2] last summer on an older version of this series to make sure that the new 64-bit time_t interfaces work. The version there will need updates for testing with this new kernel patch series; I plan to do that next. For testing, the series plus the preparatory patches is available at [3]. Once there is a general agreement on this series and I have done more tests for the new system calls, I plan to add this to linux-next through my asm-generic tree or Thomas' timers tree. Please review and test! Arnd [1] https://lore.kernel.org/lkml/20190110162435.309262-1-arnd@arndb.de/T/ [2] https://git.linaro.org/people/arnd/musl-y2038.git/ [3] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git y2038-5.0-rc1 Arnd Bergmann (8): time: make adjtime compat handling available for 32 bit time: fix sys_timer_settime prototype sparc64: add custom adjtimex/clock_adjtime functions y2038: syscalls: rename y2038 compat syscalls y2038: use time32 syscall names on 32-bit y2038: remove struct definition redirects y2038: rename old time and utime syscalls y2038: add 64-bit time_t syscalls to all 32-bit architectures Deepa Dinamani (3): time: Add struct __kernel_timex timex: use __kernel_timex internally timex: change syscalls to use struct __kernel_timex arch/Kconfig | 2 +- arch/alpha/kernel/osf_sys.c | 5 +- arch/alpha/kernel/syscalls/syscall.tbl | 2 + arch/arm/include/asm/unistd.h | 4 +- arch/arm/kernel/sys_oabi-compat.c | 8 +- arch/arm/tools/syscall.tbl | 77 ++++++++----- arch/arm64/include/asm/unistd.h | 2 +- arch/arm64/include/asm/unistd32.h | 89 ++++++++++---- arch/ia64/kernel/syscalls/syscall.tbl | 1 + arch/m68k/include/asm/unistd.h | 4 +- arch/m68k/kernel/syscalls/syscall.tbl | 72 +++++++----- arch/microblaze/include/asm/unistd.h | 4 +- arch/microblaze/kernel/syscalls/syscall.tbl | 77 ++++++++----- arch/mips/include/asm/unistd.h | 4 +- arch/mips/kernel/syscalls/syscall_n32.tbl | 71 ++++++++---- arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + arch/mips/kernel/syscalls/syscall_o32.tbl | 74 +++++++----- arch/parisc/include/asm/unistd.h | 9 +- arch/parisc/kernel/syscalls/syscall.tbl | 105 ++++++++++++----- arch/powerpc/include/asm/unistd.h | 8 +- arch/powerpc/kernel/syscalls/syscall.tbl | 121 +++++++++++++++----- arch/s390/include/asm/unistd.h | 2 +- arch/s390/kernel/syscalls/syscall.tbl | 72 +++++++----- arch/sh/include/asm/unistd.h | 4 +- arch/sh/kernel/syscalls/syscall.tbl | 72 +++++++----- arch/sparc/include/asm/unistd.h | 8 +- arch/sparc/kernel/sys_sparc_64.c | 59 +++++++++- arch/sparc/kernel/syscalls/syscall.tbl | 100 +++++++++++----- arch/x86/entry/syscalls/syscall_32.tbl | 74 +++++++----- arch/x86/entry/syscalls/syscall_64.tbl | 4 +- arch/x86/include/asm/unistd.h | 8 +- arch/xtensa/include/asm/unistd.h | 2 +- arch/xtensa/kernel/syscalls/syscall.tbl | 71 ++++++++---- drivers/ptp/ptp_clock.c | 2 +- fs/aio.c | 10 +- fs/select.c | 4 +- fs/timerfd.c | 4 +- fs/utimes.c | 10 +- include/linux/compat.h | 104 +---------------- include/linux/posix-clock.h | 2 +- include/linux/syscalls.h | 65 ++++++++++- include/linux/time32.h | 32 +++++- include/linux/time64.h | 8 -- include/linux/timex.h | 4 +- include/uapi/asm-generic/unistd.h | 103 ++++++++++++----- include/uapi/linux/time.h | 4 - include/uapi/linux/timex.h | 39 +++++++ ipc/mqueue.c | 16 +-- ipc/sem.c | 2 +- kernel/compat.c | 64 ----------- kernel/futex.c | 2 +- kernel/sched/core.c | 5 +- kernel/signal.c | 2 +- kernel/sys_ni.c | 18 +-- kernel/time/hrtimer.c | 2 +- kernel/time/ntp.c | 18 +-- kernel/time/ntp_internal.h | 2 +- kernel/time/posix-clock.c | 2 +- kernel/time/posix-stubs.c | 25 ++-- kernel/time/posix-timers.c | 72 ++++++------ kernel/time/posix-timers.h | 2 +- kernel/time/time.c | 92 ++++++++++++--- kernel/time/timekeeping.c | 4 +- net/compat.c | 2 +- scripts/checksyscalls.sh | 40 +++++++ 65 files changed, 1264 insertions(+), 713 deletions(-) -- 2.20.0 Cc: mattst88(a)gmail.com Cc: linux(a)armlinux.org.uk Cc: catalin.marinas(a)arm.com Cc: will.deacon(a)arm.com Cc: tony.luck(a)intel.com Cc: fenghua.yu(a)intel.com Cc: geert(a)linux-m68k.org Cc: monstr(a)monstr.eu Cc: paul.burton(a)mips.com Cc: deller(a)gmx.de Cc: benh(a)kernel.crashing.org Cc: mpe(a)ellerman.id.au Cc: schwidefsky(a)de.ibm.com Cc: heiko.carstens(a)de.ibm.com Cc: dalias(a)libc.org Cc: davem(a)davemloft.net Cc: luto(a)kernel.org Cc: tglx(a)linutronix.de Cc: mingo(a)redhat.com Cc: hpa(a)zytor.com Cc: x86(a)kernel.org Cc: jcmvbkbc(a)gmail.com Cc: arnd(a)arndb.de Cc: akpm(a)linux-foundation.org Cc: deepa.kernel(a)gmail.com Cc: ebiederm(a)xmission.com Cc: firoz.khan(a)linaro.org Cc: linux-kernel(a)vger.kernel.org Cc: linux-alpha(a)vger.kernel.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-ia64(a)vger.kernel.org Cc: linux-m68k(a)lists.linux-m68k.org Cc: linux-mips(a)vger.kernel.org Cc: linux-parisc(a)vger.kernel.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: linux-s390(a)vger.kernel.org Cc: linux-sh(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org Cc: netdev(a)vger.kernel.org Cc: linux-fsdevel(a)vger.kernel.org Cc: linux-api(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org

7 years, 2 months

2
12
0 0

[PATCH v2] scripts/syscalls: add system call table file for asm-generic

by Firoz Khan

Add system call table file - syscall.tbl which can be use by the system call table generation script to generate the equi- valent file for asm-generic/unistd.h for architectures which include the same file. The system call table generation script will use syscall.tbl file as input to generate the uapi and kapi header files. Added some extra abi to make the syscall.tbl file generic and can be use the same file for architectures which include the file asm-generic/unistd.h. This patch is depends on: https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Signed-off-by: Firoz Khan <firoz.khan(a)linaro.org> --- Changes since v1: - added syscall entry kexec_file_load. - modified the custom abi from archsp to archs*. - removed the entry cacheflush. - modified the entry from arch_specific_syscall to arch_specific_syscall0. --- scripts/syscalls/syscall.tbl | 358 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 358 insertions(+) create mode 100644 scripts/syscalls/syscall.tbl diff --git a/scripts/syscalls/syscall.tbl b/scripts/syscalls/syscall.tbl new file mode 100644 index 0000000..4a3395b --- /dev/null +++ b/scripts/syscalls/syscall.tbl @@ -0,0 +1,358 @@ +# SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note +# +# system call numbers and entry vectors for asm-generic +# +# The format is: +# <number> <abi> <name> <entry point> <compat entry point> +# +# The <abi> is always "common" for this file. +# +0 common io_setup sys_io_setup compat_sys_io_setup +1 common io_destroy sys_io_destroy +2 common io_submit sys_io_submit compat_sys_io_submit +3 common io_cancel sys_io_cancel +4 common io_getevents sys_io_getevents compat_sys_io_getevents +# fs/xattr.c +5 common setxattr sys_setxattr +6 common lsetxattr sys_lsetxattr +7 common fsetxattr sys_fsetxattr +8 common getxattr sys_getxattr +9 common lgetxattr sys_lgetxattr +10 common fgetxattr sys_fgetxattr +11 common listxattr sys_listxattr +12 common llistxattr sys_llistxattr +13 common flistxattr sys_flistxattr +14 common removexattr sys_removexattr +15 common lremovexattr sys_lremovexattr +16 common fremovexattr sys_fremovexattr +# fs/dcache.c +17 common getcwd sys_getcwd +# fs/cookies.c +18 common lookup_dcookie sys_lookup_dcookie compat_sys_lookup_dcookie +# fs/eventfd.c +19 common eventfd2 sys_eventfd2 +# fs/eventpoll.c +20 common epoll_create1 sys_epoll_create1 +21 common epoll_ctl sys_epoll_ctl +22 common epoll_pwait sys_epoll_pwait compat_sys_epoll_pwait +# fs/fcntl.c +23 common dup sys_dup +24 common dup3 sys_dup3 +25 32 fcntl64 sys_fcntl64 compat_sys_fcntl64 +25 64 fcntl sys_fcntl +# fs/inotify_user.c +26 common inotify_init1 sys_inotify_init1 +27 common inotify_add_watch sys_inotify_add_watch +28 common inotify_rm_watch sys_inotify_rm_watch +# fs/ioctl.c +29 common ioctl sys_ioctl compat_sys_ioctl +# fs/ioprio.c +30 common ioprio_set sys_ioprio_set +31 common ioprio_get sys_ioprio_get +# fs/locks.c +32 common flock sys_flock +# fs/namei.c +33 common mknodat sys_mknodat +34 common mkdirat sys_mkdirat +35 common unlinkat sys_unlinkat +36 common symlinkat sys_symlinkat +37 common linkat sys_linkat +38 rename renameat sys_renameat +# fs/namespace.c +39 common umount2 sys_umount +40 common mount sys_mount compat_sys_mount +41 common pivot_root sys_pivot_root +# fs/nfsctl.c +42 common nfsservctl sys_ni_syscall +# fs/open.c +43 32 statfs64 sys_statfs64 compat_sys_statfs64 +43 64 statfs sys_statfs +44 32 fstatfs64 sys_fstatfs64 compat_sys_fstatfs64 +44 64 fstatfs sys_fstatfs +45 32 truncate64 sys_truncate64 compat_sys_truncate64 +45 64 truncate sys_truncate +46 32 ftruncate64 sys_ftruncate64 compat_sys_ftruncate64 +46 64 ftruncate sys_ftruncate +47 common fallocate sys_fallocate compat_sys_fallocate +48 common faccessat sys_faccessat +49 common chdir sys_chdir +50 common fchdir sys_fchdir +51 common chroot sys_chroot +52 common fchmod sys_fchmod +53 common fchmodat sys_fchmodat +54 common fchownat sys_fchownat +55 common fchown sys_fchown +56 common openat sys_openat compat_sys_openat +57 common close sys_close +58 common vhangup sys_vhangup +# fs/pipe.c +59 common pipe2 sys_pipe2 +# fs/quota.c +60 common quotactl sys_quotactl +# fs/readdir.c +61 common getdents64 sys_getdents64 +# fs/read_write.c +62 32 llseek sys_llseek +62 64 lseek sys_lseek +63 common read sys_read +64 common write sys_write +65 common readv sys_readv compat_sys_readv +66 common writev sys_writev compat_sys_writev +67 common pread64 sys_pread64 compat_sys_pread64 +68 common pwrite64 sys_pwrite64 compat_sys_pwrite64 +69 common preadv sys_preadv compat_sys_preadv +70 common pwritev sys_pwritev compat_sys_pwritev +# fs/sendfile.c +71 32 sendfile64 sys_sendfile64 +71 64 sendfile sys_sendfile64 +# fs/select.c +72 common pselect6 sys_pselect6 compat_sys_pselect6 +73 common ppoll sys_ppoll compat_sys_ppoll +# fs/signalfd.c +74 common signalfd4 sys_signalfd4 compat_sys_signalfd4 +# fs/splice.c +75 common vmsplice sys_vmsplice compat_sys_vmsplice +76 common splice sys_splice +77 common tee sys_tee +# fs/stat.c +78 common readlinkat sys_readlinkat +79 stat64 fstatat64 sys_fstatat64 +79 nwstat newfstatat sys_newfstatat +80 stat64 fstat64 sys_fstat64 +80 nwstat fstat sys_newfstat +# fs/sync.c +81 common sync sys_sync +82 common fsync sys_fsync +83 common fdatasync sys_fdatasync +84 common sync_file_range sys_sync_file_range compat_sys_sync_file_range +# fs/timerfd.c +85 common timerfd_create sys_timerfd_create +86 common timerfd_settime sys_timerfd_settime compat_sys_timerfd_settime +87 common timerfd_gettime sys_timerfd_gettime compat_sys_timerfd_gettime +# fs/utimes.c +88 common utimensat sys_utimensat compat_sys_utimensat +# kernel/acct.c +89 common acct sys_acct +# kernel/capability.c +90 common capget sys_capget +91 common capset sys_capset +# kernel/exec_domain.c +92 common personality sys_personality +# kernel/exit.c +93 common exit sys_exit +94 common exit_group sys_exit_group +95 common waitid sys_waitid compat_sys_waitid +# kernel/fork.c +96 common set_tid_address sys_set_tid_address +97 common unshare sys_unshare +# kernel/futex.c +98 common futex sys_futex compat_sys_futex +99 common set_robust_list sys_set_robust_list compat_sys_set_robust_list +100 common get_robust_list sys_get_robust_list compat_sys_get_robust_list +# kernel/hrtimer.c +101 common nanosleep sys_nanosleep compat_sys_nanosleep +# kernel/itimer.c +102 common getitimer sys_getitimer compat_sys_getitimer +103 common setitimer sys_setitimer compat_sys_setitimer +# kernel/kexec.c +104 common kexec_load sys_kexec_load compat_sys_kexec_load +# kernel/module.c +105 common init_module sys_init_module +106 common delete_module sys_delete_module +# kernel/posix-timers.c +107 common timer_create sys_timer_create compat_sys_timer_create +108 common timer_gettime sys_timer_gettime compat_sys_timer_gettime +109 common timer_getoverrun sys_timer_getoverrun +110 common timer_settime sys_timer_settime compat_sys_timer_settime +111 common timer_delete sys_timer_delete +112 common clock_settime sys_clock_settime compat_sys_clock_settime +113 common clock_gettime sys_clock_gettime compat_sys_clock_gettime +114 common clock_getres sys_clock_getres compat_sys_clock_getres +115 common clock_nanosleep sys_clock_nanosleep compat_sys_clock_nanosleep +# kernel/printk.c +116 common syslog sys_syslog +# kernel/ptrace.c +117 common ptrace sys_ptrace +# kernel/sched/core.c +118 common sched_setparam sys_sched_setparam +119 common sched_setscheduler sys_sched_setscheduler +120 common sched_getscheduler sys_sched_getscheduler +121 common sched_getparam sys_sched_getparam +122 common sched_setaffinity sys_sched_setaffinity compat_sys_sched_setaffinity +123 common sched_getaffinity sys_sched_getaffinity compat_sys_sched_getaffinity +124 common sched_yield sys_sched_yield +125 common sched_get_priority_max sys_sched_get_priority_max +126 common sched_get_priority_min sys_sched_get_priority_min +127 common sched_rr_get_interval sys_sched_rr_get_interval compat_sys_sched_rr_get_interval +# kernel/signal.c +128 common restart_syscall sys_restart_syscall +129 common kill sys_kill +130 common tkill sys_tkill +131 common tgkill sys_tgkill +132 common sigaltstack sys_sigaltstack compat_sys_sigaltstack +133 common rt_sigsuspend sys_rt_sigsuspend compat_sys_rt_sigsuspend +134 common rt_sigaction sys_rt_sigaction compat_sys_rt_sigaction +135 common rt_sigprocmask sys_rt_sigprocmask compat_sys_rt_sigprocmask +136 common rt_sigpending sys_rt_sigpending compat_sys_rt_sigpending +137 common rt_sigtimedwait sys_rt_sigtimedwait compat_sys_rt_sigtimedwait +138 common rt_sigqueueinfo sys_rt_sigqueueinfo compat_sys_rt_sigqueueinfo +139 common rt_sigreturn sys_rt_sigreturn compat_sys_rt_sigreturn +# kernel/sys.c +140 common setpriority sys_setpriority +141 common getpriority sys_getpriority +142 common reboot sys_reboot +143 common setregid sys_setregid +144 common setgid sys_setgid +145 common setreuid sys_setreuid +146 common setuid sys_setuid +147 common setresuid sys_setresuid +148 common getresuid sys_getresuid +149 common setresgid sys_setresgid +150 common getresgid sys_getresgid +151 common setfsuid sys_setfsuid +152 common setfsgid sys_setfsgid +153 common times sys_times compat_sys_times +154 common setpgid sys_setpgid +155 common getpgid sys_getpgid +156 common getsid sys_getsid +157 common setsid sys_setsid +158 common getgroups sys_getgroups +159 common setgroups sys_setgroups +160 common uname sys_newuname +161 common sethostname sys_sethostname +162 common setdomainname sys_setdomainname +163 common getrlimit sys_getrlimit compat_sys_getrlimit +164 common setrlimit sys_setrlimit compat_sys_setrlimit +165 common getrusage sys_getrusage compat_sys_getrusage +166 common umask sys_umask +167 common prctl sys_prctl +168 common getcpu sys_getcpu +169 common gettimeofday sys_gettimeofday compat_sys_gettimeofday +# kernel/time.c +170 common settimeofday sys_settimeofday compat_sys_settimeofday +171 common adjtimex sys_adjtimex compat_sys_adjtimex +# kernel/timer.c +172 common getpid sys_getpid +173 common getppid sys_getppid +174 common getuid sys_getuid +175 common geteuid sys_geteuid +176 common getgid sys_getgid +177 common getegid sys_getegid +178 common gettid sys_gettid +179 common sysinfo sys_sysinfo compat_sys_sysinfo +# ipc/mqueue.c +180 common mq_open sys_mq_open compat_sys_mq_open +181 common mq_unlink sys_mq_unlink +182 common mq_timedsend sys_mq_timedsend compat_sys_mq_timedsend +183 common mq_timedreceive sys_mq_timedreceive compat_sys_mq_timedreceive +184 common mq_notify sys_mq_notify compat_sys_mq_notify +185 common mq_getsetattr sys_mq_getsetattr compat_sys_mq_getsetattr +# ipc/msg.c +186 common msgget sys_msgget +187 common msgctl sys_msgctl compat_sys_msgctl +188 common msgrcv sys_msgrcv compat_sys_msgrcv +189 common msgsnd sys_msgsnd compat_sys_msgsnd +# ipc/sem.c +190 common semget sys_semget +191 common semctl sys_semctl compat_sys_semctl +192 common semtimedop sys_semtimedop compat_sys_semtimedop +193 common semop sys_semop +# ipc/shm.c +194 common shmget sys_shmget +195 common shmctl sys_shmctl compat_sys_shmctl +196 common shmat sys_shmat compat_sys_shmat +197 common shmdt sys_shmdt +# net/socket.c +198 common socket sys_socket +199 common socketpair sys_socketpair +200 common bind sys_bind +201 common listen sys_listen +202 common accept sys_accept +203 common connect sys_connect +204 common getsockname sys_getsockname +205 common getpeername sys_getpeername +206 common sendto sys_sendto +207 common recvfrom sys_recvfrom compat_sys_recvfrom +208 common setsockopt sys_setsockopt compat_sys_setsockopt +209 common getsockopt sys_getsockopt compat_sys_getsockopt +210 common shutdown sys_shutdown +211 common sendmsg sys_sendmsg compat_sys_sendmsg +212 common recvmsg sys_recvmsg compat_sys_recvmsg +# mm/filemap.c +213 common readahead sys_readahead compat_sys_readahead +# mm/nommu.c, also with MMU +214 common brk sys_brk +215 common munmap sys_munmap +216 common mremap sys_mremap +# security/keys/keyctl.c +217 common add_key sys_add_key +218 common request_key sys_request_key +219 common keyctl sys_keyctl compat_sys_keyctl +# arch/example/kernel/sys_example.c +220 common clone sys_clone +221 common execve sys_execve compat_sys_execve +222 32 mmap2 sys_mmap2 +222 64 mmap sys_mmap +# mm/fadvise.c +223 32 fadvise64_64 sys_fadvise64_64 compat_sys_fadvise64_64 +223 64 fadvise64 sys_fadvise64_64 +224 mmu swapon sys_swapon +225 mmu swapoff sys_swapoff +226 mmu mprotect sys_mprotect +227 mmu msync sys_msync +228 mmu mlock sys_mlock +229 mmu munlock sys_munlock +230 mmu mlockall sys_mlockall +231 mmu munlockall sys_munlockall +232 mmu mincore sys_mincore +233 mmu madvise sys_madvise +234 mmu remap_file_pages sys_remap_file_pages +235 mmu mbind sys_mbind compat_sys_mbind +236 mmu get_mempolicy sys_get_mempolicy compat_sys_get_mempolicy +237 mmu set_mempolicy sys_set_mempolicy compat_sys_set_mempolicy +238 mmu migrate_pages sys_migrate_pages compat_sys_migrate_pages +239 mmu move_pages sys_move_pages compat_sys_move_pages +240 common rt_tgsigqueueinfo sys_rt_tgsigqueueinfo compat_sys_rt_tgsigqueueinfo +241 common perf_event_open sys_perf_event_open +242 common accept4 sys_accept4 +243 common recvmmsg sys_recvmmsg compat_sys_recvmmsg +244 archs0 arch_specific_syscall0 sys_arch_specific_syscall0 +245 archs1 arch_specific_syscall1 sys_arch_specific_syscall1 +246 archs2 arch_specific_syscall2 sys_arch_specific_syscall2 +247 archs3 arch_specific_syscall3 sys_arch_specific_syscall3 +248 archs4 arch_specific_syscall4 sys_arch_specific_syscall4 +260 common wait4 sys_wait4 compat_sys_wait4 +261 common prlimit64 sys_prlimit64 +262 common fanotify_init sys_fanotify_init +263 common fanotify_mark sys_fanotify_mark +264 common name_to_handle_at sys_name_to_handle_at +265 common open_by_handle_at sys_open_by_handle_at compat_sys_open_by_handle_at +266 common clock_adjtime sys_clock_adjtime compat_sys_clock_adjtime +267 common syncfs sys_syncfs +268 common setns sys_setns +269 common sendmmsg sys_sendmmsg compat_sys_sendmmsg +270 common process_vm_readv sys_process_vm_readv compat_sys_process_vm_readv +271 common process_vm_writev sys_process_vm_writev compat_sys_process_vm_writev +272 common kcmp sys_kcmp +273 common finit_module sys_finit_module +274 common sched_setattr sys_sched_setattr +275 common sched_getattr sys_sched_getattr +276 common renameat2 sys_renameat2 +277 common seccomp sys_seccomp +278 common getrandom sys_getrandom +279 common memfd_create sys_memfd_create +280 common bpf sys_bpf +281 common execveat sys_execveat compat_sys_execveat +282 common userfaultfd sys_userfaultfd +283 common membarrier sys_membarrier +284 common mlock2 sys_mlock2 +285 common copy_file_range sys_copy_file_range +286 common preadv2 sys_preadv2 compat_sys_preadv2 +287 common pwritev2 sys_pwritev2 compat_sys_pwritev2 +288 common pkey_mprotect sys_pkey_mprotect +289 common pkey_alloc sys_pkey_alloc +290 common pkey_free sys_pkey_free +291 common statx sys_statx +292 common io_pgetevents sys_io_pgetevents compat_sys_io_pgetevents +293 common rseq sys_rseq +294 common kexec_file_load sys_kexec_file_load -- 1.9.1

7 years, 2 months

2
1
0 0

[PATCH v3 0/8] net: y2038-safe socket timestamps

by Deepa Dinamani

The series introduces new socket timestamps that are y2038 safe. The time data types used for the existing socket timestamp options: SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING are not y2038 safe. The series introduces SO_TIMESTAMP_NEW, SO_TIMESTAMPNS_NEW and SO_TIMESTAMPING_NEW to replace these. These new timestamps can be used on all architectures. The alternative considered was to extend the sys_setsockopt() by using the flags. We did not receive any strong opinions about either of the approaches. Hence, this was chosen, as glibc folks preferred this. The series does not deal with updating the internal kernel socket calls like rxrpc to make them y2038 safe. This will be dealt with separately. Note that the timestamps behavior already does not match the man page specific behavior: SIOCGSTAMP This ioctl should only be used if the socket option SO_TIMESTAMP is not set on the socket. Otherwise, it returns the timestamp of the last packet that was received while SO_TIMESTAMP was not set, or it fails if no such packet has been received, (i.e., ioctl(2) returns -1 with errno set to ENOENT). The recommendation is to update the man page to remove the above statement. The overview of the series is as below: 1. Delete asm specific socket.h when possible. 2. Support SO/SCM_TIMESTAMP* options only in userspace. 3. Rename current SO/SCM_TIMESTAMP* to SO/SCM_TIMESTAMP*_OLD. 3. Alter socket options so that SOCK_RCVTSTAMPNS does not rely on SOCK_RCVTSTAMP. 4. Introduce y2038 safe types for socket timestamp. 5. Introduce new y2038 safe socket options SO/SCM_TIMESTAMP*_NEW. Changes since v2: * Removed extra functions to reduce diff churn as per code review Changes since v1: * Dropped the change to disentangle sock flags * Renamed sock_timeval to __kernel_sock_timeval * Updated a few comments * Added documentation changes Deepa Dinamani (8): arch: Use asm-generic/socket.h when possible sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD arch: sparc: Override struct __kernel_old_timeval socket: Use old_timeval types for socket timestamps socket: Add struct __kernel_sock_timeval socket: Add SO_TIMESTAMP[NS]_NEW socket: Add SO_TIMESTAMPING_NEW socket: Update timestamping Documentation Documentation/networking/timestamping.txt | 43 +++++++- arch/alpha/include/uapi/asm/socket.h | 35 +++++-- arch/ia64/include/uapi/asm/Kbuild | 1 + arch/ia64/include/uapi/asm/socket.h | 120 --------------------- arch/mips/include/uapi/asm/socket.h | 34 ++++-- arch/parisc/include/uapi/asm/socket.h | 34 ++++-- arch/s390/include/uapi/asm/Kbuild | 1 + arch/s390/include/uapi/asm/socket.h | 117 --------------------- arch/sparc/include/uapi/asm/posix_types.h | 10 ++ arch/sparc/include/uapi/asm/socket.h | 36 +++++-- arch/x86/include/uapi/asm/Kbuild | 1 + arch/x86/include/uapi/asm/socket.h | 1 - arch/xtensa/include/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/socket.h | 122 ---------------------- drivers/isdn/mISDN/socket.c | 2 +- include/linux/skbuff.h | 24 ++++- include/linux/socket.h | 8 ++ include/net/sock.h | 1 + include/uapi/asm-generic/socket.h | 35 +++++-- include/uapi/linux/errqueue.h | 4 + include/uapi/linux/time.h | 7 ++ net/bluetooth/hci_sock.c | 4 +- net/compat.c | 14 +-- net/core/scm.c | 27 +++++ net/core/sock.c | 43 ++++++-- net/ipv4/tcp.c | 61 +++++++---- net/rds/af_rds.c | 10 +- net/rds/recv.c | 18 +++- net/rxrpc/local_object.c | 2 +- net/smc/af_smc.c | 3 +- net/socket.c | 50 ++++++--- 32 files changed, 404 insertions(+), 466 deletions(-) delete mode 100644 arch/ia64/include/uapi/asm/socket.h delete mode 100644 arch/s390/include/uapi/asm/socket.h delete mode 100644 arch/x86/include/uapi/asm/socket.h delete mode 100644 arch/xtensa/include/uapi/asm/socket.h base-commit: a4983672f9ca4c8393f26b6b80710e6c78886b8c -- 2.17.1 Cc: chris(a)zankel.net Cc: deller(a)gmx.de Cc: dhowells(a)redhat.com Cc: fenghua.yu(a)intel.com Cc: isdn(a)linux-pingi.de Cc: jejb(a)parisc-linux.org Cc: linux-afs(a)lists.infradead.org Cc: linux-alpha(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org Cc: linux-ia64(a)vger.kernel.org Cc: linux-mips(a)linux-mips.org Cc: linux-parisc(a)vger.kernel.org Cc: linux-rdma(a)vger.kernel.org Cc: linux-s390(a)vger.kernel.org Cc: linux-xtensa(a)linux-xtensa.org Cc: netdev(a)vger.kernel.org Cc: ralf(a)linux-mips.org Cc: rth(a)twiddle.net Cc: schwidefsky(a)de.ibm.com Cc: sparclinux(a)vger.kernel.org Cc: tglx(a)linutronix.de Cc: ubraun(a)linux.ibm.com

7 years, 2 months

5
16
0 0

[PATCH 0/3] net: y2038-safe socket timeout options

by Deepa Dinamani

The series is aimed at adding y2038-safe timeout options: SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW. This is similar to the previous series adding y2038-safe SO_TIMESTAMP* options. The series needs to be applied after the socket timestamp series: https://lore.kernel.org/lkml/20190108032657.8331-1-deepa.kernel@gmail.com Deepa Dinamani (3): socket: Use old_timeval types for socket timeouts socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW arch/alpha/include/uapi/asm/socket.h | 13 ++++- arch/mips/include/uapi/asm/socket.h | 13 ++++- arch/parisc/include/uapi/asm/socket.h | 13 ++++- arch/powerpc/include/uapi/asm/socket.h | 4 +- arch/sparc/include/uapi/asm/socket.h | 13 ++++- fs/dlm/lowcomms.c | 4 +- include/uapi/asm-generic/socket.h | 13 ++++- net/compat.c | 14 ++--- net/core/sock.c | 78 +++++++++++++++++++------- net/vmw_vsock/af_vsock.c | 4 +- 10 files changed, 126 insertions(+), 43 deletions(-) base-commit: a4983672f9ca4c8393f26b6b80710e6c78886b8c prerequisite-patch-id: a03ec6afbdd328cd90557f7ee6675016a5f5c653 prerequisite-patch-id: 724d26c3036e6f3a38f810c2f10db3f7ddbf843b prerequisite-patch-id: 14017867b6eb4d5231eec1b563edcd840a1be26e prerequisite-patch-id: 8df0edfd9b973ff5aae91c7709c8223be096a5bc prerequisite-patch-id: 9850ad48d41bf068f074c0dd3c7610fb7177c89f prerequisite-patch-id: bd31f35bba11902d1cc3e8726492b54df34b5c59 prerequisite-patch-id: ea4b005c5ad188a4e0899d728357c114710a3a8e prerequisite-patch-id: cc3ee912c1ee1ea502ca079de81236a467950501 -- 2.17.1 Cc: ccaulfie(a)redhat.com Cc: cluster-devel(a)redhat.com Cc: davem(a)davemloft.net Cc: deller(a)gmx.de Cc: linux-alpha(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org Cc: linux-mips(a)vger.kernel.org Cc: linux-parisc(a)vger.kernel.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: paulus(a)samba.org Cc: ralf(a)linux-mips.org Cc: rth(a)twiddle.net Cc: sparclinux(a)vger.kernel.org

7 years, 2 months

2
7
0 0

[PATCH 0/3] c6x: system call table generation for asm-generic

by Firoz Khan

This will be an automated scripts to provide easy support for add/modify/delete the system call entry by add entry in respective syscall.tbl file. System call table generation support for asm-generic is provide for c6x architecture which will use the common scripts resides in scripts directory and use syscall.tbl as inputs. This implementation will replace asm-generic- /unistd.h. This patch depends on: https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… https://lore.kernel.org/lkml/1546520681-24453-1-git-send-email-firoz.khan@l… Firoz Khan (3): c6x: add Makefile to invoke syscall table generation script c6x: add __ARCH_NOMMU as a bugfix c6x: generate uapi and kapi headers arch/c6x/Makefile | 3 +++ arch/c6x/include/asm/Kbuild | 1 + arch/c6x/include/uapi/asm/Kbuild | 1 + arch/c6x/include/uapi/asm/unistd.h | 15 +++++++++----- arch/c6x/kernel/sys_c6x.c | 3 ++- arch/c6x/kernel/syscalls/Makefile | 41 ++++++++++++++++++++++++++++++++++++++ 6 files changed, 58 insertions(+), 6 deletions(-) create mode 100644 arch/c6x/kernel/syscalls/Makefile -- 1.9.1

7 years, 2 months

2
4
0 0

[PATCH 0/2] xtensa: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): xtensa: remove nargs from __SYSCALL xtensa: generate uapi header and syscall table header files arch/xtensa/kernel/syscall.c | 2 +- arch/xtensa/kernel/syscalls/Makefile | 11 ++++++++-- arch/xtensa/kernel/syscalls/syscallhdr.sh | 36 ------------------------------- arch/xtensa/kernel/syscalls/syscalltbl.sh | 32 --------------------------- 4 files changed, 10 insertions(+), 71 deletions(-) delete mode 100644 arch/xtensa/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/xtensa/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

2
10
0 0

[PATCH] scripts/syscalls: add system call table file for asm-generic

by Firoz Khan

Add system call table file - syscall.tbl which can be use by the system call table generation script to generate the equi- valent file for asm-generic/unistd.h for architectures which include the same file. The system call table generation script will use syscall.tbl file as input to generate the uapi and kapi header files. Added some extra abi to make the syscall.tbl file generic and can be use the same file for architectures which include the file asm-generic/unistd.h. This patch is depends on: https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Signed-off-by: Firoz Khan <firoz.khan(a)linaro.org> --- scripts/syscalls/syscall.tbl | 358 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 358 insertions(+) create mode 100644 scripts/syscalls/syscall.tbl diff --git a/scripts/syscalls/syscall.tbl b/scripts/syscalls/syscall.tbl new file mode 100644 index 0000000..9ab09d3 --- /dev/null +++ b/scripts/syscalls/syscall.tbl @@ -0,0 +1,358 @@ +# SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note +# +# system call numbers and entry vectors for asm-generic +# +# The format is: +# <number> <abi> <name> <entry point> <compat entry point> +# +# The <abi> is always "common" for this file. +# +0 common io_setup sys_io_setup compat_sys_io_setup +1 common io_destroy sys_io_destroy +2 common io_submit sys_io_submit compat_sys_io_submit +3 common io_cancel sys_io_cancel +4 common io_getevents sys_io_getevents compat_sys_io_getevents +# fs/xattr.c +5 common setxattr sys_setxattr +6 common lsetxattr sys_lsetxattr +7 common fsetxattr sys_fsetxattr +8 common getxattr sys_getxattr +9 common lgetxattr sys_lgetxattr +10 common fgetxattr sys_fgetxattr +11 common listxattr sys_listxattr +12 common llistxattr sys_llistxattr +13 common flistxattr sys_flistxattr +14 common removexattr sys_removexattr +15 common lremovexattr sys_lremovexattr +16 common fremovexattr sys_fremovexattr +# fs/dcache.c +17 common getcwd sys_getcwd +# fs/cookies.c +18 common lookup_dcookie sys_lookup_dcookie compat_sys_lookup_dcookie +# fs/eventfd.c +19 common eventfd2 sys_eventfd2 +# fs/eventpoll.c +20 common epoll_create1 sys_epoll_create1 +21 common epoll_ctl sys_epoll_ctl +22 common epoll_pwait sys_epoll_pwait compat_sys_epoll_pwait +# fs/fcntl.c +23 common dup sys_dup +24 common dup3 sys_dup3 +25 32 fcntl64 sys_fcntl64 compat_sys_fcntl64 +25 64 fcntl sys_fcntl +# fs/inotify_user.c +26 common inotify_init1 sys_inotify_init1 +27 common inotify_add_watch sys_inotify_add_watch +28 common inotify_rm_watch sys_inotify_rm_watch +# fs/ioctl.c +29 common ioctl sys_ioctl compat_sys_ioctl +# fs/ioprio.c +30 common ioprio_set sys_ioprio_set +31 common ioprio_get sys_ioprio_get +# fs/locks.c +32 common flock sys_flock +# fs/namei.c +33 common mknodat sys_mknodat +34 common mkdirat sys_mkdirat +35 common unlinkat sys_unlinkat +36 common symlinkat sys_symlinkat +37 common linkat sys_linkat +38 rename renameat sys_renameat +# fs/namespace.c +39 common umount2 sys_umount +40 common mount sys_mount compat_sys_mount +41 common pivot_root sys_pivot_root +# fs/nfsctl.c +42 common nfsservctl sys_ni_syscall +# fs/open.c +43 32 statfs64 sys_statfs64 compat_sys_statfs64 +43 64 statfs sys_statfs +44 32 fstatfs64 sys_fstatfs64 compat_sys_fstatfs64 +44 64 fstatfs sys_fstatfs +45 32 truncate64 sys_truncate64 compat_sys_truncate64 +45 64 truncate sys_truncate +46 32 ftruncate64 sys_ftruncate64 compat_sys_ftruncate64 +46 64 ftruncate sys_ftruncate +47 common fallocate sys_fallocate compat_sys_fallocate +48 common faccessat sys_faccessat +49 common chdir sys_chdir +50 common fchdir sys_fchdir +51 common chroot sys_chroot +52 common fchmod sys_fchmod +53 common fchmodat sys_fchmodat +54 common fchownat sys_fchownat +55 common fchown sys_fchown +56 common openat sys_openat compat_sys_openat +57 common close sys_close +58 common vhangup sys_vhangup +# fs/pipe.c +59 common pipe2 sys_pipe2 +# fs/quota.c +60 common quotactl sys_quotactl +# fs/readdir.c +61 common getdents64 sys_getdents64 +# fs/read_write.c +62 32 llseek sys_llseek +62 64 lseek sys_lseek +63 common read sys_read +64 common write sys_write +65 common readv sys_readv compat_sys_readv +66 common writev sys_writev compat_sys_writev +67 common pread64 sys_pread64 compat_sys_pread64 +68 common pwrite64 sys_pwrite64 compat_sys_pwrite64 +69 common preadv sys_preadv compat_sys_preadv +70 common pwritev sys_pwritev compat_sys_pwritev +# fs/sendfile.c +71 32 sendfile64 sys_sendfile64 +71 64 sendfile sys_sendfile64 +# fs/select.c +72 common pselect6 sys_pselect6 compat_sys_pselect6 +73 common ppoll sys_ppoll compat_sys_ppoll +# fs/signalfd.c +74 common signalfd4 sys_signalfd4 compat_sys_signalfd4 +# fs/splice.c +75 common vmsplice sys_vmsplice compat_sys_vmsplice +76 common splice sys_splice +77 common tee sys_tee +# fs/stat.c +78 common readlinkat sys_readlinkat +79 stat64 fstatat64 sys_fstatat64 +79 nwstat newfstatat sys_newfstatat +80 stat64 fstat64 sys_fstat64 +80 nwstat fstat sys_newfstat +# fs/sync.c +81 common sync sys_sync +82 common fsync sys_fsync +83 common fdatasync sys_fdatasync +84 common sync_file_range sys_sync_file_range compat_sys_sync_file_range +# fs/timerfd.c +85 common timerfd_create sys_timerfd_create +86 common timerfd_settime sys_timerfd_settime compat_sys_timerfd_settime +87 common timerfd_gettime sys_timerfd_gettime compat_sys_timerfd_gettime +# fs/utimes.c +88 common utimensat sys_utimensat compat_sys_utimensat +# kernel/acct.c +89 common acct sys_acct +# kernel/capability.c +90 common capget sys_capget +91 common capset sys_capset +# kernel/exec_domain.c +92 common personality sys_personality +# kernel/exit.c +93 common exit sys_exit +94 common exit_group sys_exit_group +95 common waitid sys_waitid compat_sys_waitid +# kernel/fork.c +96 common set_tid_address sys_set_tid_address +97 common unshare sys_unshare +# kernel/futex.c +98 common futex sys_futex compat_sys_futex +99 common set_robust_list sys_set_robust_list compat_sys_set_robust_list +100 common get_robust_list sys_get_robust_list compat_sys_get_robust_list +# kernel/hrtimer.c +101 common nanosleep sys_nanosleep compat_sys_nanosleep +# kernel/itimer.c +102 common getitimer sys_getitimer compat_sys_getitimer +103 common setitimer sys_setitimer compat_sys_setitimer +# kernel/kexec.c +104 common kexec_load sys_kexec_load compat_sys_kexec_load +# kernel/module.c +105 common init_module sys_init_module +106 common delete_module sys_delete_module +# kernel/posix-timers.c +107 common timer_create sys_timer_create compat_sys_timer_create +108 common timer_gettime sys_timer_gettime compat_sys_timer_gettime +109 common timer_getoverrun sys_timer_getoverrun +110 common timer_settime sys_timer_settime compat_sys_timer_settime +111 common timer_delete sys_timer_delete +112 common clock_settime sys_clock_settime compat_sys_clock_settime +113 common clock_gettime sys_clock_gettime compat_sys_clock_gettime +114 common clock_getres sys_clock_getres compat_sys_clock_getres +115 common clock_nanosleep sys_clock_nanosleep compat_sys_clock_nanosleep +# kernel/printk.c +116 common syslog sys_syslog +# kernel/ptrace.c +117 common ptrace sys_ptrace +# kernel/sched/core.c +118 common sched_setparam sys_sched_setparam +119 common sched_setscheduler sys_sched_setscheduler +120 common sched_getscheduler sys_sched_getscheduler +121 common sched_getparam sys_sched_getparam +122 common sched_setaffinity sys_sched_setaffinity compat_sys_sched_setaffinity +123 common sched_getaffinity sys_sched_getaffinity compat_sys_sched_getaffinity +124 common sched_yield sys_sched_yield +125 common sched_get_priority_max sys_sched_get_priority_max +126 common sched_get_priority_min sys_sched_get_priority_min +127 common sched_rr_get_interval sys_sched_rr_get_interval compat_sys_sched_rr_get_interval +# kernel/signal.c +128 common restart_syscall sys_restart_syscall +129 common kill sys_kill +130 common tkill sys_tkill +131 common tgkill sys_tgkill +132 common sigaltstack sys_sigaltstack compat_sys_sigaltstack +133 common rt_sigsuspend sys_rt_sigsuspend compat_sys_rt_sigsuspend +134 common rt_sigaction sys_rt_sigaction compat_sys_rt_sigaction +135 common rt_sigprocmask sys_rt_sigprocmask compat_sys_rt_sigprocmask +136 common rt_sigpending sys_rt_sigpending compat_sys_rt_sigpending +137 common rt_sigtimedwait sys_rt_sigtimedwait compat_sys_rt_sigtimedwait +138 common rt_sigqueueinfo sys_rt_sigqueueinfo compat_sys_rt_sigqueueinfo +139 common rt_sigreturn sys_rt_sigreturn compat_sys_rt_sigreturn +# kernel/sys.c +140 common setpriority sys_setpriority +141 common getpriority sys_getpriority +142 common reboot sys_reboot +143 common setregid sys_setregid +144 common setgid sys_setgid +145 common setreuid sys_setreuid +146 common setuid sys_setuid +147 common setresuid sys_setresuid +148 common getresuid sys_getresuid +149 common setresgid sys_setresgid +150 common getresgid sys_getresgid +151 common setfsuid sys_setfsuid +152 common setfsgid sys_setfsgid +153 common times sys_times compat_sys_times +154 common setpgid sys_setpgid +155 common getpgid sys_getpgid +156 common getsid sys_getsid +157 common setsid sys_setsid +158 common getgroups sys_getgroups +159 common setgroups sys_setgroups +160 common uname sys_newuname +161 common sethostname sys_sethostname +162 common setdomainname sys_setdomainname +163 common getrlimit sys_getrlimit compat_sys_getrlimit +164 common setrlimit sys_setrlimit compat_sys_setrlimit +165 common getrusage sys_getrusage compat_sys_getrusage +166 common umask sys_umask +167 common prctl sys_prctl +168 common getcpu sys_getcpu +169 common gettimeofday sys_gettimeofday compat_sys_gettimeofday +# kernel/time.c +170 common settimeofday sys_settimeofday compat_sys_settimeofday +171 common adjtimex sys_adjtimex compat_sys_adjtimex +# kernel/timer.c +172 common getpid sys_getpid +173 common getppid sys_getppid +174 common getuid sys_getuid +175 common geteuid sys_geteuid +176 common getgid sys_getgid +177 common getegid sys_getegid +178 common gettid sys_gettid +179 common sysinfo sys_sysinfo compat_sys_sysinfo +# ipc/mqueue.c +180 common mq_open sys_mq_open compat_sys_mq_open +181 common mq_unlink sys_mq_unlink +182 common mq_timedsend sys_mq_timedsend compat_sys_mq_timedsend +183 common mq_timedreceive sys_mq_timedreceive compat_sys_mq_timedreceive +184 common mq_notify sys_mq_notify compat_sys_mq_notify +185 common mq_getsetattr sys_mq_getsetattr compat_sys_mq_getsetattr +# ipc/msg.c +186 common msgget sys_msgget +187 common msgctl sys_msgctl compat_sys_msgctl +188 common msgrcv sys_msgrcv compat_sys_msgrcv +189 common msgsnd sys_msgsnd compat_sys_msgsnd +# ipc/sem.c +190 common semget sys_semget +191 common semctl sys_semctl compat_sys_semctl +192 common semtimedop sys_semtimedop compat_sys_semtimedop +193 common semop sys_semop +# ipc/shm.c +194 common shmget sys_shmget +195 common shmctl sys_shmctl compat_sys_shmctl +196 common shmat sys_shmat compat_sys_shmat +197 common shmdt sys_shmdt +# net/socket.c +198 common socket sys_socket +199 common socketpair sys_socketpair +200 common bind sys_bind +201 common listen sys_listen +202 common accept sys_accept +203 common connect sys_connect +204 common getsockname sys_getsockname +205 common getpeername sys_getpeername +206 common sendto sys_sendto +207 common recvfrom sys_recvfrom compat_sys_recvfrom +208 common setsockopt sys_setsockopt compat_sys_setsockopt +209 common getsockopt sys_getsockopt compat_sys_getsockopt +210 common shutdown sys_shutdown +211 common sendmsg sys_sendmsg compat_sys_sendmsg +212 common recvmsg sys_recvmsg compat_sys_recvmsg +# mm/filemap.c +213 common readahead sys_readahead compat_sys_readahead +# mm/nommu.c, also with MMU +214 common brk sys_brk +215 common munmap sys_munmap +216 common mremap sys_mremap +# security/keys/keyctl.c +217 common add_key sys_add_key +218 common request_key sys_request_key +219 common keyctl sys_keyctl compat_sys_keyctl +# arch/example/kernel/sys_example.c +220 common clone sys_clone +221 common execve sys_execve compat_sys_execve +222 32 mmap2 sys_mmap2 +222 64 mmap sys_mmap +# mm/fadvise.c +223 32 fadvise64_64 sys_fadvise64_64 compat_sys_fadvise64_64 +223 64 fadvise64 sys_fadvise64_64 +224 mmu swapon sys_swapon +225 mmu swapoff sys_swapoff +226 mmu mprotect sys_mprotect +227 mmu msync sys_msync +228 mmu mlock sys_mlock +229 mmu munlock sys_munlock +230 mmu mlockall sys_mlockall +231 mmu munlockall sys_munlockall +232 mmu mincore sys_mincore +233 mmu madvise sys_madvise +234 mmu remap_file_pages sys_remap_file_pages +235 mmu mbind sys_mbind compat_sys_mbind +236 mmu get_mempolicy sys_get_mempolicy compat_sys_get_mempolicy +237 mmu set_mempolicy sys_set_mempolicy compat_sys_set_mempolicy +238 mmu migrate_pages sys_migrate_pages compat_sys_migrate_pages +239 mmu move_pages sys_move_pages compat_sys_move_pages +240 common rt_tgsigqueueinfo sys_rt_tgsigqueueinfo compat_sys_rt_tgsigqueueinfo +241 common perf_event_open sys_perf_event_open +242 common accept4 sys_accept4 +243 common recvmmsg sys_recvmmsg compat_sys_recvmmsg +244 cachef cacheflush sys_cacheflush compat_sys_cacheflush +244 archsp arch_specific_syscall sys_arch_specific_syscall0 +245 archsp arch_specific_syscall1 sys_arch_specific_syscall1 +246 archsp arch_specific_syscall2 sys_arch_specific_syscall2 +247 archsp arch_specific_syscall3 sys_arch_specific_syscall3 +248 archsp arch_specific_syscall4 sys_arch_specific_syscall4 +260 common wait4 sys_wait4 compat_sys_wait4 +261 common prlimit64 sys_prlimit64 +262 common fanotify_init sys_fanotify_init +263 common fanotify_mark sys_fanotify_mark +264 common name_to_handle_at sys_name_to_handle_at +265 common open_by_handle_at sys_open_by_handle_at compat_sys_open_by_handle_at +266 common clock_adjtime sys_clock_adjtime compat_sys_clock_adjtime +267 common syncfs sys_syncfs +268 common setns sys_setns +269 common sendmmsg sys_sendmmsg compat_sys_sendmmsg +270 common process_vm_readv sys_process_vm_readv compat_sys_process_vm_readv +271 common process_vm_writev sys_process_vm_writev compat_sys_process_vm_writev +272 common kcmp sys_kcmp +273 common finit_module sys_finit_module +274 common sched_setattr sys_sched_setattr +275 common sched_getattr sys_sched_getattr +276 common renameat2 sys_renameat2 +277 common seccomp sys_seccomp +278 common getrandom sys_getrandom +279 common memfd_create sys_memfd_create +280 common bpf sys_bpf +281 common execveat sys_execveat compat_sys_execveat +282 common userfaultfd sys_userfaultfd +283 common membarrier sys_membarrier +284 common mlock2 sys_mlock2 +285 common copy_file_range sys_copy_file_range +286 common preadv2 sys_preadv2 compat_sys_preadv2 +287 common pwritev2 sys_pwritev2 compat_sys_pwritev2 +288 common pkey_mprotect sys_pkey_mprotect +289 common pkey_alloc sys_pkey_alloc +290 common pkey_free sys_pkey_free +291 common statx sys_statx +292 common io_pgetevents sys_io_pgetevents compat_sys_io_pgetevents +293 common rseq sys_rseq -- 1.9.1

7 years, 3 months

1
0
0 0

[PATCH] scripts: unify system call table generation scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. Signed-off-by: Firoz Khan <firoz.khan(a)linaro.org> --- scripts/syscallhdr.sh | 37 +++++++++++++++++++++++++++++++++++++ scripts/syscallnr.sh | 32 ++++++++++++++++++++++++++++++++ scripts/syscalltbl.sh | 37 +++++++++++++++++++++++++++++++++++++ 3 files changed, 106 insertions(+) create mode 100644 scripts/syscallhdr.sh create mode 100644 scripts/syscallnr.sh create mode 100644 scripts/syscalltbl.sh diff --git a/scripts/syscallhdr.sh b/scripts/syscallhdr.sh new file mode 100644 index 0000000..d03fe3d --- /dev/null +++ b/scripts/syscallhdr.sh @@ -0,0 +1,37 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +in="$1" +out="$2" +my_abis=`echo "($3)" | tr ',' '|'` +prefix="$4" +offset="$5" + +fileguard=_UAPI_ASM_`basename "$out" | sed \ + -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \ + -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'` +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( + printf "#ifndef %s\n" "${fileguard}" + printf "#define %s\n" "${fileguard}" + printf "\n" + + nxt=0 + while read nr abi name entry compat ; do + if [ -z "$offset" ]; then + printf "#define __NR_%s%s\t%s\n" \ + "${prefix}" "${name}" "${nr}" + else + printf "#define __NR_%s%s\t(%s + %s)\n" \ + "${prefix}" "${name}" "${offset}" "${nr}" + fi + nxt=$((nr+1)) + done + + printf "\n" + printf "#ifdef __KERNEL__\n" + printf "#define __NR_syscalls\t%s\n" "${nxt}" + printf "#endif\n" + printf "\n" + printf "#endif /* %s */" "${fileguard}" + printf "\n" +) > "$out" diff --git a/scripts/syscallnr.sh b/scripts/syscallnr.sh new file mode 100644 index 0000000..8cf33fa --- /dev/null +++ b/scripts/syscallnr.sh @@ -0,0 +1,32 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +in="$1" +out="$2" +my_abis=`echo "($3)" | tr ',' '|'` +prefix="$4" +offset="$5" + +fileguard=_UAPI_ASM_`basename "$out" | sed \ + -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \ + -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'` +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( + printf "#ifndef %s\n" "${fileguard}" + printf "#define %s\n" "${fileguard}" + printf "\n" + + nxt=0 + while read nr abi name entry compat ; do + nxt=$((nr+1)) + done + + if [ ! -z "$prefix" ]; then + printf "#define __NR_%s_Linux_syscalls\t%s\n" "${prefix}" "${nxt}" + if [ ! -z "$offset" ]; then + printf "#define __NR_%s_Linux\t%s\n" "${prefix}" "${offset}" + fi + fi + printf "\n" + printf "#endif /* %s */" "${fileguard}" + printf "\n" +) > "$out" diff --git a/scripts/syscalltbl.sh b/scripts/syscalltbl.sh new file mode 100644 index 0000000..f60f762 --- /dev/null +++ b/scripts/syscalltbl.sh @@ -0,0 +1,37 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +in="$1" +out="$2" +my_abis=`echo "($3)" | tr ',' '|'` +my_abi="$4" +offset="$5" + +emit() { + t_nxt="$1" + t_nr="$2" + t_entry="$3" + + while [ $t_nxt -lt $t_nr ]; do + printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}" + t_nxt=$((t_nxt+1)) + done + printf "__SYSCALL(%s,%s)\n" "${t_nxt}" "${t_entry}" +} + +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( + nxt=0 + if [ -z "$offset" ]; then + offset=0 + fi + + while read nr abi name entry compat ; do + if [ "$my_abi" = "c32" -o "$my_abi" = "64_o32" ] && + [ ! -z "$compat" ]; then + emit $((nxt+offset)) $((nr+offset)) $compat + else + emit $((nxt+offset)) $((nr+offset)) $entry + fi + nxt=$((nr+1)) + done +) > "$out" -- 1.9.1

7 years, 3 months

2
4
0 0

[PATCH 0/2] m68k: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): m68k: remove nargs from __SYSCALL m68k: generate uapi header and syscall table header files arch/m68k/kernel/syscalls/Makefile | 11 ++++++++-- arch/m68k/kernel/syscalls/syscallhdr.sh | 36 --------------------------------- arch/m68k/kernel/syscalls/syscalltbl.sh | 32 ----------------------------- arch/m68k/kernel/syscalltable.S | 2 +- 4 files changed, 10 insertions(+), 71 deletions(-) delete mode 100644 arch/m68k/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/m68k/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

3
7
0 0

[PATCH 0/2] ia64: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): ia64: remove nargs from __SYSCALL ia64: generate uapi header and system call table files arch/ia64/kernel/entry.S | 2 +- arch/ia64/kernel/syscalls/Makefile | 11 ++++++++-- arch/ia64/kernel/syscalls/syscallhdr.sh | 36 --------------------------------- arch/ia64/kernel/syscalls/syscalltbl.sh | 32 ----------------------------- 4 files changed, 10 insertions(+), 71 deletions(-) delete mode 100644 arch/ia64/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/ia64/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

1
2
0 0

[PATCH 0/2] microblaze: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): microblaze: remove nargs from __SYSCALL microblaze: generate uapi header and system call table files arch/microblaze/kernel/syscall_table.S | 2 +- arch/microblaze/kernel/syscalls/Makefile | 11 ++++++-- arch/microblaze/kernel/syscalls/syscallhdr.sh | 36 --------------------------- arch/microblaze/kernel/syscalls/syscalltbl.sh | 32 ------------------------ 4 files changed, 10 insertions(+), 71 deletions(-) delete mode 100644 arch/microblaze/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/microblaze/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

1
2
0 0

[PATCH 0/2] alpha: Unify the system call scripts

by Firoz Khan

System call table generation support is provided for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa architectures. The implementat- ions are almost similar across all the above archte- ctures. In order to reduce the source code across all the above architectures, create common ".sh" files and keep it in the common directory, script/. This will be a generic scripts which can use for all the above architectures. This patch depends on; https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@l… Firoz Khan (2): alpha: remove nargs from __SYSCALL alpha: generate uapi header and syscall table header files arch/alpha/kernel/syscalls/Makefile | 11 ++++++++-- arch/alpha/kernel/syscalls/syscallhdr.sh | 36 -------------------------------- arch/alpha/kernel/syscalls/syscalltbl.sh | 32 ---------------------------- arch/alpha/kernel/systbls.S | 2 +- 4 files changed, 10 insertions(+), 71 deletions(-) delete mode 100644 arch/alpha/kernel/syscalls/syscallhdr.sh delete mode 100644 arch/alpha/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

1
2
0 0

[PATCH v3] sock: Make sock->sk_stamp thread-safe

by Deepa Dinamani

Al Viro mentioned (Message-ID <20170626041334.GZ10672(a)ZenIV.linux.org.uk>) that there is probably a race condition lurking in accesses of sk_stamp on 32-bit machines. sock->sk_stamp is of type ktime_t which is always an s64. On a 32 bit architecture, we might run into situations of unsafe access as the access to the field becomes non atomic. Use seqlocks for synchronization. This allows us to avoid using spinlocks for readers as readers do not need mutual exclusion. Another approach to solve this is to require sk_lock for all modifications of the timestamps. The current approach allows for timestamps to have their own lock: sk_stamp_lock. This allows for the patch to not compete with already existing critical sections, and side effects are limited to the paths in the patch. The addition of the new field maintains the data locality optimizations from commit 9115e8cd2a0c ("net: reorganize struct sock for better data locality") Note that all the instances of the sk_stamp accesses are either through the ioctl or the syscall recvmsg. Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- Changes since v2: * added ifdef as per eric's request Changes since v1: * fixed sunrpc sk_stamp update include/net/sock.h | 38 +++++++++++++++++++++++++++++++++++--- net/compat.c | 15 +++++++++------ net/core/sock.c | 15 ++++++++++----- net/sunrpc/svcsock.c | 2 +- 4 files changed, 55 insertions(+), 15 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index f665d74ae509..e144c071c93f 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -298,6 +298,7 @@ struct sock_common { * @sk_filter: socket filtering instructions * @sk_timer: sock cleanup timer * @sk_stamp: time stamp of last packet received + * @sk_stamp_seq: lock for accessing sk_stamp on 32 bit architectures only * @sk_tsflags: SO_TIMESTAMPING socket options * @sk_tskey: counter to disambiguate concurrent tstamp requests * @sk_zckey: counter to order MSG_ZEROCOPY notifications @@ -474,6 +475,9 @@ struct sock { const struct cred *sk_peer_cred; long sk_rcvtimeo; ktime_t sk_stamp; +#if BITS_PER_LONG==32 + seqlock_t sk_stamp_seq; +#endif u16 sk_tsflags; u8 sk_shutdown; u32 sk_tskey; @@ -2287,6 +2291,34 @@ static inline void sk_drops_add(struct sock *sk, const struct sk_buff *skb) atomic_add(segs, &sk->sk_drops); } +static inline ktime_t sock_read_timestamp(struct sock *sk) +{ +#if BITS_PER_LONG==32 + unsigned int seq; + ktime_t kt; + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + kt = sk->sk_stamp; + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + + return kt; +#else + return sk->sk_stamp; +#endif +} + +static inline void sock_write_timestamp(struct sock *sk, ktime_t kt) +{ +#if BITS_PER_LONG==32 + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); +#else + sk->sk_stamp = kt; +#endif +} + void __sock_recv_timestamp(struct msghdr *msg, struct sock *sk, struct sk_buff *skb); void __sock_recv_wifi_status(struct msghdr *msg, struct sock *sk, @@ -2311,7 +2343,7 @@ sock_recv_timestamp(struct msghdr *msg, struct sock *sk, struct sk_buff *skb) (sk->sk_tsflags & SOF_TIMESTAMPING_RAW_HARDWARE))) __sock_recv_timestamp(msg, sk, skb); else - sk->sk_stamp = kt; + sock_write_timestamp(sk, kt); if (sock_flag(sk, SOCK_WIFI_STATUS) && skb->wifi_acked_valid) __sock_recv_wifi_status(msg, sk, skb); @@ -2332,9 +2364,9 @@ static inline void sock_recv_ts_and_drops(struct msghdr *msg, struct sock *sk, if (sk->sk_flags & FLAGS_TS_OR_DROPS || sk->sk_tsflags & TSFLAGS_ANY) __sock_recv_ts_and_drops(msg, sk, skb); else if (unlikely(sock_flag(sk, SOCK_TIMESTAMP))) - sk->sk_stamp = skb->tstamp; + sock_write_timestamp(sk, skb->tstamp); else if (unlikely(sk->sk_stamp == SK_DEFAULT_STAMP)) - sk->sk_stamp = 0; + sock_write_timestamp(sk, 0); } void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags); diff --git a/net/compat.c b/net/compat.c index 47a614b370cd..d1f3a8a0b3ef 100644 --- a/net/compat.c +++ b/net/compat.c @@ -467,12 +467,14 @@ int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) ctv = (struct compat_timeval __user *) userstamp; err = -ENOENT; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - tv = ktime_to_timeval(sk->sk_stamp); + tv = ktime_to_timeval(sock_read_timestamp(sk)); + if (tv.tv_sec == -1) return err; if (tv.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - tv = ktime_to_timeval(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + sock_write_timestamp(sk, kt); + tv = ktime_to_timeval(kt); } err = 0; if (put_user(tv.tv_sec, &ctv->tv_sec) || @@ -494,12 +496,13 @@ int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *usersta ctv = (struct compat_timespec __user *) userstamp; err = -ENOENT; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - ts = ktime_to_timespec(sk->sk_stamp); + ts = ktime_to_timespec(sock_read_timestamp(sk)); if (ts.tv_sec == -1) return err; if (ts.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - ts = ktime_to_timespec(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + sock_write_timestamp(sk, kt); + ts = ktime_to_timespec(kt); } err = 0; if (put_user(ts.tv_sec, &ctv->tv_sec) || diff --git a/net/core/sock.c b/net/core/sock.c index 6d7e189e3cd9..8236b28611c5 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2747,6 +2747,9 @@ void sock_init_data(struct socket *sock, struct sock *sk) sk->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT; sk->sk_stamp = SK_DEFAULT_STAMP; +#if BITS_PER_LONG==32 + seqlock_init(&sk->sk_stamp_seq); +#endif atomic_set(&sk->sk_zckey, 0); #ifdef CONFIG_NET_RX_BUSY_POLL @@ -2846,12 +2849,13 @@ int sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) struct timeval tv; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - tv = ktime_to_timeval(sk->sk_stamp); + tv = ktime_to_timeval(sock_read_timestamp(sk)); if (tv.tv_sec == -1) return -ENOENT; if (tv.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - tv = ktime_to_timeval(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + sock_write_timestamp(sk, kt); + tv = ktime_to_timeval(kt); } return copy_to_user(userstamp, &tv, sizeof(tv)) ? -EFAULT : 0; } @@ -2862,11 +2866,12 @@ int sock_get_timestampns(struct sock *sk, struct timespec __user *userstamp) struct timespec ts; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - ts = ktime_to_timespec(sk->sk_stamp); + ts = ktime_to_timespec(sock_read_timestamp(sk)); if (ts.tv_sec == -1) return -ENOENT; if (ts.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); + ktime_t kt = ktime_get_real(); + sock_write_timestamp(sk, kt); ts = ktime_to_timespec(sk->sk_stamp); } return copy_to_user(userstamp, &ts, sizeof(ts)) ? -EFAULT : 0; diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 986f3ed7d1a2..b7e67310ec37 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -549,7 +549,7 @@ static int svc_udp_recvfrom(struct svc_rqst *rqstp) /* Don't enable netstamp, sunrpc doesn't need that much accuracy */ } - svsk->sk_sk->sk_stamp = skb->tstamp; + sock_write_timestamp(svsk->sk_sk, skb->tstamp); set_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags); /* there may be more data... */ len = skb->len; -- 2.17.1

7 years, 3 months

2
1
0 0

[GIT PULL] y2038: more syscalls and cleanups

by Arnd Bergmann

Hi Linus and Thomas, I realized that the merge window is now imminent, but I had not sent a pull request to Thomas for the current y2038 stuff. These patches have been around for a while though, and were in linux-next through my tree. I got one bug report on Monday and incorporated a simple fix, which changed the commit date for the second half of the series, in case you are wondering. Thomas, is it ok for you to just provide an Ack for this branch and have Linus merge it directly? Arnd The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: https://git.kernel.org:/pub/scm/linux/kernel/git/arnd/playground.git tags/y2038-for-4.21 for you to fetch changes up to e4b92b108c6cd6b311e4b6e85d6a87a34599a6e3: timekeeping: remove obsolete time accessors (2018-12-18 16:13:05 +0100) ---------------------------------------------------------------- y2038: more syscalls and cleanups This concludes the main part of the system call rework for 64-bit time_t, which has spread over most of year 2018, the last six system calls being - ppoll - pselect6 - io_pgetevents - recvmmsg - futex - rt_sigtimedwait As before, nothing changes for 64-bit architectures, while 32-bit architectures gain another entry point that differs only in the layout of the timespec structure. Hopefully in the next release we can wire up all 22 of those system calls on all 32-bit architectures, which gives us a baseline version for glibc to start using them. This does not include the clock_adjtime, getrusage/waitid, and getitimer/setitimer system calls. I still plan to have new versions of those as well, but they are not required for correct operation of the C library since they can be emulated using the old 32-bit time_t based system calls. Aside from the system calls, there are also a few cleanups here, removing old kernel internal interfaces that have become unused after all references got removed. The arch/sh cleanups are part of this, there were posted several times over the past year without a reaction from the maintainers, while the corresponding changes made it into all other architectures. ---------------------------------------------------------------- Arnd Bergmann (13): y2038: futex: Move compat implementation into futex.c y2038: futex: Add support for __kernel_timespec y2038: socket: Add compat_sys_recvmmsg_time64 y2038: signal: Add sys_rt_sigtimedwait_time32 y2038: signal: Add compat_sys_rt_sigtimedwait_time64 sh: dreamcast: rtc: push down rtc class ops into driver sh: sh03: rtc: push down rtc class ops into driver sh: remove unused rtc_sh_get/set_time infrastructure sh: remove board_time_init() callback timekeeping: remove unused {read,update}_persistent_clock timekeeping: remove timespec_add/timespec_del vfs: replace current_kernel_time64 with ktime equivalent timekeeping: remove obsolete time accessors Deepa Dinamani (5): signal: Add set_user_sigmask() signal: Add restore_user_sigmask() ppoll: use __kernel_timespec pselect6: use __kernel_timespec io_pgetevents: use __kernel_timespec Documentation/sh/new-machine.txt | 8 -- arch/sh/boards/mach-dreamcast/Makefile | 4 +- arch/sh/boards/mach-dreamcast/rtc.c | 45 +++++++--- arch/sh/boards/mach-dreamcast/setup.c | 1 - arch/sh/boards/mach-sh03/Makefile | 3 +- arch/sh/boards/mach-sh03/rtc.c | 51 ++++++----- arch/sh/boards/mach-sh03/setup.c | 9 -- arch/sh/boards/of-generic.c | 8 -- arch/sh/configs/dreamcast_defconfig | 2 + arch/sh/configs/sh03_defconfig | 2 + arch/sh/include/asm/rtc.h | 3 - arch/sh/include/mach-dreamcast/mach/sysasic.h | 1 - arch/sh/kernel/time.c | 74 +--------------- fs/aio.c | 134 ++++++++++++++++++++--------- fs/eventpoll.c | 52 ++---------- fs/inode.c | 4 +- fs/select.c | 360 +++++++++++++++++++++++++++++++++++++++++++++--------------------------------- include/linux/compat.h | 26 ++++++ include/linux/futex.h | 8 -- include/linux/signal.h | 4 + include/linux/socket.h | 9 +- include/linux/syscalls.h | 29 +++++-- include/linux/time32.h | 25 ------ include/linux/timekeeping.h | 14 --- include/linux/timekeeping32.h | 15 ---- kernel/Makefile | 3 - kernel/futex.c | 207 +++++++++++++++++++++++++++++++++++++++++++-- kernel/futex_compat.c | 202 -------------------------------------------- kernel/signal.c | 143 +++++++++++++++++++++++++++++++ kernel/sys_ni.c | 2 + kernel/time/ntp.c | 10 +-- kernel/time/time.c | 36 -------- kernel/time/timekeeping.c | 12 +-- net/compat.c | 34 +++----- net/socket.c | 62 ++++++++++---- 35 files changed, 847 insertions(+), 755 deletions(-) delete mode 100644 kernel/futex_compat.c

7 years, 3 months

2
1
0 0

[GIT PULL] asm-generic: syscall table script for arch/sh

by Arnd Bergmann

The following changes since commit 2e6e902d185027f8e3cb8b7305238f7e35d6a436: Linux 4.20-rc4 (2018-11-25 14:19:31 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git tags/asm-generic-4.21 for you to fetch changes up to 2b3c5a99d5f314960e00950c1782eac9361de30f: sh: generate uapi header and syscall table header files (2018-12-19 17:54:40 +0100) ---------------------------------------------------------------- asm-generic: syscall table script for arch/sh I worked with Firoz Khan to change all architectures to have their system call tables (syscall.S and asm/unistd.h) generated by a script from a more readable input file the same way that we already had on x86, s390 and arm. I offered to take those conversions through the asm-generic tree that did not get picked up by the architecture maintainers, and fortunately all but one have now been accepted into arch maintainer trees, so this branch only contains the conversion for arch/sh/, with permission from Rich. The conversion does not include the old 64-bit sh5 architecture, which has never shipped and not even compiled in a long time. The table in include/uapi/asm/unistd.h is also not included here, as Firoz is still working on that one. It will have to wait for the next following merge window, hopefully together with the addition of the 64-bit time_t system calls for the y2038 work that led to the system call table rework. Acked-by: Rich Felker <dalias(a)libc.org> Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> ---------------------------------------------------------------- Firoz Khan (3): sh: add __NR_syscalls along with NR_syscalls sh: add system call table generation support sh: generate uapi header and syscall table header files arch/sh/Makefile | 3 + arch/sh/include/asm/Kbuild | 1 + arch/sh/include/asm/unistd.h | 2 + arch/sh/include/uapi/asm/Kbuild | 1 + arch/sh/include/uapi/asm/unistd_32.h | 4 +- arch/sh/include/uapi/asm/unistd_64.h | 4 +- arch/sh/kernel/syscalls/Makefile | 38 +++++++++ arch/sh/kernel/syscalls/syscall.tbl | 392 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/sh/kernel/syscalls/syscallhdr.sh | 36 ++++++++ arch/sh/kernel/syscalls/syscalltbl.sh | 32 +++++++ arch/sh/kernel/syscalls_32.S | 387 +----------------------------------------------------------------------------------- 11 files changed, 514 insertions(+), 386 deletions(-) create mode 100644 arch/sh/kernel/syscalls/Makefile create mode 100644 arch/sh/kernel/syscalls/syscall.tbl create mode 100644 arch/sh/kernel/syscalls/syscallhdr.sh create mode 100644 arch/sh/kernel/syscalls/syscalltbl.sh

7 years, 3 months

3
2
0 0

[PATCH v5 0/7] mips: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, parisc, powerpc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v4: - _MIPS_SIM_ABIN64 (suppose to be _MIPS_SIM_NABI64) macro rename back to _MIPS_SIM_ABI64 to avoid toolchain issue. Changes since v3: - rearranged the patches for '64' to 'n64' conver- sion. - moved the unistd_nr_*.h files to asm/unistd.h - modified the *.sh files. Changes since v2: - fixed __NR_syscalls assign issue. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (7): mips: add __NR_syscalls along with __NR_Linux_syscalls mips: remove unused macros mips: rename macros and files from '64' to 'n64' mips: add +1 to __NR_syscalls in uapi header mips: remove syscall table entries mips: add system call table generation support mips: generate uapi header and system call table files arch/mips/Makefile | 3 + arch/mips/include/asm/Kbuild | 4 + arch/mips/include/asm/unistd.h | 11 +- arch/mips/include/uapi/asm/Kbuild | 6 + arch/mips/include/uapi/asm/unistd.h | 1074 +---------------------------- arch/mips/kernel/Makefile | 2 +- arch/mips/kernel/ftrace.c | 8 +- arch/mips/kernel/scall32-o32.S | 391 +---------- arch/mips/kernel/scall64-64.S | 444 ------------ arch/mips/kernel/scall64-n32.S | 341 +-------- arch/mips/kernel/scall64-n64.S | 117 ++++ arch/mips/kernel/scall64-o32.S | 379 +--------- arch/mips/kernel/syscalls/Makefile | 96 +++ arch/mips/kernel/syscalls/syscall_n32.tbl | 343 +++++++++ arch/mips/kernel/syscalls/syscall_n64.tbl | 339 +++++++++ arch/mips/kernel/syscalls/syscall_o32.tbl | 382 ++++++++++ arch/mips/kernel/syscalls/syscallhdr.sh | 37 + arch/mips/kernel/syscalls/syscallnr.sh | 28 + arch/mips/kernel/syscalls/syscalltbl.sh | 36 + 19 files changed, 1427 insertions(+), 2614 deletions(-) delete mode 100644 arch/mips/kernel/scall64-64.S create mode 100644 arch/mips/kernel/scall64-n64.S create mode 100644 arch/mips/kernel/syscalls/Makefile create mode 100644 arch/mips/kernel/syscalls/syscall_n32.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_n64.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_o32.tbl create mode 100644 arch/mips/kernel/syscalls/syscallhdr.sh create mode 100644 arch/mips/kernel/syscalls/syscallnr.sh create mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

2
10
0 0

[PATCH v6 0/5] powerpc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. - spu entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v5: - rebased with 4.20-rc7. Changes since v4: - DOTSYM macro removed for ppc32, which was causing the compilation error. Changes since v3: - split compat syscall table out from native table. - modified the script to add new line in the generated file. Changes since v2: - modified/optimized the syscall.tbl to avoid duplicate for the spu entries. - updated the syscalltbl.sh to meet the above point. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (5): powerpc: add __NR_syscalls along with NR_syscalls powerpc: move macro definition from asm/systbl.h powerpc: add system call table generation support powerpc: split compat syscall table out from native table powerpc: generate uapi header and system call table files arch/powerpc/Makefile | 3 + arch/powerpc/include/asm/Kbuild | 4 + arch/powerpc/include/asm/syscall.h | 3 +- arch/powerpc/include/asm/systbl.h | 396 -------------------------- arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/include/uapi/asm/Kbuild | 2 + arch/powerpc/include/uapi/asm/unistd.h | 389 +------------------------ arch/powerpc/kernel/Makefile | 10 - arch/powerpc/kernel/entry_64.S | 7 +- arch/powerpc/kernel/syscalls/Makefile | 63 ++++ arch/powerpc/kernel/syscalls/syscall.tbl | 427 ++++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscallhdr.sh | 37 +++ arch/powerpc/kernel/syscalls/syscalltbl.sh | 36 +++ arch/powerpc/kernel/systbl.S | 40 ++- arch/powerpc/kernel/systbl_chk.c | 60 ---- arch/powerpc/kernel/vdso.c | 7 +- arch/powerpc/platforms/cell/spu_callbacks.c | 17 +- 17 files changed, 606 insertions(+), 898 deletions(-) delete mode 100644 arch/powerpc/include/asm/systbl.h create mode 100644 arch/powerpc/kernel/syscalls/Makefile create mode 100644 arch/powerpc/kernel/syscalls/syscall.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/powerpc/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/powerpc/kernel/systbl_chk.c -- 1.9.1

7 years, 3 months

2
7
0 0

[PATCH] sock: Make sock->sk_tstamp thread-safe

by Deepa Dinamani

Al Viro mentioned that there is probably a race condition lurking in accesses of sk_tstamp on 32-bit machines. sock->sk_tstamp is of type ktime_t which is always an s64. On a 32 bit architecture, we might run into situations of unsafe access as the access to the field becomes non atomic. Use seqlocks for synchronization. This allows us to avoid using spinlocks for readers as readers do not need mutual exclusion. Another approach to solve this is to require sk_lock for all modifications of the timestamps. The current approach allows for timestamps to have their own lock: sk_tstamp_lock. This allows for the patch to not compete with already existing critical sections, and side effects are limited to the paths in the patch. The addition of the new field maintains the data locality optimizations from commit 9115e8cd2a0c ("net: reorganize struct sock for better data locality") Note that all the instances of the sk_tstamp accesses are either through the ioctl or the syscall recvmsg. Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- include/net/sock.h | 16 +++++++++++++--- net/compat.c | 30 +++++++++++++++++++++++++----- net/core/sock.c | 34 +++++++++++++++++++++++++++++----- 3 files changed, 67 insertions(+), 13 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index fe58aec00d09..2cb641606533 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -298,6 +298,7 @@ struct sock_common { * @sk_filter: socket filtering instructions * @sk_timer: sock cleanup timer * @sk_stamp: time stamp of last packet received + * @sk_stamp_seq: lock for accessing sk_stamp * @sk_tsflags: SO_TIMESTAMPING socket options * @sk_tskey: counter to disambiguate concurrent tstamp requests * @sk_zckey: counter to order MSG_ZEROCOPY notifications @@ -474,6 +475,7 @@ struct sock { const struct cred *sk_peer_cred; long sk_rcvtimeo; ktime_t sk_stamp; + seqlock_t sk_stamp_seq; u16 sk_tsflags; u8 sk_shutdown; u32 sk_tskey; @@ -2311,8 +2313,11 @@ sock_recv_timestamp(struct msghdr *msg, struct sock *sk, struct sk_buff *skb) (hwtstamps->hwtstamp && (sk->sk_tsflags & SOF_TIMESTAMPING_RAW_HARDWARE))) __sock_recv_timestamp(msg, sk, skb); - else + else { + write_seqlock(&sk->sk_stamp_seq); sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + } if (sock_flag(sk, SOCK_WIFI_STATUS) && skb->wifi_acked_valid) __sock_recv_wifi_status(msg, sk, skb); @@ -2332,10 +2337,15 @@ static inline void sock_recv_ts_and_drops(struct msghdr *msg, struct sock *sk, if (sk->sk_flags & FLAGS_TS_OR_DROPS || sk->sk_tsflags & TSFLAGS_ANY) __sock_recv_ts_and_drops(msg, sk, skb); - else if (unlikely(sock_flag(sk, SOCK_TIMESTAMP))) + else if (unlikely(sock_flag(sk, SOCK_TIMESTAMP))) { + write_seqlock(&sk->sk_stamp_seq); sk->sk_stamp = skb->tstamp; - else if (unlikely(sk->sk_stamp == SK_DEFAULT_STAMP)) + write_sequnlock(&sk->sk_stamp_seq); + } else if (unlikely(sk->sk_stamp == SK_DEFAULT_STAMP)) { + write_seqlock(&sk->sk_stamp_seq); sk->sk_stamp = 0; + write_sequnlock(&sk->sk_stamp_seq); + } } void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags); diff --git a/net/compat.c b/net/compat.c index 6c9fceeefac0..3022f4941687 100644 --- a/net/compat.c +++ b/net/compat.c @@ -459,6 +459,7 @@ int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) { struct compat_timeval __user *ctv; int err; + unsigned int seq; struct timeval tv; if (COMPAT_USE_64BIT_TIME) @@ -467,11 +468,20 @@ int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) ctv = (struct compat_timeval __user *) userstamp; err = -ENOENT; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - tv = ktime_to_timeval(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + tv = ktime_to_timeval(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (tv.tv_sec == -1) return err; if (tv.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); tv = ktime_to_timeval(sk->sk_stamp); } err = 0; @@ -486,6 +496,7 @@ int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *usersta { struct compat_timespec __user *ctv; int err; + unsigned int seq; struct timespec ts; if (COMPAT_USE_64BIT_TIME) @@ -494,12 +505,21 @@ int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *usersta ctv = (struct compat_timespec __user *) userstamp; err = -ENOENT; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - ts = ktime_to_timespec(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + ts = ktime_to_timespec(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (ts.tv_sec == -1) return err; if (ts.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - ts = ktime_to_timespec(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + ts = ktime_to_timespec(kt); } err = 0; if (put_user(ts.tv_sec, &ctv->tv_sec) || diff --git a/net/core/sock.c b/net/core/sock.c index f0e0e12b2e0d..a9a99af24a95 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2783,6 +2783,7 @@ void sock_init_data(struct socket *sock, struct sock *sk) sk->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT; sk->sk_stamp = SK_DEFAULT_STAMP; + seqlock_init(&sk->sk_stamp_seq); atomic_set(&sk->sk_zckey, 0); #ifdef CONFIG_NET_RX_BUSY_POLL @@ -2880,15 +2881,27 @@ EXPORT_SYMBOL(lock_sock_fast); int sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) { struct timeval tv; + unsigned int seq; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - tv = ktime_to_timeval(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + tv = ktime_to_timeval(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (tv.tv_sec == -1) return -ENOENT; if (tv.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - tv = ktime_to_timeval(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + + tv = ktime_to_timeval(kt); } + return copy_to_user(userstamp, &tv, sizeof(tv)) ? -EFAULT : 0; } EXPORT_SYMBOL(sock_get_timestamp); @@ -2896,13 +2909,24 @@ EXPORT_SYMBOL(sock_get_timestamp); int sock_get_timestampns(struct sock *sk, struct timespec __user *userstamp) { struct timespec ts; + unsigned int seq; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - ts = ktime_to_timespec(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + ts = ktime_to_timespec(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (ts.tv_sec == -1) return -ENOENT; if (ts.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + ts = ktime_to_timespec(sk->sk_stamp); } return copy_to_user(userstamp, &ts, sizeof(ts)) ? -EFAULT : 0; -- 2.17.1

7 years, 3 months

4
5
0 0

[PATCH v2 1/1] sock: Make sock->sk_stamp thread-safe

by Deepa Dinamani

Al Viro mentioned (Message-ID <20170626041334.GZ10672(a)ZenIV.linux.org.uk>) that there is probably a race condition lurking in accesses of sk_stamp on 32-bit machines. sock->sk_stamp is of type ktime_t which is always an s64. On a 32 bit architecture, we might run into situations of unsafe access as the access to the field becomes non atomic. Use seqlocks for synchronization. This allows us to avoid using spinlocks for readers as readers do not need mutual exclusion. Another approach to solve this is to require sk_lock for all modifications of the timestamps. The current approach allows for timestamps to have their own lock: sk_stamp_lock. This allows for the patch to not compete with already existing critical sections, and side effects are limited to the paths in the patch. The addition of the new field maintains the data locality optimizations from commit 9115e8cd2a0c ("net: reorganize struct sock for better data locality") Note that all the instances of the sk_stamp accesses are either through the ioctl or the syscall recvmsg. Signed-off-by: Deepa Dinamani <deepa.kernel(a)gmail.com> --- Changes since v1: * fixed sunrpc sk_stamp update include/net/sock.h | 16 +++++++++++++--- net/compat.c | 32 ++++++++++++++++++++++++++------ net/core/sock.c | 34 +++++++++++++++++++++++++++++----- net/sunrpc/svcsock.c | 2 ++ 4 files changed, 70 insertions(+), 14 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index fe58aec00d09..2cb641606533 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -298,6 +298,7 @@ struct sock_common { * @sk_filter: socket filtering instructions * @sk_timer: sock cleanup timer * @sk_stamp: time stamp of last packet received + * @sk_stamp_seq: lock for accessing sk_stamp * @sk_tsflags: SO_TIMESTAMPING socket options * @sk_tskey: counter to disambiguate concurrent tstamp requests * @sk_zckey: counter to order MSG_ZEROCOPY notifications @@ -474,6 +475,7 @@ struct sock { const struct cred *sk_peer_cred; long sk_rcvtimeo; ktime_t sk_stamp; + seqlock_t sk_stamp_seq; u16 sk_tsflags; u8 sk_shutdown; u32 sk_tskey; @@ -2311,8 +2313,11 @@ sock_recv_timestamp(struct msghdr *msg, struct sock *sk, struct sk_buff *skb) (hwtstamps->hwtstamp && (sk->sk_tsflags & SOF_TIMESTAMPING_RAW_HARDWARE))) __sock_recv_timestamp(msg, sk, skb); - else + else { + write_seqlock(&sk->sk_stamp_seq); sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + } if (sock_flag(sk, SOCK_WIFI_STATUS) && skb->wifi_acked_valid) __sock_recv_wifi_status(msg, sk, skb); @@ -2332,10 +2337,15 @@ static inline void sock_recv_ts_and_drops(struct msghdr *msg, struct sock *sk, if (sk->sk_flags & FLAGS_TS_OR_DROPS || sk->sk_tsflags & TSFLAGS_ANY) __sock_recv_ts_and_drops(msg, sk, skb); - else if (unlikely(sock_flag(sk, SOCK_TIMESTAMP))) + else if (unlikely(sock_flag(sk, SOCK_TIMESTAMP))) { + write_seqlock(&sk->sk_stamp_seq); sk->sk_stamp = skb->tstamp; - else if (unlikely(sk->sk_stamp == SK_DEFAULT_STAMP)) + write_sequnlock(&sk->sk_stamp_seq); + } else if (unlikely(sk->sk_stamp == SK_DEFAULT_STAMP)) { + write_seqlock(&sk->sk_stamp_seq); sk->sk_stamp = 0; + write_sequnlock(&sk->sk_stamp_seq); + } } void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags); diff --git a/net/compat.c b/net/compat.c index 6c9fceeefac0..17da30bd34a9 100644 --- a/net/compat.c +++ b/net/compat.c @@ -459,6 +459,7 @@ int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) { struct compat_timeval __user *ctv; int err; + unsigned int seq; struct timeval tv; if (COMPAT_USE_64BIT_TIME) @@ -467,12 +468,21 @@ int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) ctv = (struct compat_timeval __user *) userstamp; err = -ENOENT; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - tv = ktime_to_timeval(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + tv = ktime_to_timeval(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (tv.tv_sec == -1) return err; if (tv.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - tv = ktime_to_timeval(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + tv = ktime_to_timeval(kt); } err = 0; if (put_user(tv.tv_sec, &ctv->tv_sec) || @@ -486,6 +496,7 @@ int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *usersta { struct compat_timespec __user *ctv; int err; + unsigned int seq; struct timespec ts; if (COMPAT_USE_64BIT_TIME) @@ -494,12 +505,21 @@ int compat_sock_get_timestampns(struct sock *sk, struct timespec __user *usersta ctv = (struct compat_timespec __user *) userstamp; err = -ENOENT; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - ts = ktime_to_timespec(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + ts = ktime_to_timespec(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (ts.tv_sec == -1) return err; if (ts.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - ts = ktime_to_timespec(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + ts = ktime_to_timespec(kt); } err = 0; if (put_user(ts.tv_sec, &ctv->tv_sec) || diff --git a/net/core/sock.c b/net/core/sock.c index f0e0e12b2e0d..a9a99af24a95 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2783,6 +2783,7 @@ void sock_init_data(struct socket *sock, struct sock *sk) sk->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT; sk->sk_stamp = SK_DEFAULT_STAMP; + seqlock_init(&sk->sk_stamp_seq); atomic_set(&sk->sk_zckey, 0); #ifdef CONFIG_NET_RX_BUSY_POLL @@ -2880,15 +2881,27 @@ EXPORT_SYMBOL(lock_sock_fast); int sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) { struct timeval tv; + unsigned int seq; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - tv = ktime_to_timeval(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + tv = ktime_to_timeval(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (tv.tv_sec == -1) return -ENOENT; if (tv.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); - tv = ktime_to_timeval(sk->sk_stamp); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + + tv = ktime_to_timeval(kt); } + return copy_to_user(userstamp, &tv, sizeof(tv)) ? -EFAULT : 0; } EXPORT_SYMBOL(sock_get_timestamp); @@ -2896,13 +2909,24 @@ EXPORT_SYMBOL(sock_get_timestamp); int sock_get_timestampns(struct sock *sk, struct timespec __user *userstamp) { struct timespec ts; + unsigned int seq; sock_enable_timestamp(sk, SOCK_TIMESTAMP); - ts = ktime_to_timespec(sk->sk_stamp); + + do { + seq = read_seqbegin(&sk->sk_stamp_seq); + ts = ktime_to_timespec(sk->sk_stamp); + } while (read_seqretry(&sk->sk_stamp_seq, seq)); + if (ts.tv_sec == -1) return -ENOENT; if (ts.tv_sec == 0) { - sk->sk_stamp = ktime_get_real(); + ktime_t kt = ktime_get_real(); + + write_seqlock(&sk->sk_stamp_seq); + sk->sk_stamp = kt; + write_sequnlock(&sk->sk_stamp_seq); + ts = ktime_to_timespec(sk->sk_stamp); } return copy_to_user(userstamp, &ts, sizeof(ts)) ? -EFAULT : 0; diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 986f3ed7d1a2..cd12177720aa 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -549,7 +549,9 @@ static int svc_udp_recvfrom(struct svc_rqst *rqstp) /* Don't enable netstamp, sunrpc doesn't need that much accuracy */ } + write_seqlock(&svsk->sk_sk->sk_stamp_seq); svsk->sk_sk->sk_stamp = skb->tstamp; + write_sequnlock(&svsk->sk_sk->sk_stamp_seq); set_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags); /* there may be more data... */ len = skb->len; -- 2.17.1

7 years, 3 months

1
0
0 0

[PATCH v3 0/5] alpha: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for ia64, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v2: - changed from generic-y to generated-y in Kbuild. - made changes in syscall.tbl for removing entry - alpha_ni_syscall. changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall.tbl. - enclosed __NR_sycalls macro with __KERNEL__. - added missing new line. Firoz Khan (5): alpha: move __IGNORE* entries to non uapi header alpha: remove CONFIG_OSF4_COMPAT flag from syscall table alpha: add __NR_syscalls along with NR_SYSCALLS alpha: add system call table generation support alpha: generate uapi header and syscall table header files arch/alpha/Makefile | 3 + arch/alpha/include/asm/Kbuild | 2 +- arch/alpha/include/asm/unistd.h | 23 +- arch/alpha/include/uapi/asm/Kbuild | 1 + arch/alpha/include/uapi/asm/unistd.h | 484 +-------------------------- arch/alpha/kernel/osf_sys.c | 9 +- arch/alpha/kernel/syscalls/Makefile | 38 +++ arch/alpha/kernel/syscalls/syscall.tbl | 453 ++++++++++++++++++++++++++ arch/alpha/kernel/syscalls/syscallhdr.sh | 36 ++ arch/alpha/kernel/syscalls/syscalltbl.sh | 32 ++ arch/alpha/kernel/systbls.S | 542 +------------------------------ 11 files changed, 596 insertions(+), 1027 deletions(-) create mode 100644 arch/alpha/kernel/syscalls/Makefile create mode 100644 arch/alpha/kernel/syscalls/syscall.tbl create mode 100644 arch/alpha/kernel/syscalls/syscallhdr.sh create mode 100644 arch/alpha/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

3
9
0 0

[PATCH v2 0/8] net: y2038-safe socket timestamps

by Deepa Dinamani

The series introduces new socket timestamps that are y2038 safe. The time data types used for the existing socket timestamp options: SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING are not y2038 safe. The series introduces SO_TIMESTAMP_NEW, SO_TIMESTAMPNS_NEW and SO_TIMESTAMPING_NEW to replace these. These new timestamps can be used on all architectures. The alternative considered was to extend the sys_setsockopt() by using the flags. We did not receive any strong opinions about either of the approaches. Hence, this was chosen, as glibc folks preferred this. The series does not deal with updating the internal kernel socket calls like rxrpc to make them y2038 safe. This will be dealt with separately. Note that the timestamps behavior already does not match the man page specific behavior: SIOCGSTAMP This ioctl should only be used if the socket option SO_TIMESTAMP is not set on the socket. Otherwise, it returns the timestamp of the last packet that was received while SO_TIMESTAMP was not set, or it fails if no such packet has been received, (i.e., ioctl(2) returns -1 with errno set to ENOENT). The recommendation is to update the man page to remove the above statement. The overview of the series is as below: 1. Delete asm specific socket.h when possible. 2. Support SO/SCM_TIMESTAMP* options only in userspace. 3. Rename current SO/SCM_TIMESTAMP* to SO/SCM_TIMESTAMP*_OLD. 3. Alter socket options so that SOCK_RCVTSTAMPNS does not rely on SOCK_RCVTSTAMP. 4. Introduce y2038 safe types for socket timestamp. 5. Introduce new y2038 safe socket options SO/SCM_TIMESTAMP*_NEW. Changes since v1: * Dropped the change to disentangle sock flags * Renamed sock_timeval to __kernel_sock_timeval * Updated a few comments * Added documentation changes Deepa Dinamani (8): arch: Use asm-generic/socket.h when possible sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD arch: sparc: Override struct __kernel_old_timeval socket: Use old_timeval types for socket timestamps socket: Add struct __kernel_sock_timeval socket: Add SO_TIMESTAMP[NS]_NEW socket: Add SO_TIMESTAMPING_NEW socket: Update timestamping Documentation Documentation/networking/timestamping.txt | 43 ++++++- arch/alpha/include/uapi/asm/socket.h | 35 ++++-- arch/ia64/include/uapi/asm/Kbuild | 1 + arch/ia64/include/uapi/asm/socket.h | 120 ------------------- arch/mips/include/uapi/asm/socket.h | 34 ++++-- arch/parisc/include/uapi/asm/socket.h | 34 ++++-- arch/s390/include/uapi/asm/Kbuild | 1 + arch/s390/include/uapi/asm/socket.h | 117 ------------------ arch/sparc/include/uapi/asm/posix_types.h | 10 ++ arch/sparc/include/uapi/asm/socket.h | 36 ++++-- arch/x86/include/uapi/asm/Kbuild | 1 + arch/x86/include/uapi/asm/socket.h | 1 - arch/xtensa/include/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/socket.h | 122 ------------------- drivers/isdn/mISDN/socket.c | 2 +- include/linux/skbuff.h | 24 +++- include/linux/socket.h | 7 ++ include/net/sock.h | 1 + include/uapi/asm-generic/socket.h | 35 ++++-- include/uapi/linux/errqueue.h | 4 + include/uapi/linux/time.h | 7 ++ net/bluetooth/hci_sock.c | 4 +- net/compat.c | 12 +- net/core/scm.c | 27 +++++ net/core/sock.c | 138 ++++++++++++++-------- net/ipv4/tcp.c | 82 ++++++++----- net/rds/af_rds.c | 10 +- net/rds/recv.c | 18 ++- net/rxrpc/local_object.c | 2 +- net/smc/af_smc.c | 3 +- net/socket.c | 64 +++++++--- 32 files changed, 478 insertions(+), 519 deletions(-) delete mode 100644 arch/ia64/include/uapi/asm/socket.h delete mode 100644 arch/s390/include/uapi/asm/socket.h delete mode 100644 arch/x86/include/uapi/asm/socket.h delete mode 100644 arch/xtensa/include/uapi/asm/socket.h base-commit: b124b524bc97868cc2b5656e6ffa21a9b752b7e0 -- 2.17.1 Cc: chris(a)zankel.net Cc: deller(a)gmx.de Cc: dhowells(a)redhat.com Cc: fenghua.yu(a)intel.com Cc: isdn(a)linux-pingi.de Cc: jejb(a)parisc-linux.org Cc: ralf(a)linux-mips.org Cc: rth(a)twiddle.net Cc: schwidefsky(a)de.ibm.com Cc: tglx(a)linutronix.de Cc: ubraun(a)linux.ibm.com Cc: linux-afs(a)lists.infradead.org Cc: linux-alpha(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org Cc: linux-ia64(a)vger.kernel.org Cc: linux-mips(a)linux-mips.org Cc: linux-parisc(a)vger.kernel.org Cc: linux-rdma(a)vger.kernel.org Cc: linux-s390(a)vger.kernel.org Cc: linux-xtensa(a)linux-xtensa.org Cc: netdev(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org

7 years, 3 months

4
22
0 0

[PATCH v5 0/5] powerpc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. - spu entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v4: - DOTSYM macro removed for ppc32, which was causing the compilation error. Changes since v3: - split compat syscall table out from native table. - modified the script to add new line in the generated file. Changes since v2: - modified/optimized the syscall.tbl to avoid duplicate for the spu entries. - updated the syscalltbl.sh to meet the above point. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (5): powerpc: add __NR_syscalls along with NR_syscalls powerpc: move macro definition from asm/systbl.h powerpc: add system call table generation support powerpc: split compat syscall table out from native table powerpc: generate uapi header and system call table files arch/powerpc/Makefile | 3 + arch/powerpc/include/asm/Kbuild | 4 + arch/powerpc/include/asm/syscall.h | 3 +- arch/powerpc/include/asm/systbl.h | 396 -------------------------- arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/include/uapi/asm/Kbuild | 2 + arch/powerpc/include/uapi/asm/unistd.h | 389 +------------------------ arch/powerpc/kernel/Makefile | 10 - arch/powerpc/kernel/entry_64.S | 7 +- arch/powerpc/kernel/syscalls/Makefile | 63 ++++ arch/powerpc/kernel/syscalls/syscall.tbl | 427 ++++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscallhdr.sh | 37 +++ arch/powerpc/kernel/syscalls/syscalltbl.sh | 36 +++ arch/powerpc/kernel/systbl.S | 40 ++- arch/powerpc/kernel/systbl_chk.c | 60 ---- arch/powerpc/kernel/vdso.c | 7 +- arch/powerpc/platforms/cell/spu_callbacks.c | 17 +- 17 files changed, 606 insertions(+), 898 deletions(-) delete mode 100644 arch/powerpc/include/asm/systbl.h create mode 100644 arch/powerpc/kernel/syscalls/Makefile create mode 100644 arch/powerpc/kernel/syscalls/syscall.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/powerpc/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/powerpc/kernel/systbl_chk.c -- 1.9.1

7 years, 3 months

3
10
0 0

[PATCH v4 0/7] mips: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, parisc, powerpc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v3: - rearranged the patches for '64' to 'n64' conver- sion. - moved the unistd_nr_*.h files to asm/unistd.h - modified the *.sh files. Changes since v2: - fixed __NR_syscalls assign issue. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (7): mips: add __NR_syscalls along with __NR_Linux_syscalls mips: remove unused macros mips: rename macros and files from '64' to 'n64' mips: add +1 to __NR_syscalls in uapi header mips: remove syscall table entries mips: add system call table generation support mips: generate uapi header and system call table files arch/mips/Makefile | 3 + arch/mips/include/asm/Kbuild | 4 + arch/mips/include/asm/asm.h | 6 +- arch/mips/include/asm/fpregdef.h | 4 +- arch/mips/include/asm/fw/arc/hinv.h | 2 +- arch/mips/include/asm/regdef.h | 4 +- arch/mips/include/asm/sigcontext.h | 4 +- arch/mips/include/asm/unistd.h | 11 +- arch/mips/include/uapi/asm/Kbuild | 6 + arch/mips/include/uapi/asm/fcntl.h | 2 +- arch/mips/include/uapi/asm/reg.h | 4 +- arch/mips/include/uapi/asm/sgidefs.h | 2 +- arch/mips/include/uapi/asm/sigcontext.h | 4 +- arch/mips/include/uapi/asm/stat.h | 4 +- arch/mips/include/uapi/asm/statfs.h | 4 +- arch/mips/include/uapi/asm/unistd.h | 1069 +---------------------------- arch/mips/kernel/Makefile | 2 +- arch/mips/kernel/ftrace.c | 8 +- arch/mips/kernel/scall32-o32.S | 391 +---------- arch/mips/kernel/scall64-64.S | 444 ------------ arch/mips/kernel/scall64-n32.S | 341 +-------- arch/mips/kernel/scall64-n64.S | 117 ++++ arch/mips/kernel/scall64-o32.S | 379 +--------- arch/mips/kernel/syscalls/Makefile | 96 +++ arch/mips/kernel/syscalls/syscall_n32.tbl | 343 +++++++++ arch/mips/kernel/syscalls/syscall_n64.tbl | 339 +++++++++ arch/mips/kernel/syscalls/syscall_o32.tbl | 382 +++++++++++ arch/mips/kernel/syscalls/syscallhdr.sh | 37 + arch/mips/kernel/syscalls/syscallnr.sh | 28 + arch/mips/kernel/syscalls/syscalltbl.sh | 36 + arch/mips/kvm/entry.c | 4 +- arch/mips/vdso/vdso.h | 2 +- arch/mips/vdso/vdso.lds.S | 2 +- 33 files changed, 1450 insertions(+), 2634 deletions(-) delete mode 100644 arch/mips/kernel/scall64-64.S create mode 100644 arch/mips/kernel/scall64-n64.S create mode 100644 arch/mips/kernel/syscalls/Makefile create mode 100644 arch/mips/kernel/syscalls/syscall_n32.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_n64.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_o32.tbl create mode 100644 arch/mips/kernel/syscalls/syscallhdr.sh create mode 100644 arch/mips/kernel/syscalls/syscallnr.sh create mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

3
21
0 0

[PATCH v4 0/5] powerpc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. - spu entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v3: - split compat syscall table out from native table. - modified the script to add new line in the generated file. Changes since v2: - modified/optimized the syscall.tbl to avoid duplicate for the spu entries. - updated the syscalltbl.sh to meet the above point. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (5): powerpc: add __NR_syscalls along with NR_syscalls powerpc: move macro definition from asm/systbl.h powerpc: add system call table generation support powerpc: split compat syscall table out from native table powerpc: generate uapi header and system call table files arch/powerpc/Makefile | 3 + arch/powerpc/include/asm/Kbuild | 4 + arch/powerpc/include/asm/syscall.h | 3 +- arch/powerpc/include/asm/systbl.h | 396 -------------------------- arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/include/uapi/asm/Kbuild | 2 + arch/powerpc/include/uapi/asm/unistd.h | 389 +------------------------ arch/powerpc/kernel/Makefile | 10 - arch/powerpc/kernel/entry_64.S | 7 +- arch/powerpc/kernel/syscalls/Makefile | 63 ++++ arch/powerpc/kernel/syscalls/syscall.tbl | 427 ++++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscallhdr.sh | 37 +++ arch/powerpc/kernel/syscalls/syscalltbl.sh | 36 +++ arch/powerpc/kernel/systbl.S | 40 ++- arch/powerpc/kernel/systbl_chk.c | 60 ---- arch/powerpc/kernel/vdso.c | 7 +- arch/powerpc/platforms/cell/spu_callbacks.c | 17 +- 17 files changed, 606 insertions(+), 898 deletions(-) delete mode 100644 arch/powerpc/include/asm/systbl.h create mode 100644 arch/powerpc/kernel/syscalls/Makefile create mode 100644 arch/powerpc/kernel/syscalls/syscall.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/powerpc/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/powerpc/kernel/systbl_chk.c -- 1.9.1

7 years, 3 months

3
9
0 0

[PATCH v3 0/3] sh: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. Please note, this support is only available for 32-bit kernel, not 64-bit kernel. As I came across the 64-bit kernel is not active for long time. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall- .tbl. Changes since v2: - changed from generic-y to generated-y in Kbuild. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall.tbl. Firoz Khan (3): sh: add __NR_syscalls along with NR_syscalls sh: add system call table generation support sh: generate uapi header and syscall table header files arch/sh/Makefile | 3 + arch/sh/include/asm/Kbuild | 1 + arch/sh/include/asm/unistd.h | 2 + arch/sh/include/uapi/asm/Kbuild | 1 + arch/sh/include/uapi/asm/unistd_32.h | 4 +- arch/sh/include/uapi/asm/unistd_64.h | 4 +- arch/sh/kernel/syscalls/Makefile | 38 ++++ arch/sh/kernel/syscalls/syscall.tbl | 392 ++++++++++++++++++++++++++++++++++ arch/sh/kernel/syscalls/syscallhdr.sh | 36 ++++ arch/sh/kernel/syscalls/syscalltbl.sh | 32 +++ arch/sh/kernel/syscalls_32.S | 387 +-------------------------------- 11 files changed, 514 insertions(+), 386 deletions(-) create mode 100644 arch/sh/kernel/syscalls/Makefile create mode 100644 arch/sh/kernel/syscalls/syscall.tbl create mode 100644 arch/sh/kernel/syscalls/syscallhdr.sh create mode 100644 arch/sh/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

5
10
0 0

Re: [Y2038] [arnd-playground:y2038 6/13] htmldocs: arch/sh/boards/mach-dreamcast/rtc.c:36: warning: Function parameter or member 'dev' not described in 'aica_rtc_gettimeofday'

by Arnd Bergmann

On Fri, Dec 7, 2018 at 10:50 PM kbuild test robot <lkp(a)intel.com> wrote: > >> arch/sh/boards/mach-dreamcast/rtc.c:36: warning: Function parameter or member 'dev' not described in 'aica_rtc_gettimeofday' > >> arch/sh/boards/mach-dreamcast/rtc.c:36: warning: Function parameter or member 'tm' not described in 'aica_rtc_gettimeofday' > arch/sh/boards/mach-dreamcast/rtc.c:36: warning: Excess function parameter 'ts' description in 'aica_rtc_gettimeofday' > >> arch/sh/boards/mach-dreamcast/rtc.c:63: warning: Function parameter or member 'dev' not described in 'aica_rtc_settimeofday' > >> arch/sh/boards/mach-dreamcast/rtc.c:63: warning: Function parameter or member 'tm' not described in 'aica_rtc_settimeofday' Nice catch. I'm fixing up those comments now, but wonder if they should just be removed since it is not providing an API but instead implementing one. Arnd

7 years, 3 months

1
0
0 0

[PATCH 0/5] y2038: further system call conversion

by Arnd Bergmann

This is another set of system call changes that were intended to get merged much earlier. I've rebased the patches on top of the latest kernel and Deepa's poll/select/io_pgetevents series now, and applied it to the same y2038 branch for inclusion in 4.21. This is just a continuation of the earlier system call changes, so I expect no surprises here, unless I made a mistake in the rebase. After this series, the only remaining system calls that need to be modified are: - setsockopt/getsockopt, they do not need a new entry in the system call table, only new numbers assigned for their socket options. Deepa is finalizing her series to passing 64-bit timestamps in cmsg correctly for SO_TIMESTAMP{,NS,ING}. Further, we need a new SO_RCVTIMEO/SO_SNDTIMEO implementation here, which has not been implemented yet. - waitid/getrusage, this needs a rewrite now from earlier versions based on recent feedback. The plan now is to incorporate nanosecond timestamps in a new revision of the 'rusage' structure. Possibly also include BSD wait6() semantics of passing back the child resource usage in waitid(), and/or a method to pass a signal mask as in io_pgetevents(). waitid/getrusage() are not required for correct behavior with 64-bit time_t and can be safely emulated on top of the existing syscalls by the C library beyond 2038. This needs more discussion. - clock_adjtime, this is also optional and can be implemented by the C library if necessary. The plan is to do the same as x32 and use the 64-bit structure natively on both 32-bit and 64-bit architectures. The timex structure contains a 'timeval' at the moment, but also supports nanoseconds passed in it. - getitimer/setitimer, these again can be trivially emulated by the C library. Arnd Arnd Bergmann (5): y2038: futex: Move compat implementation into futex.c y2038: futex: Add support for __kernel_timespec y2038: socket: Add compat_sys_recvmmsg_time64 y2038: signal: Add sys_rt_sigtimedwait_time32 y2038: signal: Add compat_sys_rt_sigtimedwait_time64 include/linux/compat.h | 8 +- include/linux/futex.h | 8 -- include/linux/socket.h | 9 +- include/linux/syscalls.h | 9 +- kernel/Makefile | 3 - kernel/futex.c | 207 +++++++++++++++++++++++++++++++++++++-- kernel/futex_compat.c | 202 -------------------------------------- kernel/signal.c | 65 ++++++++++++ kernel/sys_ni.c | 2 + net/compat.c | 34 +++---- net/socket.c | 62 +++++++++--- 11 files changed, 345 insertions(+), 264 deletions(-) delete mode 100644 kernel/futex_compat.c -- 2.18.0

7 years, 3 months

1
5
0 0

[PATCH 0/8] timekeeping: cleanups

by Arnd Bergmann

Here are some older cleanups that for one reason or another never made it into the mainline kernel so far: - the arch/sh series was posted a couple of times by both Baolin and me, with no reply from the sh maintainers - the vfs patch initially got some opposition when the new interfaces were not documented right, but that is done now. - The remaining three patches simply remove functions that have been obsoleted a while ago and have lost their last callers now. I'm adding these into my y2038 tree now, so they make it into linux-next, planning to send a pull request to Thomas for the tip tree afterwards. Arnd Arnd Bergmann (8): sh: dreamcast: rtc: push down rtc class ops into driver sh: sh03: rtc: push down rtc class ops into driver sh: remove unused rtc_sh_get/set_time infrastructure sh: remove board_time_init() callback timekeeping: remove unused {read,update}_persistent_clock timekeeping: remove timespec_add/timespec_del vfs: replace current_kernel_time64 with ktime equivalent timekeeping: remove obsolete time accessors Documentation/sh/new-machine.txt | 8 -- arch/sh/boards/mach-dreamcast/Makefile | 4 +- arch/sh/boards/mach-dreamcast/rtc.c | 39 +++++++--- arch/sh/boards/mach-dreamcast/setup.c | 1 - arch/sh/boards/mach-sh03/Makefile | 3 +- arch/sh/boards/mach-sh03/rtc.c | 51 ++++++++----- arch/sh/boards/mach-sh03/setup.c | 9 --- arch/sh/boards/of-generic.c | 8 -- arch/sh/configs/dreamcast_defconfig | 2 + arch/sh/configs/sh03_defconfig | 2 + arch/sh/include/asm/rtc.h | 3 - arch/sh/include/mach-dreamcast/mach/sysasic.h | 1 - arch/sh/kernel/time.c | 74 +------------------ fs/inode.c | 4 +- include/linux/time32.h | 25 ------- include/linux/timekeeping.h | 14 ---- include/linux/timekeeping32.h | 15 ---- kernel/time/ntp.c | 10 +-- kernel/time/time.c | 36 --------- kernel/time/timekeeping.c | 12 +-- 20 files changed, 73 insertions(+), 248 deletions(-) -- 2.18.0

7 years, 3 months

3
13
0 0

[PATCH v3 0/6] mips: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, parisc, powerpc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v2: - fixed __NR_syscalls assign issue. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (6): mips: add __NR_syscalls along with __NR_Linux_syscalls mips: remove unused macros mips: add +1 to __NR_syscalls in uapi header mips: remove syscall table entries mips: add system call table generation support mips: generate uapi header and system call table files arch/mips/Makefile | 3 + arch/mips/include/asm/Kbuild | 4 + arch/mips/include/asm/unistd.h | 8 - arch/mips/include/uapi/asm/Kbuild | 6 + arch/mips/include/uapi/asm/unistd.h | 1065 +---------------------------- arch/mips/kernel/Makefile | 2 +- arch/mips/kernel/ftrace.c | 8 +- arch/mips/kernel/scall32-o32.S | 391 +---------- arch/mips/kernel/scall64-64.S | 444 ------------ arch/mips/kernel/scall64-n32.S | 341 +-------- arch/mips/kernel/scall64-n64.S | 117 ++++ arch/mips/kernel/scall64-o32.S | 379 +--------- arch/mips/kernel/syscalls/Makefile | 96 +++ arch/mips/kernel/syscalls/syscall_n32.tbl | 343 ++++++++++ arch/mips/kernel/syscalls/syscall_n64.tbl | 339 +++++++++ arch/mips/kernel/syscalls/syscall_o32.tbl | 382 +++++++++++ arch/mips/kernel/syscalls/syscallhdr.sh | 36 + arch/mips/kernel/syscalls/syscallnr.sh | 30 + arch/mips/kernel/syscalls/syscalltbl.sh | 36 + 19 files changed, 1430 insertions(+), 2600 deletions(-) delete mode 100644 arch/mips/kernel/scall64-64.S create mode 100644 arch/mips/kernel/scall64-n64.S create mode 100644 arch/mips/kernel/syscalls/Makefile create mode 100644 arch/mips/kernel/syscalls/syscall_n32.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_n64.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_o32.tbl create mode 100644 arch/mips/kernel/syscalls/syscallhdr.sh create mode 100644 arch/mips/kernel/syscalls/syscallnr.sh create mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 3 months

6
22
0 0

[PATCH v4 0/5] y2038: Make ppoll, io_pgetevents and pselect y2038 safe

by Deepa Dinamani

The series transitions the ppoll, io_getevents, and pselect syscalls to be y2038 safe. This is part of the work proceeding for syscalls for y2038. It is based on the series [1] from Arnd Bergmann. The overview of the series is as below: 1. Refactor sigmask handling logic for the above syscalls. 2. Provide y2038 safe versions of the syscalls for all ABIs. [1] https://lkml.org/lkml/2018/8/27/651 Changes since v3: * fixed pselect copy+paste error Changes since v2: * remove 64BIT_TIME conditional for ppoll, pselect, io_getpevents as per review comments Changes since v1: * fixed bug pointed out by arnd Deepa Dinamani (5): signal: Add set_user_sigmask() signal: Add restore_user_sigmask() ppoll: use __kernel_timespec pselect6: use __kernel_timespec io_pgetevents: use __kernel_timespec fs/aio.c | 134 ++++++++++----- fs/eventpoll.c | 52 +----- fs/select.c | 360 ++++++++++++++++++++++----------------- include/linux/compat.h | 20 +++ include/linux/signal.h | 4 + include/linux/syscalls.h | 20 ++- kernel/signal.c | 78 +++++++++ 7 files changed, 426 insertions(+), 242 deletions(-) -- 2.17.1

7 years, 4 months

2
6
0 0

[PATCH v3 0/4] powerpc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. - spu entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v2: - modified/optimized the syscall.tbl to avoid duplicate for the spu entries. - updated the syscalltbl.sh to meet the above point. changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (4): powerpc: add __NR_syscalls along with NR_syscalls powerpc: move macro definition from asm/systbl.h powerpc: add system call table generation support powerpc: generate uapi header and system call table files arch/powerpc/Makefile | 3 + arch/powerpc/include/asm/Kbuild | 4 + arch/powerpc/include/asm/systbl.h | 396 -------------------------- arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/include/uapi/asm/Kbuild | 2 + arch/powerpc/include/uapi/asm/unistd.h | 389 +------------------------ arch/powerpc/kernel/Makefile | 10 - arch/powerpc/kernel/syscalls/Makefile | 63 ++++ arch/powerpc/kernel/syscalls/syscall.tbl | 427 ++++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscallhdr.sh | 36 +++ arch/powerpc/kernel/syscalls/syscalltbl.sh | 36 +++ arch/powerpc/kernel/systbl.S | 37 +-- arch/powerpc/kernel/systbl_chk.c | 60 ---- arch/powerpc/platforms/cell/spu_callbacks.c | 17 +- 14 files changed, 591 insertions(+), 892 deletions(-) delete mode 100644 arch/powerpc/include/asm/systbl.h create mode 100644 arch/powerpc/kernel/syscalls/Makefile create mode 100644 arch/powerpc/kernel/syscalls/syscall.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/powerpc/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/powerpc/kernel/systbl_chk.c -- 1.9.1

7 years, 4 months

3
9
0 0

[PATCH v5 0/3] m68k: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, microblaze, mips, parisc, powerpc, sh, sparc and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v4: - changed from generic-y to generated-y in Kbuild. - remove the patch "0001-m68k-rename-system-call- table-file-name.patch". changes since v3: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. changes since v2: - removed __IGNORE entries which was added in v2 to suppress the warning. - added missing new line. changes since v1: - enclosed __NR_sycalls macro with __KERNEL__. Firoz Khan (3): m68k: add __NR_syscalls along with NR_syscalls m68k: add system call table generation support m68k: generate uapi header and syscall table header files arch/m68k/Makefile | 3 + arch/m68k/include/asm/Kbuild | 1 + arch/m68k/include/asm/unistd.h | 3 +- arch/m68k/include/uapi/asm/Kbuild | 1 + arch/m68k/include/uapi/asm/unistd.h | 385 +------------------------------ arch/m68k/kernel/syscalls/Makefile | 38 ++++ arch/m68k/kernel/syscalls/syscall.tbl | 389 ++++++++++++++++++++++++++++++++ arch/m68k/kernel/syscalls/syscallhdr.sh | 36 +++ arch/m68k/kernel/syscalls/syscalltbl.sh | 32 +++ arch/m68k/kernel/syscalltable.S | 387 +------------------------------ 10 files changed, 507 insertions(+), 768 deletions(-) create mode 100644 arch/m68k/kernel/syscalls/Makefile create mode 100644 arch/m68k/kernel/syscalls/syscall.tbl create mode 100644 arch/m68k/kernel/syscalls/syscallhdr.sh create mode 100644 arch/m68k/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

2
9
0 0

[PATCH 0/8] net: y2038-safe socket timestamps

by Deepa Dinamani

The series introduces new socket timestamps that are y2038 safe. The time data types used for the existing socket timestamp options: SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING are not y2038 safe. The series introduces SO_TIMESTAMP_NEW, SO_TIMESTAMPNS_NEW and SO_TIMESTAMPING_NEW to replace these. These new timestamps can be used on all architectures. The alternative considered was to extend the sys_setsockopt() by using the flags. We did not receive any strong opinions about either of the approaches. Hence, this was chosen, as glibc folks preferred this. The series does not deal with updating the internal kernel socket calls like rxrpc to make them y2038 safe. This will be dealt with separately. Note that the timestamps behavior already does not match the man page specific behavior: SIOCGSTAMP This ioctl should only be used if the socket option SO_TIMESTAMP is not set on the socket. Otherwise, it returns the timestamp of the last packet that was received while SO_TIMESTAMP was not set, or it fails if no such packet has been received, (i.e., ioctl(2) returns -1 with errno set to ENOENT). The recommendation is to update the man page to remove the above statement. The overview of the series is as below: 1. Delete asm specific socket.h when possible. 2. Support SO/SCM_TIMESTAMP* options only in userspace. 3. Rename current SO/SCM_TIMESTAMP* to SO/SCM_TIMESTAMP*_OLD. 3. Alter socket options so that SOCK_RCVTSTAMPNS does not rely on SOCK_RCVTSTAMP. 4. Introduce y2038 safe types for socket timestamp. 5. Introduce new y2038 safe socket options SO/SCM_TIMESTAMP*_NEW. Deepa Dinamani (8): arch: Use asm-generic/socket.h when possible sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP arch: sparc: Override struct __kernel_old_timeval socket: Use old_timeval types for socket timestamps socket: Add struct sock_timeval socket: Add SO_TIMESTAMP[NS]_NEW socket: Add SO_TIMESTAMPING_NEW arch/alpha/include/uapi/asm/socket.h | 35 ++++-- arch/ia64/include/uapi/asm/Kbuild | 1 + arch/ia64/include/uapi/asm/socket.h | 120 ------------------ arch/mips/include/uapi/asm/socket.h | 34 ++++-- arch/parisc/include/uapi/asm/socket.h | 34 ++++-- arch/s390/include/uapi/asm/Kbuild | 1 + arch/s390/include/uapi/asm/socket.h | 117 ------------------ arch/sparc/include/uapi/asm/posix_types.h | 10 ++ arch/sparc/include/uapi/asm/socket.h | 36 ++++-- arch/x86/include/uapi/asm/Kbuild | 1 + arch/x86/include/uapi/asm/socket.h | 1 - arch/xtensa/include/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/socket.h | 122 ------------------- drivers/isdn/mISDN/socket.c | 2 +- include/linux/skbuff.h | 24 +++- include/linux/socket.h | 7 ++ include/net/sock.h | 5 +- include/uapi/asm-generic/socket.h | 35 ++++-- include/uapi/linux/errqueue.h | 4 + include/uapi/linux/time.h | 7 ++ net/bluetooth/hci_sock.c | 4 +- net/compat.c | 12 +- net/core/scm.c | 27 ++++ net/core/sock.c | 142 ++++++++++++++-------- net/ipv4/tcp.c | 82 ++++++++----- net/rds/af_rds.c | 10 +- net/rds/recv.c | 18 ++- net/rxrpc/local_object.c | 2 +- net/smc/af_smc.c | 3 +- net/socket.c | 68 +++++++---- net/unix/af_unix.c | 4 +- 32 files changed, 449 insertions(+), 521 deletions(-) delete mode 100644 arch/ia64/include/uapi/asm/socket.h delete mode 100644 arch/s390/include/uapi/asm/socket.h delete mode 100644 arch/x86/include/uapi/asm/socket.h delete mode 100644 arch/xtensa/include/uapi/asm/socket.h base-commit: b124b524bc97868cc2b5656e6ffa21a9b752b7e0 -- 2.17.1 Cc: chris(a)zankel.net Cc: fenghua.yu(a)intel.com Cc: tglx(a)linutronix.de Cc: schwidefsky(a)de.ibm.com Cc: linux-ia64(a)vger.kernel.org Cc: linux-xtensa(a)linux-xtensa.org Cc: linux-s390(a)vger.kernel.org Cc: deller(a)gmx.de Cc: dhowells(a)redhat.com Cc: jejb(a)parisc-linux.org Cc: ralf(a)linux-mips.org Cc: rth(a)twiddle.net Cc: linux-afs(a)lists.infradead.org Cc: linux-alpha(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org Cc: linux-mips(a)linux-mips.org Cc: linux-parisc(a)vger.kernel.org Cc: linux-rdma(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org Cc: isdn(a)linux-pingi.de Cc: jejb(a)parisc-linux.org Cc: ralf(a)linux-mips.org Cc: rth(a)twiddle.net Cc: linux-alpha(a)vger.kernel.org Cc: linux-mips(a)linux-mips.org Cc: linux-parisc(a)vger.kernel.org Cc: linux-rdma(a)vger.kernel.org Cc: netdev(a)vger.kernel.org Cc: sparclinux(a)vger.kernel.org Cc: chris(a)zankel.net Cc: fenghua.yu(a)intel.com Cc: rth(a)twiddle.net Cc: tglx(a)linutronix.de Cc: ubraun(a)linux.ibm.com Cc: linux-alpha(a)vger.kernel.org Cc: linux-arch(a)vger.kernel.org Cc: linux-ia64(a)vger.kernel.org Cc: linux-mips(a)linux-mips.org Cc: linux-s390(a)vger.kernel.org Cc: linux-xtensa(a)linux-xtensa.org Cc: sparclinux(a)vger.kernel.org

7 years, 4 months

4
34
0 0

[PATCH 0/3] System call table generation support

by Firoz Khan

The purpose of this patch series is: 1. We can easily add/modify/delete system call by changing entry in syscall.tbl file. No need to manually edit many files. 2. It is easy to unify the system call implementation across all the architectures. The system call tables are in different format in all architecture and it will be difficult to manually add or modify the system calls in the respective files manually. To make it easy by keeping a script and which'll generate the header file and syscall table file so this change will unify them across all architectures. syscall.tbl contains the list of available system calls along with system call number and corresponding entry point. Add a new system call in this architecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. ARM, s390 and x86 architecuture does exist the similar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, m68k, microblaze, ia64, mips, parisc, sh, sparc, and xtensa. But I started sending the patch for one architecuture for review. Below mentioned git repository contains more details. Git repo:- https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work for solving the Y2038 issue. We need to add/change two dozen of system calls to solve Y2038 issue. So this patch series will help to easily modify from existing system call to Y2038 compatible system calls. I started working system call table generation on 4.17-rc1. I used marcin's script - https://github.com/hrw/syscalls-table to generate the syscall.tbl file. And this will be the input to the system call table generation script. But there are couple system call got add in the latest rc release. If run Marcin's script on latest release, It will generate a new syscall.tbl. But I still use the old file - syscall.tbl and once all review got over I'll update syscall.tbl alone w.r.to the tip of the kernel. The impact of this thing, few of the system call won't work. Firoz Khan (3): powerpc: Replace NR_syscalls macro from asm/unistd.h powerpc: Add system call table generation support powerpc: uapi header and system call table file generation arch/powerpc/Makefile | 3 + arch/powerpc/include/asm/Kbuild | 3 + arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/include/uapi/asm/Kbuild | 2 + arch/powerpc/include/uapi/asm/unistd.h | 391 +--------------------------- arch/powerpc/kernel/Makefile | 3 +- arch/powerpc/kernel/syscall_table_32.S | 9 + arch/powerpc/kernel/syscall_table_64.S | 17 ++ arch/powerpc/kernel/syscalls/Makefile | 51 ++++ arch/powerpc/kernel/syscalls/syscall_32.tbl | 378 +++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscall_64.tbl | 372 ++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscallhdr.sh | 37 +++ arch/powerpc/kernel/syscalls/syscalltbl.sh | 38 +++ arch/powerpc/kernel/systbl.S | 50 ---- 14 files changed, 916 insertions(+), 441 deletions(-) create mode 100644 arch/powerpc/kernel/syscall_table_32.S create mode 100644 arch/powerpc/kernel/syscall_table_64.S create mode 100644 arch/powerpc/kernel/syscalls/Makefile create mode 100644 arch/powerpc/kernel/syscalls/syscall_32.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscall_64.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/powerpc/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/powerpc/kernel/systbl.S -- 1.9.1

7 years, 4 months

4
13
0 0

[PATCH v8 0/6] parisc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, powerpc, sh, sparc and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v7: - removed __NR_Linux from uapi header file. changes since v6: - changed from generic-y to generated-y in Kbuild. changes since v5: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. changes since v4: - optimized/updated the syscall table generation scripts. - removed __IGNORE entries which was added in v2 to suppress the warning. changes since v3: - optimized/updated the syscall table generation scripts. - added missing new line. changes since v2: - updated the syscall.tbl file by including missed entries. changes since v1: - enclosed __NR_sycalls macro with __KERNEL__. Firoz Khan (6): parisc: move __IGNORE* entries to non uapi header parisc: add __NR_syscalls along with __NR_Linux_syscalls parisc: remove __NR_Linux from uapi header file. parisc: add system call table generation support parisc: generate uapi header and system call table files parisc: syscalls: ignore nfsservctl for other architectures arch/parisc/Makefile | 3 + arch/parisc/include/asm/Kbuild | 3 + arch/parisc/include/asm/unistd.h | 8 + arch/parisc/include/uapi/asm/Kbuild | 2 + arch/parisc/include/uapi/asm/unistd.h | 379 +----------------------- arch/parisc/kernel/syscall.S | 11 +- arch/parisc/kernel/syscall_table.S | 459 ------------------------------ arch/parisc/kernel/syscalls/Makefile | 55 ++++ arch/parisc/kernel/syscalls/syscall.tbl | 369 ++++++++++++++++++++++++ arch/parisc/kernel/syscalls/syscallhdr.sh | 36 +++ arch/parisc/kernel/syscalls/syscalltbl.sh | 36 +++ scripts/checksyscalls.sh | 1 + 12 files changed, 527 insertions(+), 835 deletions(-) delete mode 100644 arch/parisc/kernel/syscall_table.S create mode 100644 arch/parisc/kernel/syscalls/Makefile create mode 100644 arch/parisc/kernel/syscalls/syscall.tbl create mode 100644 arch/parisc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/parisc/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

1
6
0 0

[PATCH v2 0/5] mips: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, parisc, powerpc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (5): mips: add __NR_syscalls along with __NR_Linux_syscalls mips: add +1 to __NR_syscalls in uapi header mips: remove syscall table entries mips: add system call table generation support mips: generate uapi header and system call table files arch/mips/Makefile | 3 + arch/mips/include/asm/Kbuild | 4 + arch/mips/include/asm/unistd.h | 6 +- arch/mips/include/uapi/asm/Kbuild | 3 + arch/mips/include/uapi/asm/unistd.h | 1057 +---------------------------- arch/mips/kernel/ftrace.c | 6 +- arch/mips/kernel/scall32-o32.S | 390 +---------- arch/mips/kernel/scall64-64.S | 335 +-------- arch/mips/kernel/scall64-n32.S | 341 +--------- arch/mips/kernel/scall64-o32.S | 379 +---------- arch/mips/kernel/syscalls/Makefile | 71 ++ arch/mips/kernel/syscalls/syscall_64.tbl | 339 +++++++++ arch/mips/kernel/syscalls/syscall_n32.tbl | 343 ++++++++++ arch/mips/kernel/syscalls/syscall_o32.tbl | 382 +++++++++++ arch/mips/kernel/syscalls/syscallhdr.sh | 36 + arch/mips/kernel/syscalls/syscalltbl.sh | 36 + 16 files changed, 1259 insertions(+), 2472 deletions(-) create mode 100644 arch/mips/kernel/syscalls/Makefile create mode 100644 arch/mips/kernel/syscalls/syscall_64.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_n32.tbl create mode 100644 arch/mips/kernel/syscalls/syscall_o32.tbl create mode 100644 arch/mips/kernel/syscalls/syscallhdr.sh create mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

3
14
0 0

[PATCH v2 0/4] powerpc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name. - spu entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, sh, sparc, and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. - changed from generic-y to generated-y in Kbuild. Firoz Khan (4): powerpc: add __NR_syscalls along with NR_syscalls powerpc: move macro definition from asm/systbl.h powerpc: add system call table generation support powerpc: generate uapi header and system call table files arch/powerpc/Makefile | 3 + arch/powerpc/include/asm/Kbuild | 4 + arch/powerpc/include/asm/systbl.h | 396 --------------------------- arch/powerpc/include/asm/unistd.h | 3 +- arch/powerpc/include/uapi/asm/Kbuild | 2 + arch/powerpc/include/uapi/asm/unistd.h | 389 +------------------------- arch/powerpc/kernel/Makefile | 10 - arch/powerpc/kernel/syscalls/Makefile | 61 +++++ arch/powerpc/kernel/syscalls/syscall.tbl | 408 ++++++++++++++++++++++++++++ arch/powerpc/kernel/syscalls/syscallhdr.sh | 36 +++ arch/powerpc/kernel/syscalls/syscalltbl.sh | 41 +++ arch/powerpc/kernel/systbl.S | 37 +-- arch/powerpc/kernel/systbl_chk.c | 60 ---- arch/powerpc/platforms/cell/spu_callbacks.c | 17 +- 14 files changed, 575 insertions(+), 892 deletions(-) delete mode 100644 arch/powerpc/include/asm/systbl.h create mode 100644 arch/powerpc/kernel/syscalls/Makefile create mode 100644 arch/powerpc/kernel/syscalls/syscall.tbl create mode 100644 arch/powerpc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/powerpc/kernel/syscalls/syscalltbl.sh delete mode 100644 arch/powerpc/kernel/systbl_chk.c -- 1.9.1

7 years, 4 months

2
6
0 0

[PATCH v3 0/4] sparc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. - Compat entry name, if required. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. Changes since v2: - changed from generic-y to generated-y in Kbuild. - added io_pgetevents entry in the syscall.tbl. - updated the compat system call table. Changes since v1: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall.tbl. Firoz Khan (4): sparc: move __IGNORE* entries to non uapi header sparc: add __NR_syscalls along with NR_syscalls sparc: add system call table generation support sparc: generate uapi header and system call table files arch/sparc/Makefile | 3 + arch/sparc/include/asm/Kbuild | 4 +- arch/sparc/include/asm/unistd.h | 18 ++ arch/sparc/include/uapi/asm/Kbuild | 2 + arch/sparc/include/uapi/asm/unistd.h | 426 +------------------------------ arch/sparc/kernel/syscalls/Makefile | 55 ++++ arch/sparc/kernel/syscalls/syscall.tbl | 409 +++++++++++++++++++++++++++++ arch/sparc/kernel/syscalls/syscallhdr.sh | 36 +++ arch/sparc/kernel/syscalls/syscalltbl.sh | 36 +++ arch/sparc/kernel/systbls_32.S | 81 +----- arch/sparc/kernel/systbls_64.S | 157 +----------- 11 files changed, 572 insertions(+), 655 deletions(-) create mode 100644 arch/sparc/kernel/syscalls/Makefile create mode 100644 arch/sparc/kernel/syscalls/syscall.tbl create mode 100644 arch/sparc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/sparc/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

3
8
0 0

[PATCH v7 0/5] parisc: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, powerpc, sh, sparc and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v6: - changed from generic-y to generated-y in Kbuild. changes since v5: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. changes since v4: - optimized/updated the syscall table generation scripts. - removed __IGNORE entries which was added in v2 to suppress the warning. changes since v3: - optimized/updated the syscall table generation scripts. - added missing new line. changes since v2: - updated the syscall.tbl file by including missed entries. changes since v1: - enclosed __NR_sycalls macro with __KERNEL__. Firoz Khan (5): parisc: move __IGNORE* entries to non uapi header parisc: add __NR_syscalls along with __NR_Linux_syscalls parisc: add system call table generation support parisc: generate uapi header and system call table files parisc: syscalls: ignore nfsservctl for other architectures arch/parisc/Makefile | 3 + arch/parisc/include/asm/Kbuild | 3 + arch/parisc/include/asm/unistd.h | 8 + arch/parisc/include/uapi/asm/Kbuild | 2 + arch/parisc/include/uapi/asm/unistd.h | 382 +------------------------ arch/parisc/kernel/syscall.S | 11 +- arch/parisc/kernel/syscall_table.S | 459 ------------------------------ arch/parisc/kernel/syscalls/Makefile | 57 ++++ arch/parisc/kernel/syscalls/syscall.tbl | 369 ++++++++++++++++++++++++ arch/parisc/kernel/syscalls/syscallhdr.sh | 36 +++ arch/parisc/kernel/syscalls/syscalltbl.sh | 36 +++ scripts/checksyscalls.sh | 1 + 12 files changed, 531 insertions(+), 836 deletions(-) delete mode 100644 arch/parisc/kernel/syscall_table.S create mode 100644 arch/parisc/kernel/syscalls/Makefile create mode 100644 arch/parisc/kernel/syscalls/syscall.tbl create mode 100644 arch/parisc/kernel/syscalls/syscallhdr.sh create mode 100644 arch/parisc/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

3
11
0 0

Re: [Y2038] [PATCH v4 0/3] microblaze: system call table generation support

by Firoz Khan

Hi Michal, On Fri, 16 Nov 2018 at 14:01, Michal Simek <monstr(a)monstr.eu> wrote: > > On 13. 11. 18 7:04, Firoz Khan wrote: > > The purpose of this patch series is, we can easily > > add/modify/delete system call table support by cha- > > nging entry in syscall.tbl file instead of manually > > changing many files. The other goal is to unify the > > system call table generation support implementation > > across all the architectures. > > > > The system call tables are in different format in > > all architecture. It will be difficult to manually > > add, modify or delete the system calls in the resp- > > ective files manually. To make it easy by keeping a > > script and which'll generate uapi header file and > > syscall table file. > > > > syscall.tbl contains the list of available system > > calls along with system call number and correspond- > > ing entry point. Add a new system call in this arch- > > itecture will be possible by adding new entry in the > > syscall.tbl file. > > > > Adding a new table entry consisting of: > > - System call number. > > - ABI. > > - System call name. > > - Entry point name. > > > > ARM, s390 and x86 architecuture does exist the sim- > > ilar support. I leverage their implementation to > > come up with a generic solution. > > > > I have done the same support for work for alpha, ia64, > > m68k, mips, parisc, powerpc, sh, sparc and xtensa. > > Below mentioned git repository contains more details > > about the workflow. > > > > https://github.com/frzkhn/system_call_table_generator/ > > > > Finally, this is the ground work to solve the Y2038 > > issue. We need to add two dozen of system calls to > > solve Y2038 issue. So this patch series will help to > > add new system calls easily by adding new entry in > > the syscall.tbl. > > > > changes since v3: > > - changed from generic-y to generated-y in Kbuild. > > > > changes since v2: > > - optimized/updated the syscall table generation > > scripts. > > - fixed all mixed indentation issues in syscall.tbl. > > - added "comments" in syscall_*.tbl. > > > > changes since v1: > > - enclosed __NR_sycalls macro with __KERNEL__. > > - added missing new line. > > next time please also keep this changelog in every patch. Sure. Basically I haven't came across changelog till a point where Geert Uytterhoeven <geert(a)linux-m68k.org> pointed out changelog is missing. Thanks Geert :) > > > > > Firoz Khan (3): > > microblaze: move __NR_syscalls macro from asm/unistd.h > > microblaze: add system call table generation support > > microblaze: generate uapi header and system call table files > > > > arch/microblaze/Makefile | 3 + > > arch/microblaze/include/asm/Kbuild | 1 + > > arch/microblaze/include/asm/unistd.h | 2 - > > arch/microblaze/include/uapi/asm/Kbuild | 1 + > > arch/microblaze/include/uapi/asm/unistd.h | 407 +------------------------ > > arch/microblaze/kernel/syscall_table.S | 406 +------------------------ > > arch/microblaze/kernel/syscalls/Makefile | 38 +++ > > arch/microblaze/kernel/syscalls/syscall.tbl | 410 ++++++++++++++++++++++++++ > > arch/microblaze/kernel/syscalls/syscallhdr.sh | 36 +++ > > arch/microblaze/kernel/syscalls/syscalltbl.sh | 32 ++ > > 10 files changed, 526 insertions(+), 810 deletions(-) > > create mode 100644 arch/microblaze/kernel/syscalls/Makefile > > create mode 100644 arch/microblaze/kernel/syscalls/syscall.tbl > > create mode 100644 arch/microblaze/kernel/syscalls/syscallhdr.sh > > create mode 100644 arch/microblaze/kernel/syscalls/syscalltbl.sh > > > > Looks good now. I have queue it to next. And also asked our team to > retest everything. Sounds good! Thanks Firoz > > Thanks, > Michal > > -- > Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 > w: www.monstr.eu p: +42-0-721842854 > Maintainer of Linux kernel - Xilinx Microblaze > Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs > U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs > >

7 years, 4 months

1
0
0 0

[PATCH v2 0/3] xtensa: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, microblaze, mips, parisc, powerpc, sh and sparc. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v1: - changed from generic-y to generated-y in Kbuild. - removed the patch "0001-xtensa-move-SYS_XTENSA_- macros-to-non-uapi-header.patch". Firoz Khan (3): xtensa: add __NR_syscalls along with __NR_syscall_count xtensa: add system call table generation support xtensa: generate uapi header and syscall table header files arch/xtensa/Makefile | 3 + arch/xtensa/include/asm/Kbuild | 1 + arch/xtensa/include/asm/unistd.h | 2 + arch/xtensa/include/uapi/asm/Kbuild | 1 + arch/xtensa/include/uapi/asm/unistd.h | 781 +----------------------------- arch/xtensa/kernel/syscall.c | 5 +- arch/xtensa/kernel/syscalls/Makefile | 38 ++ arch/xtensa/kernel/syscalls/syscall.tbl | 374 ++++++++++++++ arch/xtensa/kernel/syscalls/syscallhdr.sh | 36 ++ arch/xtensa/kernel/syscalls/syscalltbl.sh | 32 ++ 10 files changed, 492 insertions(+), 781 deletions(-) create mode 100644 arch/xtensa/kernel/syscalls/Makefile create mode 100644 arch/xtensa/kernel/syscalls/syscall.tbl create mode 100644 arch/xtensa/kernel/syscalls/syscallhdr.sh create mode 100644 arch/xtensa/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

2
11
0 0

[PATCH v5 0/5] ia64: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, m68k, microblaze, mips, parisc, powerpc, sh, sparc and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v4: - changed from generic-y to generated-y in Kbuild. changes since v3: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall.tbl. - removed __IGNORE entries which was added in v2 to suppress the warning. changes since v2: - fixed the offset logic in the script. - added missing new line. changes since v1: - enclosed __NR_sycalls macro with __KERNEL__. Firoz Khan (5): ia64: add __NR_old_getpagesize in uapi header file ia64: add __NR_syscalls along with NR_syscalls ia64: add an offset for system call number ia64: add system call table generation support ia64: generate uapi header and system call table files arch/ia64/Makefile | 3 + arch/ia64/include/asm/Kbuild | 1 + arch/ia64/include/asm/unistd.h | 4 +- arch/ia64/include/uapi/asm/Kbuild | 1 + arch/ia64/include/uapi/asm/unistd.h | 332 +------------------------------ arch/ia64/kernel/entry.S | 331 +------------------------------ arch/ia64/kernel/syscalls/Makefile | 40 ++++ arch/ia64/kernel/syscalls/syscall.tbl | 337 ++++++++++++++++++++++++++++++++ arch/ia64/kernel/syscalls/syscallhdr.sh | 36 ++++ arch/ia64/kernel/syscalls/syscalltbl.sh | 32 +++ 10 files changed, 458 insertions(+), 659 deletions(-) create mode 100644 arch/ia64/kernel/syscalls/Makefile create mode 100644 arch/ia64/kernel/syscalls/syscall.tbl create mode 100644 arch/ia64/kernel/syscalls/syscallhdr.sh create mode 100644 arch/ia64/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

2
7
0 0

[PATCH v4 0/3] microblaze: system call table generation support

by Firoz Khan

The purpose of this patch series is, we can easily add/modify/delete system call table support by cha- nging entry in syscall.tbl file instead of manually changing many files. The other goal is to unify the system call table generation support implementation across all the architectures. The system call tables are in different format in all architecture. It will be difficult to manually add, modify or delete the system calls in the resp- ective files manually. To make it easy by keeping a script and which'll generate uapi header file and syscall table file. syscall.tbl contains the list of available system calls along with system call number and correspond- ing entry point. Add a new system call in this arch- itecture will be possible by adding new entry in the syscall.tbl file. Adding a new table entry consisting of: - System call number. - ABI. - System call name. - Entry point name. ARM, s390 and x86 architecuture does exist the sim- ilar support. I leverage their implementation to come up with a generic solution. I have done the same support for work for alpha, ia64, m68k, mips, parisc, powerpc, sh, sparc and xtensa. Below mentioned git repository contains more details about the workflow. https://github.com/frzkhn/system_call_table_generator/ Finally, this is the ground work to solve the Y2038 issue. We need to add two dozen of system calls to solve Y2038 issue. So this patch series will help to add new system calls easily by adding new entry in the syscall.tbl. changes since v3: - changed from generic-y to generated-y in Kbuild. changes since v2: - optimized/updated the syscall table generation scripts. - fixed all mixed indentation issues in syscall.tbl. - added "comments" in syscall_*.tbl. changes since v1: - enclosed __NR_sycalls macro with __KERNEL__. - added missing new line. Firoz Khan (3): microblaze: move __NR_syscalls macro from asm/unistd.h microblaze: add system call table generation support microblaze: generate uapi header and system call table files arch/microblaze/Makefile | 3 + arch/microblaze/include/asm/Kbuild | 1 + arch/microblaze/include/asm/unistd.h | 2 - arch/microblaze/include/uapi/asm/Kbuild | 1 + arch/microblaze/include/uapi/asm/unistd.h | 407 +------------------------ arch/microblaze/kernel/syscall_table.S | 406 +------------------------ arch/microblaze/kernel/syscalls/Makefile | 38 +++ arch/microblaze/kernel/syscalls/syscall.tbl | 410 ++++++++++++++++++++++++++ arch/microblaze/kernel/syscalls/syscallhdr.sh | 36 +++ arch/microblaze/kernel/syscalls/syscalltbl.sh | 32 ++ 10 files changed, 526 insertions(+), 810 deletions(-) create mode 100644 arch/microblaze/kernel/syscalls/Makefile create mode 100644 arch/microblaze/kernel/syscalls/syscall.tbl create mode 100644 arch/microblaze/kernel/syscalls/syscallhdr.sh create mode 100644 arch/microblaze/kernel/syscalls/syscalltbl.sh -- 1.9.1

7 years, 4 months

1
3
0 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Y2038