All,

I've been reviewing and trying out Volodymyr's patches related to dynamic shared memory.

One thing I found thoroughly confusing was that in the same capabilities list we use the word "register" in two completely different ways.

/* Secure world can communicate via previously unregistered shared memory */ #define OPTEE_SMC_SEC_CAP_UNREGISTERED_SHM (1 << 1) /* Secure world supporst commands "register/unregister shared memory" */ #define OPTEE_SMC_SEC_CAP_REGISTER_SHM (1 << 2)

As far as I can tell "unregistered shared memory" simply means "dynamic shared memory" vs a pre-allocated static region.

It would be much clearer if we tweaked the names:

/* Secure world can communicate via previously unregistered shared memory */ #define OPTEE_SMC_SEC_CAP_DYNAMIC_SHM (1 << 1) /* Secure world supporst commands "register/unregister shared memory" */ #define OPTEE_SMC_SEC_CAP_CMD_REGISTER_SHM (1 << 2)

Are you open to that change?

Thanks, Stuart