Smatch complains that "ctx" isn't checked consistently:
drivers/tee/tee_shm.c:164 tee_shm_alloc() warn: variable dereferenced before check 'ctx' (see line 95)
I audited the callers and "ctx" can't be NULL so the check can be removed.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com --- drivers/tee/tee_shm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c index bd679b72bd05..8895cb910166 100644 --- a/drivers/tee/tee_shm.c +++ b/drivers/tee/tee_shm.c @@ -161,8 +161,7 @@ struct tee_shm *tee_shm_alloc(struct tee_context *ctx, size_t size, u32 flags) } }
- if (ctx) - teedev_ctx_get(ctx); + teedev_ctx_get(ctx);
return shm; err_rem:
On Tue, Apr 7, 2020 at 11:32 AM Dan Carpenter dan.carpenter@oracle.com wrote:
Smatch complains that "ctx" isn't checked consistently:
drivers/tee/tee_shm.c:164 tee_shm_alloc() warn: variable dereferenced before check 'ctx' (see line 95)
I audited the callers and "ctx" can't be NULL so the check can be removed.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
drivers/tee/tee_shm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks, I'm picking this up.
Cheers, Jens