Hi,
The current implementation of tspd_cpu_migrate_info hardcodes the type information for all platforms via #define TSP_MIGRATE_INFO.
Would it make sense to introduce a weak bl31_plat_cpu_migrate_info call to either be populated by the platform or defaulted to TSP_MIGRATE_INFO. I am asking because rcar_gen3 platform has this requirement (not sure about all the other platforms).
diff --git a/services/spd/tspd/tspd_pm.c b/services/spd/tspd/tspd_pm.c index 9414c15..c24b5a8 100644 --- a/services/spd/tspd/tspd_pm.c +++ b/services/spd/tspd/tspd_pm.c @@ -178,7 +178,7 @@ static void tspd_cpu_suspend_finish_handler(u_register_t max_off_pwrlvl) ******************************************************************************/ static int32_t tspd_cpu_migrate_info(u_register_t *resident_cpu) { - return TSP_MIGRATE_INFO; + return bl31_plat_cpu_migrate_info(resident_cpu); }
thanks Jorge
Hi Jorge,
On Fri, Aug 31, 2018 at 11:44 PM, Jorge Ramirez-Ortiz jramirez@baylibre.com wrote:
Hi,
The current implementation of tspd_cpu_migrate_info hardcodes the type information for all platforms via #define TSP_MIGRATE_INFO.
Would it make sense to introduce a weak bl31_plat_cpu_migrate_info call to either be populated by the platform or defaulted to TSP_MIGRATE_INFO. I am asking because rcar_gen3 platform has this requirement (not sure about all the other platforms).
I think you'd get more responses if you ask the TF-A folks.
Thanks, Jens
diff --git a/services/spd/tspd/tspd_pm.c b/services/spd/tspd/tspd_pm.c index 9414c15..c24b5a8 100644 --- a/services/spd/tspd/tspd_pm.c +++ b/services/spd/tspd/tspd_pm.c @@ -178,7 +178,7 @@ static void tspd_cpu_suspend_finish_handler(u_register_t max_off_pwrlvl) ******************************************************************************/ static int32_t tspd_cpu_migrate_info(u_register_t *resident_cpu) {
- return TSP_MIGRATE_INFO;
- return bl31_plat_cpu_migrate_info(resident_cpu);
}
thanks Jorge _______________________________________________ Tee-dev mailing list Tee-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/tee-dev
On 09/03/2018 09:16 AM, Jens Wiklander wrote:
Hi Jorge,
On Fri, Aug 31, 2018 at 11:44 PM, Jorge Ramirez-Ortiz jramirez@baylibre.com wrote:
Hi,
The current implementation of tspd_cpu_migrate_info hardcodes the type information for all platforms via #define TSP_MIGRATE_INFO.
Would it make sense to introduce a weak bl31_plat_cpu_migrate_info call to either be populated by the platform or defaulted to TSP_MIGRATE_INFO. I am asking because rcar_gen3 platform has this requirement (not sure about all the other platforms).
I think you'd get more responses if you ask the TF-A folks.
I already did but the service is maintained by op-tee so I was asked to include you and Joakim. shall we follow up from tf-issues [1]?
[1] https://github.com/ARM-software/tf-issues/issues/617
thanks! Jorge
On Mon, Sep 3, 2018 at 9:37 AM, Jorge Ramirez-Ortiz jramirez@baylibre.com wrote:
On 09/03/2018 09:16 AM, Jens Wiklander wrote:
Hi Jorge,
On Fri, Aug 31, 2018 at 11:44 PM, Jorge Ramirez-Ortiz jramirez@baylibre.com wrote:
Hi,
The current implementation of tspd_cpu_migrate_info hardcodes the type information for all platforms via #define TSP_MIGRATE_INFO.
Would it make sense to introduce a weak bl31_plat_cpu_migrate_info call to either be populated by the platform or defaulted to TSP_MIGRATE_INFO. I am asking because rcar_gen3 platform has this requirement (not sure about all the other platforms).
I think you'd get more responses if you ask the TF-A folks.
I already did but the service is maintained by op-tee so I was asked to include you and Joakim.
It's only services/spd/opteed that is maintained by us (there's plat/qemu that that's another story).
TSP is TF-A's "demo" stuff that doesn't rely on an external TEE.
Regards, Jens
On 09/03/2018 09:47 AM, Jens Wiklander wrote:
On Mon, Sep 3, 2018 at 9:37 AM, Jorge Ramirez-Ortiz jramirez@baylibre.com wrote:
On 09/03/2018 09:16 AM, Jens Wiklander wrote:
Hi Jorge,
On Fri, Aug 31, 2018 at 11:44 PM, Jorge Ramirez-Ortiz jramirez@baylibre.com wrote:
Hi,
The current implementation of tspd_cpu_migrate_info hardcodes the type information for all platforms via #define TSP_MIGRATE_INFO.
Would it make sense to introduce a weak bl31_plat_cpu_migrate_info call to either be populated by the platform or defaulted to TSP_MIGRATE_INFO. I am asking because rcar_gen3 platform has this requirement (not sure about all the other platforms).
I think you'd get more responses if you ask the TF-A folks.
I already did but the service is maintained by op-tee so I was asked to include you and Joakim.
It's only services/spd/opteed that is maintained by us (there's plat/qemu that that's another story).
TSP is TF-A's "demo" stuff that doesn't rely on an external TEE.
you are absolutely right. apologies. I wonder why this code was modified in Renesas's rcar_gen3 baseline...um
anyway all set. thanks and sorry again1
Regards, Jens
-
Jens Wiklander -
Jorge Ramirez-Ortiz