Re: [Tee-dev] [PATCH v1] tee: optee: Use UUID API for exporting the UUID

On Wed, Apr 22, 2020 at 04:00:47PM +0300, Andy Shevchenko wrote:

There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.

This allows to hide the uuid_t internals.

Any comment on this?

Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com

drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index e3a148521ec1d..2ecc6993f48bb 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -107,7 +107,7 @@ int optee_enumerate_devices(void) return -ENODEV; /* Open session with device enumeration pseudo TA */

• memcpy(sess_arg.uuid, pta_uuid.b, TEE_IOCTL_UUID_LEN);

• export_uuid(sess_arg.uuid, &pta_uuid); sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; sess_arg.num_params = 0;

2.26.1