Hi,
On 18/12/2018 21:11, Volodymyr Babchuk wrote:
From: Volodymyr Babchuk vlad.babchuk@gmail.com
If TEE support is enabled with "tee=1" option in xl.cfg, then we need to inform guest about available TEE.
Currently only OP-TEE is supported, so we'll create DT node in a way that is expected by optee driver in linux.
Signed-off-by: Volodymyr Babchuk vlad.babchuk@gmail.com
tools/libxl/libxl_arm.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index f8b4ef55e0..befccebd19 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -409,6 +409,32 @@ static int make_psci_node(libxl__gc *gc, void *fdt) return 0; } +static int make_optee_node(libxl__gc *gc, void *fdt) +{
- int res;
- LOG(DEBUG, "Creating OP-TEE node in dtb");
- res = fdt_begin_node(fdt, "firmware");
- if (res) return res;
- res = fdt_begin_node(fdt, "optee");
- if (res) return res;
- res = fdt_property_compat(gc, fdt, 1, "linaro,optee-tz");
- if (res) return res;
- res = fdt_property_string(fdt, "method", "smc");
As said on v2, we want to use HVC interface and not SMC.
- if (res) return res;
- res = fdt_end_node(fdt);
- if (res) return res;
- res = fdt_end_node(fdt);
- if (res) return res;
- return 0;
+}
- static int make_memory_nodes(libxl__gc *gc, void *fdt, const struct xc_dom_image *dom) {
@@ -922,6 +948,9 @@ next_resize: if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART) FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
if (libxl_defbool_val(info->tee))
FDT( make_optee_node(gc, fdt));
As said on v2, there are a missing space before the last ).
if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) );
Cheers,