Re: [Tee-dev] [PATCH v4 03/10] xen/arm: optee: add OP-TEE mediator skeleton

Hi Volodymyr,

On 07/03/2019 21:04, Volodymyr Babchuk wrote:

+static void forward_call(struct cpu_user_regs *regs) +{

• struct arm_smccc_res resp;
• arm_smccc_smc(get_user_reg(regs, 0),

•              get_user_reg(regs, 1),
  

•              get_user_reg(regs, 2),
  

•              get_user_reg(regs, 3),
  

•              get_user_reg(regs, 4),
  

•              get_user_reg(regs, 5),
  

•              get_user_reg(regs, 6),
  

•              OPTEE_CLIENT_ID(current->domain),
  

•              &resp);
  

• set_user_reg(regs, 0, resp.a0);
• set_user_reg(regs, 1, resp.a1);
• set_user_reg(regs, 2, resp.a2);
• set_user_reg(regs, 3, resp.a3);
• set_user_reg(regs, 4, 0);
• set_user_reg(regs, 5, 0);
• set_user_reg(regs, 6, 0);
• set_user_reg(regs, 7, 0);

Related to what I pointed on patch #4, this does not look right to me.

Cheers,