Hi Jens,,
The code that refers to the generic tee part looks good to me. The only comment I have for the op-tee code is regarding the “tee-optee” compatible tag, is that something that you intend to read from the device tree? Are you thinking of a tee node?
The rest looks good to me.
And btw, thanks for renaming tee_filp :)
Best, Javier
On 08 Apr 2015, at 13:52, Jens Wiklander jens.wiklander@linaro.org wrote:
Hi,
Here's my latest patches for the generic TEE subsystem. There's two patches with incompatible driver API changes which makes the OP-TEE driver fail to compile. I'm fixing that in "optee: incompatible tee subsystem api change" as a separate commit to make it easy to squash the different patches later when we send it to the kernel mailing list.
While this review is ongoing the patches are also available at https://github.com/jenswi-linaro/linux/tree/tee-dev3 I'll make a pull request of this when this review is done.
Jens Wiklander (7): tee: bugfix refcount tee: fix tee_shm_va2pa() and tee_shm_pa2va() tee: shared memory from CMA or res_mem tee: rename struct tee_filp optee: incompatible tee subsystem api change tee: update module reference counter tee: bugfix error handling of tee_shm_alloc()
drivers/sec-hw/Makefile | 3 +- drivers/sec-hw/optee/Kconfig | 3 +- drivers/sec-hw/optee/Makefile | 3 +- drivers/sec-hw/optee/core.c | 222 +++++++++++++++++++++++++++++++++++++++ drivers/sec-hw/optee/optee.c | 201 ----------------------------------- drivers/sec-hw/tee.c | 76 ++++++++------ drivers/sec-hw/tee_private.h | 51 ++++++--- drivers/sec-hw/tee_shm.c | 204 +++++++++++++++++------------------- drivers/sec-hw/tee_shm_pool.c | 232 +++++++++++++++++++++++++++++++++++++++++ include/linux/sec-hw/tee_drv.h | 75 ++++++++++--- 10 files changed, 697 insertions(+), 373 deletions(-) create mode 100644 drivers/sec-hw/optee/core.c delete mode 100644 drivers/sec-hw/optee/optee.c create mode 100644 drivers/sec-hw/tee_shm_pool.c
-- 1.9.1
Tee-dev mailing list Tee-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/tee-dev