Re: [Tee-dev] [PATCH v4 08/10] xen/arm: optee: add support for RPC commands

Hi Volodymyr,

On 07/03/2019 21:04, Volodymyr Babchuk wrote:

@@ -376,8 +391,11 @@ static struct shm_rpc *allocate_and_pin_shm_rpc(struct optee_domain *ctx, return shm_rpc; err:

• free_domheap_page(shm_rpc->xen_arg_pg);

• if ( shm_rpc->guest_page )
      put_page(shm_rpc->guest_page);
  

Spurious change.

[...]

•    /*
  

•     * TODO: With current implementation, OP-TEE will not issue
  

•     * RPC to free this buffer. Guest and OP-TEE will be out of
  

•     * sync: guest believes that it provided buffer to OP-TEE,
  

•     * while OP-TEE thinks of opposite. Ideally, we need to
  

•     * emulate RPC with OPTEE_MSG_RPC_CMD_SHM_FREE command.
  

•     */
  

Can this condition happen if Xen runs out of memory?

Cheers,