+tee-dev
On Mon, Jun 12, 2017 at 10:11 AM, Jens Wiklander jens.wiklander@linaro.org wrote:
Hi Stuart,
On Sat, Jun 10, 2017 at 12:12 AM, Stuart Yoder stuart.yoder@arm.com wrote:
+Volodymyr (correcting corrupted email address)
On 6/9/17 11:51 AM, Stuart Yoder wrote:
All,
I've been reviewing and trying out Volodymyr's patches related to dynamic shared memory.
One thing I found thoroughly confusing was that in the same capabilities list we use the word "register" in two completely different ways.
/* Secure world can communicate via previously unregistered shared memory */ #define OPTEE_SMC_SEC_CAP_UNREGISTERED_SHM (1 << 1) /* Secure world supporst commands "register/unregister shared memory" */ #define OPTEE_SMC_SEC_CAP_REGISTER_SHM (1 << 2)
As far as I can tell "unregistered shared memory" simply means "dynamic shared memory" vs a pre-allocated static region.
It would be much clearer if we tweaked the names:
/* Secure world can communicate via previously unregistered shared memory */ #define OPTEE_SMC_SEC_CAP_DYNAMIC_SHM (1 << 1) /* Secure world supporst commands "register/unregister shared memory" */ #define OPTEE_SMC_SEC_CAP_CMD_REGISTER_SHM (1 << 2)
Are you open to that change?
I agree, what you're proposing is more clear. It's not an ABI change, only how it's documented. Since we already have OPTEE_SMC_SEC_CAP_UNREGISTERED_SHM defined on the (optee_os) master branch we do the change there via a pull request.
If possible please create a pull request at github.
Thanks, Jens