There is export_uuid() function which exports uuid_t to the u8 array.
Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..4cf0c2576037 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
return -ENODEV;
/* Open session with Bnxt load Trusted App */
- memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+ export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
sess_arg.num_params = 0;
--
2.29.2
Hello,
I've recently been involved in producing PoC, which utilizes OP-TEE
to produce proof of a secret key possession. That is used during tunnel
establishment by OpenVPN.
In case someone finds it interesting, for example as kind of "real-world"
use case of OP-TEE, then details are described here:
https://www.amongbytes.com/post/20210112-optee-openssl-engine/
and code is here:
https://github.com/henrydcase/optee_eng
The actual PoC used post-quantum schemes integrated into TEE OS and TF-A
(secure boot). Those two points are not described really described for brevity
(and probably there is low interest anyway).
Kind regards,
Kris
Hi,
I have been seeing out of memory failures due to tee_shm_free() on
kexec path. This issue in discussed in length at:
link: https://github.com/OP-TEE/optee_os/issues/3637
Driver: drivers/firmware/broadcom/tee_bnxt_fw.c
I have tried various experiments to try and debug this issue but
haven't found a fix. All I have manged is to delay the occurrence
of the issue.
Any pointers would be helpful.
Thanks,
- Allen