From: Volodymyr Babchuk <vlad.babchuk(a)gmail.com>
This patch series enables dynamic shared memory support in the TEE
subsystem as a whole and in OP-TEE in particular.
Global Platform TEE specification [1] allows client applications
to register part of own memory as a shared buffer between
application and TEE. This allows fast zero-copy communication between
TEE and REE. But current implementation of TEE in Linux does not support
this feature.
Also, current implementation of OP-TEE transport uses fixed size
pre-shared buffer for all communications with OP-TEE OS. This is okay
in the most use cases. But this prevents use of OP-TEE in virtualized
environments, because:
a) We can't share the same buffer between different virtual machines
b) Physically contiguous memory as seen by VM can be non-contiguous
in reality (and as seen by OP-TEE OS) due to second stage of
MMU translation.
c) Size of this pre-shared buffer is limited.
So, first part of this patch series adds generic register/unregister
interface to tee subsystem. Next patches add necessary features
into OP-TEE driver, so it can use not only static pre-shared buffer,
but whole RAM to communicate with OP-TEE OS.
[1] https://www.globalplatform.org/specificationsdevice.asp
Jens Wiklander (2):
tee: flexible shared memory pool creation
tee: add register user memory
Volodymyr Babchuk (12):
tee: shm: add accessors for buffer size and page offset
tee: shm: add page accessor functions
tee: optee: Update protocol definitions
tee: optee: add page list manipulation functions
tee: optee: add shared buffer registration functions
tee: optee: add registered shared parameters handling
tee: optee: add registered buffers handling into RPC calls
tee: optee: store OP-TEE capabilities in private data
tee: optee: add optee-specific shared pool implementation
tee: optee: enable dynamic SHM support
tee: use reference counting for tee_context
tee: shm: inline tee_shm getter functions
drivers/tee/optee/Makefile | 1 +
drivers/tee/optee/call.c | 131 +++++++++++++++++++++-
drivers/tee/optee/core.c | 160 +++++++++++++++++++++------
drivers/tee/optee/optee_msg.h | 38 ++++++-
drivers/tee/optee/optee_private.h | 26 ++++-
drivers/tee/optee/optee_smc.h | 7 ++
drivers/tee/optee/rpc.c | 72 ++++++++++--
drivers/tee/optee/shm_pool.c | 75 +++++++++++++
drivers/tee/optee/shm_pool.h | 23 ++++
drivers/tee/tee_core.c | 81 ++++++++++++--
drivers/tee/tee_private.h | 60 +---------
drivers/tee/tee_shm.c | 226 +++++++++++++++++++++++++++++++-------
drivers/tee/tee_shm_pool.c | 165 +++++++++++++++++-----------
include/linux/tee_drv.h | 184 ++++++++++++++++++++++++++++++-
include/uapi/linux/tee.h | 30 +++++
15 files changed, 1058 insertions(+), 221 deletions(-)
create mode 100644 drivers/tee/optee/shm_pool.c
create mode 100644 drivers/tee/optee/shm_pool.h
--
2.7.4
All,
I am facing an issue I need to debug where after running some number of TAs, the OP-TEE kernel is no longer able to malloc() memory and can no longer load a TA. So, there seems to be a leak of some kind I need to debug. I'm using a crypto accelerator, and so there is most likely a bug in my crypto driver.
Is there any debug mechanism in OP-TEE I could use to get data or statistics about how much space is left on the heap? I've poked around some and don't see anything, but thought I would ask.
Thanks,
Stuart
Dear OP-TEE contributors and maintainers,
We're getting close to releasing OP-TEE 2.6.0.
I am pretty excited about this release, because it supports quite a few new
platforms and introduces cool features. A big one, in my opinion, is
dynamic shared memory [1] by Volodymyr Babchuk. In addition to being quite
helpful technically, this contribution is remarkable because it was
developed largely outside Linaro. I certainly hope we get more and more
involvement from the community in the future.
I have created release candidate tag 1 (2.6.0-rc1). Can you please help
with the following?
1. Check the CHANGELOG, see pull request #1881 [2]
2. Test 2.6.0-rc1 on your favorite platform(s).
Please use the change log pull request to report success (Tested-by:) or
issues.
To upgrade to 2.6.0-rc1 you need to checkout this tag in projects optee_os,
optee_client and optee_test. Please note our linux kernel branch has been
updated [3], it is now based on upstream 4.12. If your platform uses
OP-TEE's Secure Data Path feature (CFG_SECURE_DATA_PATH=y), make sure you
upgrade because ION has changed and xtest depends on this [4].
[1] https://github.com/OP-TEE/optee_os/commit/55d6853cb468 and
https://github.com/OP-TEE/optee_os/commit/b05cd886e06d
[2] https://github.com/OP-TEE/optee_os/pull/1881
[3] https://github.com/linaro-swg/linux/tree/optee
[4] https://github.com/OP-TEE/optee_test/commit/8bc3142b3b2b
Thanks for your help and support,
--
Jerome
OP-TEE Maintainer