[Tcwg-commits] [toolchain/ci/llvm-monorepo] branch linaro-local/ci/tcwg_kernel/llvm-master-aarch64-lts-allmodconfig updated (526a5a93b96 -> 8a96b47e9c1)

16 Dec 2018


      This is an automated email from the git hooks/post-receive script.
tcwg-buildslave pushed a change to branch linaro-local/ci/tcwg_kernel/llvm-master-aarch64-lts-allmodconfig
in repository toolchain/ci/llvm-monorepo.
from  526a5a93b96 [analyzer] Fix unknown block calls to have zero parameters.
      adds  8981e687037 Move static analyzer core diagnostics to common.
      adds  70b48d14cb3 A brief outline of the packets that need to be implemented  [...]
      adds  46329f8f720 Ah, forgot qModuleInfo.  Need to look that one up and finis [...]
      adds  86520474f42 Revert "[analyzer] MoveChecker: Add checks for dereferencin [...]
      adds  fe7d78bbf96 Rework docker setup to make it easier to work around bugs o [...]
      adds  00d3341b02e Fix bug in buildbot start script
      adds  2397e2d5551 Try 2: Fix bug in buildbot start script
      adds  0af12383a69 Fix includes and dependencies for libclang
      adds  0c32ab5242a [Power9][NFC] add setb exploitation test case
      adds  84af810765c Fix static assert diagnostic checks in i386
      adds  75fc74efdef hwasan: Fix typo: Previosly -> Previously.
      adds  84314a7de01 Fix typo in test cases as well.
      adds  d6ec10667ab [MinGW] Produce a vtable and RTTI for dllexported classes w [...]
      adds  b765bf40cb1 Fix internal_sleep() for NetBSD
      adds  a5533007815 [mips] Fix test typo in rL348914
      adds  3685ed31868 [libclang] Add dependency on clangSerialization to unbreak  [...]
      adds  d5e6ce8df3a [OpenMP] Fixes for LIBOMP_OMP_VERSION=45/40
      adds  59fc243600a [InstSimplify] Add tests for saturating add/sub + icmp; NFC
      adds  a31b47f214e Enable SANITIZER_INTERCEPT_PTHREAD_GETNAME_NP for NetBSD
      adds  f2ff5730335 Enable test/msan/pthread_getname_np.cc for NetBSD
      adds  518bd6ad239 [TargetLowering] Add ISD::OR + ISD::XOR handling to Simplif [...]
      adds  b425d5df6f0 Fix -Wunused-variable warning. NFCI.
      adds  7ce1264e176 [analyzer] Assume that we always have a SubEngine available
      adds  32a3dcc2d48 Remove /proc/pid/maps parsing code from NativeProcessLinux
      adds  124215d09f6 ELF: more section creation cleanup
      adds  738f1d58be0 lldb-test: Improve newline handling
      adds  a016a5537ba Regenerate neon copy tests. NFCI.
      adds  1837d6c9ad4 [CodeGen] Enhance machine PHIs optimization
      adds  cebe0af1867 [analyzer] Prefer returns values to out-params in CheckerRe [...]
      adds  d7e59143095 [analyzer][NFC] Move CheckerRegistry from the Core director [...]
      adds  f5315936c69 Register kASan shadow offset for NetBSD/amd64
      adds  a200780ef48 Add NetBSD support in needsRuntimeRegistrationOfSectionRange.
      adds  8013f1b3237 Fix a compilation error in examples/
      adds  5dce1cf1241 Link examples/clang-interpreter against clangSerialization
      adds  2885a93cde1 [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry
      adds  52f650d7f37 [analyzer][MallocChecker][NFC] Document and reorganize some [...]
      adds  b8bdc419f57 Update the vFile:open: description to note that the flags i [...]
      adds  0015e10bb5e [analyzer][MallocChecker] Improve warning messages on doubl [...]
      adds  a1ac7be38f4 [X86] Add optsize SHLD/SHRD tests
      adds  cdba30f1079 [X86] Lower to SHLD/SHRD on slow machines for optsize
      adds  ec357d47d9f [X86] Begin cleaning up combineOr -> SHLD/SHRD. NFCI.
      adds  abb46c15d95 [X86] Autogenerate complete checks. NFC
      adds  8a96b47e9c1 Fix a lit test failure after MallocChecker changes
No new revisions were added by this update.
Summary of changes:
 .../test/clang-tidy/static-analyzer.cpp            |    2 +-
 clang/examples/analyzer-plugin/MainCallChecker.cpp |    2 +-
 clang/examples/clang-interpreter/CMakeLists.txt    |    1 +
 clang/include/clang/Basic/DiagnosticCommonKinds.td |    6 +
 .../include/clang/Basic/DiagnosticFrontendKinds.td |    5 -
 .../Checkers/BuiltinCheckerRegistration.h}         |    0
 .../clang/StaticAnalyzer/Checkers/ClangCheckers.h  |   22 -
 .../Core/PathSensitive/ProgramState.h              |    8 +-
 .../{Core => Frontend}/CheckerRegistry.h           |   13 +-
 .../StaticAnalyzer/Frontend/FrontendActions.h      |    6 +-
 .../lib/FrontendTool/ExecuteCompilerInvocation.cpp |    6 +-
 clang/lib/Sema/SemaDeclCXX.cpp                     |    3 +
 .../Checkers/AnalysisOrderChecker.cpp              |    4 +-
 .../Checkers/AnalyzerStatsChecker.cpp              |    2 +-
 .../StaticAnalyzer/Checkers/ArrayBoundChecker.cpp  |    2 +-
 .../Checkers/ArrayBoundCheckerV2.cpp               |    2 +-
 .../Checkers/BasicObjCFoundationChecks.cpp         |    2 +-
 .../Checkers/BlockInCriticalSectionChecker.cpp     |    2 +-
 .../Checkers/BoolAssignmentChecker.cpp             |    2 +-
 .../Checkers/BuiltinFunctionChecker.cpp            |    2 +-
 clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt   |    1 -
 .../lib/StaticAnalyzer/Checkers/CStringChecker.cpp |    2 +-
 .../Checkers/CStringSyntaxChecker.cpp              |    2 +-
 .../Checkers/CXXSelfAssignmentChecker.cpp          |    2 +-
 .../Checkers/CallAndMessageChecker.cpp             |    2 +-
 .../StaticAnalyzer/Checkers/CastSizeChecker.cpp    |    2 +-
 .../Checkers/CastToStructChecker.cpp               |    2 +-
 .../StaticAnalyzer/Checkers/CheckObjCDealloc.cpp   |    2 +-
 .../Checkers/CheckObjCInstMethSignature.cpp        |    2 +-
 .../Checkers/CheckSecuritySyntaxOnly.cpp           |    2 +-
 .../StaticAnalyzer/Checkers/CheckSizeofPointer.cpp |    2 +-
 .../Checkers/CheckerDocumentation.cpp              |    2 +-
 .../lib/StaticAnalyzer/Checkers/ChrootChecker.cpp  |    2 +-
 .../lib/StaticAnalyzer/Checkers/ClangCheckers.cpp  |   32 -
 clang/lib/StaticAnalyzer/Checkers/CloneChecker.cpp |    2 +-
 .../StaticAnalyzer/Checkers/ConversionChecker.cpp  |    2 +-
 .../StaticAnalyzer/Checkers/DeadStoresChecker.cpp  |    2 +-
 .../lib/StaticAnalyzer/Checkers/DebugCheckers.cpp  |    2 +-
 .../Checkers/DeleteWithNonVirtualDtorChecker.cpp   |    2 +-
 .../StaticAnalyzer/Checkers/DereferenceChecker.cpp |    2 +-
 .../Checkers/DirectIvarAssignment.cpp              |    2 +-
 .../lib/StaticAnalyzer/Checkers/DivZeroChecker.cpp |    2 +-
 .../StaticAnalyzer/Checkers/DynamicTypeChecker.cpp |    2 +-
 .../Checkers/DynamicTypePropagation.cpp            |    2 +-
 .../Checkers/EnumCastOutOfRangeChecker.cpp         |    2 +-
 .../Checkers/ExprInspectionChecker.cpp             |    2 +-
 .../Checkers/FixedAddressChecker.cpp               |    2 +-
 .../Checkers/GCDAntipatternChecker.cpp             |    2 +-
 clang/lib/StaticAnalyzer/Checkers/GTestChecker.cpp |    2 +-
 .../Checkers/GenericTaintChecker.cpp               |    2 +-
 .../Checkers/IdenticalExprChecker.cpp              |    2 +-
 .../Checkers/InnerPointerChecker.cpp               |    2 +-
 .../StaticAnalyzer/Checkers/IteratorChecker.cpp    |    2 +-
 .../Checkers/IvarInvalidationChecker.cpp           |    2 +-
 .../Checkers/LLVMConventionsChecker.cpp            |    2 +-
 .../Checkers/LocalizationChecker.cpp               |    2 +-
 .../Checkers/MPI-Checker/MPIChecker.cpp            |    2 +-
 .../Checkers/MacOSKeychainAPIChecker.cpp           |    2 +-
 .../StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp   |    2 +-
 .../lib/StaticAnalyzer/Checkers/MallocChecker.cpp  | 1150 ++++++++++-------
 .../Checkers/MallocOverflowSecurityChecker.cpp     |    2 +-
 .../Checkers/MallocSizeofChecker.cpp               |    2 +-
 .../Checkers/MmapWriteExecChecker.cpp              |    2 +-
 clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp  |  202 +--
 .../Checkers/NSAutoreleasePoolChecker.cpp          |    2 +-
 .../lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp |    2 +-
 .../Checkers/NoReturnFunctionChecker.cpp           |    2 +-
 .../Checkers/NonNullParamChecker.cpp               |    2 +-
 .../Checkers/NonnullGlobalConstantsChecker.cpp     |    2 +-
 .../StaticAnalyzer/Checkers/NullabilityChecker.cpp |    2 +-
 .../Checkers/NumberObjectConversionChecker.cpp     |    2 +-
 .../StaticAnalyzer/Checkers/ObjCAtSyncChecker.cpp  |    2 +-
 .../Checkers/ObjCAutoreleaseWriteChecker.cpp       |    2 +-
 .../Checkers/ObjCContainersASTChecker.cpp          |    2 +-
 .../Checkers/ObjCContainersChecker.cpp             |    2 +-
 .../Checkers/ObjCMissingSuperCallChecker.cpp       |    2 +-
 .../Checkers/ObjCPropertyChecker.cpp               |    2 +-
 .../Checkers/ObjCSelfInitChecker.cpp               |    2 +-
 .../Checkers/ObjCSuperDeallocChecker.cpp           |    2 +-
 .../Checkers/ObjCUnusedIVarsChecker.cpp            |    2 +-
 .../lib/StaticAnalyzer/Checkers/PaddingChecker.cpp |    2 +-
 .../Checkers/PointerArithChecker.cpp               |    2 +-
 .../StaticAnalyzer/Checkers/PointerSubChecker.cpp  |    2 +-
 .../StaticAnalyzer/Checkers/PthreadLockChecker.cpp |    2 +-
 .../RetainCountChecker/RetainCountChecker.h        |    2 +-
 .../Checkers/ReturnPointerRangeChecker.cpp         |    2 +-
 .../StaticAnalyzer/Checkers/ReturnUndefChecker.cpp |    2 +-
 .../Checkers/RunLoopAutoreleaseLeakChecker.cpp     |    2 +-
 .../Checkers/SimpleStreamChecker.cpp               |    2 +-
 .../Checkers/StackAddrEscapeChecker.cpp            |    2 +-
 .../Checkers/StdLibraryFunctionsChecker.cpp        |    2 +-
 .../lib/StaticAnalyzer/Checkers/StreamChecker.cpp  |    2 +-
 .../StaticAnalyzer/Checkers/TaintTesterChecker.cpp |    2 +-
 .../Checkers/TestAfterDivZeroChecker.cpp           |    2 +-
 .../StaticAnalyzer/Checkers/TraversalChecker.cpp   |    2 +-
 .../Checkers/TrustNonnullChecker.cpp               |    2 +-
 .../StaticAnalyzer/Checkers/UndefBranchChecker.cpp |    2 +-
 .../Checkers/UndefCapturedBlockVarChecker.cpp      |    2 +-
 .../StaticAnalyzer/Checkers/UndefResultChecker.cpp |    2 +-
 .../Checkers/UndefinedArraySubscriptChecker.cpp    |    2 +-
 .../Checkers/UndefinedAssignmentChecker.cpp        |    2 +-
 .../UninitializedObjectChecker.cpp                 |    2 +-
 .../UninitializedObject/UninitializedPointee.cpp   |    1 -
 .../lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp |    2 +-
 .../Checkers/UnreachableCodeChecker.cpp            |    2 +-
 .../lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp |    2 +-
 .../lib/StaticAnalyzer/Checkers/ValistChecker.cpp  |    2 +-
 clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp |    2 +-
 .../StaticAnalyzer/Checkers/VirtualCallChecker.cpp |    2 +-
 clang/lib/StaticAnalyzer/Core/CMakeLists.txt       |    1 -
 clang/lib/StaticAnalyzer/Core/CallEvent.cpp        |    8 +-
 clang/lib/StaticAnalyzer/Core/ExprEngine.cpp       |    4 +-
 clang/lib/StaticAnalyzer/Core/ProgramState.cpp     |   59 +-
 clang/lib/StaticAnalyzer/Core/RegionStore.cpp      |    8 +-
 clang/lib/StaticAnalyzer/Core/SValBuilder.cpp      |    2 +-
 .../lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp  |    2 +-
 clang/lib/StaticAnalyzer/Frontend/CMakeLists.txt   |    1 +
 .../Frontend/CheckerRegistration.cpp               |   93 +-
 .../{Core => Frontend}/CheckerRegistry.cpp         |  202 +--
 .../expected-plists/NewDelete-path-notes.cpp.plist |   20 +-
 .../Malloc+MismatchedDeallocator+NewDelete.cpp     |    2 +-
 clang/test/Analysis/NewDelete-checker-test.cpp     |    2 +-
 clang/test/Analysis/NewDelete-path-notes.cpp       |    8 +-
 clang/test/Analysis/disable-all-checks.c           |   15 +-
 clang/test/Analysis/dtor.cpp                       |    2 +-
 clang/test/Analysis/malloc-annotations.c           |    6 +-
 clang/test/Analysis/malloc.c                       |    7 +-
 clang/test/Analysis/use-after-move.cpp             |   34 +-
 clang/test/CodeGenCXX/dllexport-missing-key.cpp    |   22 +
 clang/tools/libclang/CIndex.cpp                    |    2 -
 clang/tools/libclang/CIndexCodeCompletion.cpp      |    1 -
 clang/tools/libclang/CIndexDiagnostic.cpp          |    1 -
 clang/tools/libclang/CXStoredDiagnostic.cpp        |    2 +-
 .../StaticAnalyzer/RegisterCustomCheckersTest.cpp  |    2 +-
 compiler-rt/lib/hwasan/hwasan_report.cc            |    2 +-
 .../lib/sanitizer_common/sanitizer_netbsd.cc       |    2 +-
 .../sanitizer_platform_interceptors.h              |    2 +-
 compiler-rt/test/hwasan/TestCases/deep-recursion.c |   10 +-
 .../test/hwasan/TestCases/stack-history-length.c   |    4 +-
 compiler-rt/test/hwasan/TestCases/stack-uar.c      |    2 +-
 compiler-rt/test/msan/pthread_getname_np.cc        |    6 +-
 .../pairs/pairs.pair/pair.tuple_element.fail.cpp   |    2 +-
 .../variant.helper/variant_alternative.fail.cpp    |    2 +-
 .../sequences/array/array.tuple/get.fail.cpp       |    2 +-
 .../array/array.tuple/tuple_element.fail.cpp       |    2 +-
 .../containers/views/span.cons/default.fail.cpp    |    2 +-
 libcxx/utils/docker/debian9/Dockerfile             |    6 +-
 .../utils/docker/scripts/docker_start_buildbots.sh |    8 +
 libcxx/utils/docker/scripts/run_buildbot.sh        |    7 +
 lldb/docs/lldb-platform-packets.txt                |  388 ++++++
 lldb/include/lldb/Host/File.h                      |    2 +
 lldb/lit/Modules/ELF/compressed-sections.yaml      |    6 +-
 lldb/lit/Modules/ELF/section-addresses.yaml        |   58 +
 lldb/lit/Modules/ELF/section-permissions.yaml      |   34 +
 lldb/lit/Modules/ELF/section-types-edgecases.yaml  |   35 +
 lldb/lit/Modules/ELF/section-types.yaml            |    4 +-
 lldb/lit/Modules/MachO/subsections.yaml            |   22 +-
 .../Plugins/ObjectFile/ELF/ObjectFileELF.cpp       |  151 ++-
 lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h |    2 +
 .../Plugins/Process/Linux/NativeProcessLinux.cpp   |  119 +-
 lldb/tools/lldb-test/FormatUtil.cpp                |   47 +-
 lldb/tools/lldb-test/FormatUtil.h                  |   27 +-
 lldb/tools/lldb-test/lldb-test.cpp                 |    3 +
 llvm/lib/CodeGen/OptimizePHIs.cpp                  |   17 +-
 llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp   |    2 +
 llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp    |    4 +
 llvm/lib/Target/X86/X86ISelLowering.cpp            |   16 +-
 .../Instrumentation/AddressSanitizer.cpp           |   10 +-
 .../Transforms/Instrumentation/InstrProfiling.cpp  |    1 +
 llvm/test/CodeGen/AArch64/arm64-neon-copy.ll       |  763 +++++++++---
 llvm/test/CodeGen/PowerPC/ppc64-P9-setb.ll         | 1302 ++++++++++++++++++++
 llvm/test/CodeGen/SystemZ/knownbits.ll             |   19 +-
 llvm/test/CodeGen/X86/bitcast-and-setcc-128.ll     |  106 +-
 llvm/test/CodeGen/X86/bitcast-and-setcc-256.ll     |   20 +-
 llvm/test/CodeGen/X86/bitcast-setcc-128.ll         |   44 +-
 llvm/test/CodeGen/X86/bitcast-setcc-256.ll         |   57 +-
 llvm/test/CodeGen/X86/combine-sdiv.ll              |  323 +++--
 .../CodeGen/X86/copysign-constant-magnitude.ll     |   14 +-
 llvm/test/CodeGen/X86/fp128-cast.ll                |    2 -
 llvm/test/CodeGen/X86/fshl.ll                      |   64 +-
 llvm/test/CodeGen/X86/fshr.ll                      |   58 +-
 llvm/test/CodeGen/X86/known-bits-vector.ll         |   10 +-
 llvm/test/CodeGen/X86/known-signbits-vector.ll     |   20 -
 llvm/test/CodeGen/X86/madd.ll                      |    6 +-
 llvm/test/CodeGen/X86/movmsk-cmp.ll                |   93 +-
 llvm/test/CodeGen/X86/opt_phis2.mir                |   72 ++
 llvm/test/CodeGen/X86/packss.ll                    |   47 +-
 llvm/test/CodeGen/X86/psubus.ll                    |   44 +-
 llvm/test/CodeGen/X86/sad.ll                       |    4 +-
 llvm/test/CodeGen/X86/sat-add.ll                   |   14 +-
 llvm/test/CodeGen/X86/vec_minmax_sint.ll           |  104 +-
 llvm/test/CodeGen/X86/vec_minmax_uint.ll           |  104 +-
 llvm/test/CodeGen/X86/vector-reduce-smax-widen.ll  |  147 +--
 llvm/test/CodeGen/X86/vector-reduce-smax.ll        |  168 ++-
 llvm/test/CodeGen/X86/vector-reduce-smin-widen.ll  |  105 +-
 llvm/test/CodeGen/X86/vector-reduce-smin.ll        |  126 +-
 llvm/test/CodeGen/X86/vector-reduce-umax-widen.ll  |  147 +--
 llvm/test/CodeGen/X86/vector-reduce-umax.ll        |  180 ++-
 llvm/test/CodeGen/X86/vector-reduce-umin-widen.ll  |  105 +-
 llvm/test/CodeGen/X86/vector-reduce-umin.ll        |  126 +-
 llvm/test/CodeGen/X86/vector-trunc-packus-widen.ll |  578 ++++-----
 llvm/test/CodeGen/X86/vector-trunc-packus.ll       |  548 ++++----
 llvm/test/CodeGen/X86/vector-trunc-ssat-widen.ll   |  516 ++++----
 llvm/test/CodeGen/X86/vector-trunc-ssat.ll         |  538 ++++----
 llvm/test/CodeGen/X86/vector-trunc-usat-widen.ll   |  246 ++--
 llvm/test/CodeGen/X86/vector-trunc-usat.ll         |  246 ++--
 llvm/test/CodeGen/X86/zext-logicop-shift-load.ll   |   68 +-
 llvm/test/MC/Mips/cprestore-noreorder-noat.s       |    2 +-
 .../Transforms/InstSimplify/saturating-add-sub.ll  |  165 +++
 openmp/runtime/src/kmp_lock.cpp                    |    2 +-
 openmp/runtime/src/kmp_lock.h                      |   17 +-
 openmp/runtime/src/kmp_tasking.cpp                 |    2 +
 openmp/runtime/test/api/omp_alloc.c                |    3 +
 openmp/runtime/test/lit.cfg                        |    9 +
 openmp/runtime/test/lit.site.cfg.in                |    1 +
 .../test/ompt/misc/control_tool_no_ompt_support.c  |    3 +
 .../runtime/test/tasking/bug_nested_proxy_task.c   |    1 +
 .../test/tasking/bug_proxy_task_dep_waiting.c      |    1 +
 .../test/tasking/kmp_task_reduction_nest.cpp       |    1 +
 openmp/runtime/test/tasking/kmp_taskloop.c         |    1 +
 openmp/runtime/test/tasking/omp_task_priority.c    |    1 +
 .../runtime/test/tasking/omp_taskloop_grainsize.c  |    1 +
 .../runtime/test/tasking/omp_taskloop_num_tasks.c  |    1 +
 .../test/worksharing/for/kmp_doacross_check.c      |    1 +
 .../test/worksharing/for/kmp_sch_simd_guided.c     |    1 +
 .../worksharing/for/kmp_sch_simd_runtime_api.c     |    1 +
 .../worksharing/for/kmp_sch_simd_runtime_guided.c  |    1 +
 .../worksharing/for/kmp_sch_simd_runtime_static.c  |    1 +
 openmp/runtime/test/worksharing/for/omp_doacross.c |    1 +
 229 files changed, 6314 insertions(+), 4196 deletions(-)
 rename clang/{lib/StaticAnalyzer/Checkers/ClangSACheckers.h => include/clang/Stati [...]
 delete mode 100644 clang/include/clang/StaticAnalyzer/Checkers/ClangCheckers.h
 rename clang/include/clang/StaticAnalyzer/{Core => Frontend}/CheckerRegistry.h (92%)
 delete mode 100644 clang/lib/StaticAnalyzer/Checkers/ClangCheckers.cpp
 rename clang/lib/StaticAnalyzer/{Core => Frontend}/CheckerRegistry.cpp (50%)
 create mode 100644 clang/test/CodeGenCXX/dllexport-missing-key.cpp
 create mode 100755 libcxx/utils/docker/scripts/docker_start_buildbots.sh
 create mode 100644 lldb/docs/lldb-platform-packets.txt
 create mode 100644 lldb/lit/Modules/ELF/section-addresses.yaml
 create mode 100644 lldb/lit/Modules/ELF/section-permissions.yaml
 create mode 100644 lldb/lit/Modules/ELF/section-types-edgecases.yaml
 create mode 100644 llvm/test/CodeGen/PowerPC/ppc64-P9-setb.ll
 create mode 100644 llvm/test/CodeGen/X86/opt_phis2.mir
-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

[Tcwg-commits] [toolchain/ci/llvm-monorepo] branch linaro-local/ci/tcwg_kernel/llvm-master-aarch64-lts-allmodconfig updated (526a5a93b96 -> 8a96b47e9c1)