[Tcwg-commits] [toolchain/ci/llvm-monorepo] branch linaro-local/ci/tcwg_kernel/llvm-master-aarch64-lts-allnoconfig updated (a2e822e3ac43 -> 4dfc227da4b1)

19 Oct 2018


      This is an automated email from the git hooks/post-receive script.
tcwg-buildslave pushed a change to branch linaro-local/ci/tcwg_kernel/llvm-master-aarch64-lts-allnoconfig
in repository toolchain/ci/llvm-monorepo.
from  a2e822e3ac43 [X86] Support for the mno-tls-direct-seg-refs flag
      adds  7dc7c1785862 Fix warning about unused variable [NFC]
      adds  c0001a617807 Add a emitUnaryFloatFnCall version that fetches the functi [...]
      adds  d83c743488e2 [TI removal] Remove TerminatorInst references from bindings.
      adds  59abe0dc50f0 [TI removal] Remove discussion of `TerminatorInst` from th [...]
      adds  917dbbc86c03 [TI removal] Generically discuss terminators rather than u [...]
      adds  e949b8cb2b30 [Windows] Fix threads comparison on Windows
      adds  d292be3fc756 [TI removal] Test predicate rather than casting to detect  [...]
      adds  968db1060ac2 [llvm-exegesis] Fix off by one error
      adds  e8d7f368db5e [Support] json::Value construction from std::vector<T> and [...]
      adds  c587139df9a4 [clang-tidy] Ignore a case where the fix of make_unique ch [...]
      adds  b66ffc190310 [DA] DivergenceAnalysis for unstructured, reducible CFGs
      adds  bf60542e9901 [clangd] Encode Line/Column as a 32-bits integer.
      adds  455912d5b328 [clangd] Names that are not spelled in source code are reserved.
      adds  1f629ceb65ad [clangd] Lay JSONRPCDispatcher to rest.
      adds  849c9dca0943 DivergenceAnalysisTest: fix use of uninitialized memory
      adds  0dffada55523 Add support for -mno-tls-direct-seg-refs to Clang
      adds  b34f419e677a [OPENMP] Move OMPClausePrinter to OpenMPClause.h/OpenMPCla [...]
      adds  6e4b9cd1a298 [clangd] Enforce rules around "initialize" request, and cr [...]
      adds  5c511ede4b64 [X86][Tests] Make sure tls-direct-seg-refs tests only run  [...]
      adds  cd92386edbb3 [LV] Fold tail by masking to vectorize loops of arbitrary  [...]
      adds  4f50e9913d50 [lldbsuite] Mark the TestScriptedResolver tests as XFAIL o [...]
      adds  946c236df48a [clangd] Clear the semantic of RefSlab::size.
      adds  11bac62ed839 [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView
      adds  c96c4ad6864e [PPC64] Fix offset checks on rel24 call relocations.
      adds  800526b67dc6 [Pipeliner] copyToPhi DAG Mutation to improve scheduling.
      adds  5202e75e04ea Add language standard aliases for -std=c18, -std=gnu18, an [...]
      adds  2815a36ba60d Add check-clang-python to the Clang tests directory in IDEs; NFC.
      adds  0b874ebf5dbb [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.
      adds  490d3b2919b2 Revert r344693 ("[ARM] bottom-top mul support in ARMParallelDSP")
      adds  07d7f2513b23 Make Function::getInstructionCount const
      adds  82ca52af702b [clang-tidy] Add new 'readability-uppercase-literal-suffix [...]
      adds  65731b8b2cc8 Support of hurd in llvm-shlib
      adds  6d97c0a4967f [clang-tidy] Non-private member variables in classes (MISR [...]
      adds  bd8354a7c375 [clang-tidy] readability-uppercase-literal-suffix: specify [...]
      adds  8e88255c356d [Diagnostics] Check for integer overflow in array size exp [...]
      adds  31fb50ed7602 [clang-tidy] readability-uppercase-literal-suffix: specify [...]
      adds  371b2eb8e1e6 [Diagnostics] Add missing expected warning to test file
      adds  67bc1c33b65a [Test] Fix test file for C++98 mode
      adds  574429afa55e [ORC] Add a createJITDylib method to LLJIT.
      adds  56f3e33489a3 [TI removal] Update the C API for the move away from `Term [...]
      adds  e873dc7bc638 [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics
      adds  8ce95bb4c955 [COFF, ARM64] Enable unit test arm64-microsoft-status-reg. [...]
      adds  8f152f4a3697 [TI removal] Switch some newly added code over to use `Ins [...]
      adds  451feb668ed6 [TI removal] Remove `TerminatorInst` from the IR type system!
      adds  4dfc227da4b1 [CodeGen] Fix for PR39094.
No new revisions were added by this update.
Summary of changes:
 .../clang-tidy/cert/CERTTidyModule.cpp             |  10 +
 clang-tools-extra/clang-tidy/cert/CMakeLists.txt   |   1 +
 .../CppCoreGuidelinesTidyModule.cpp                |  13 +
 .../clang-tidy/hicpp/HICPPTidyModule.cpp           |   3 +
 clang-tools-extra/clang-tidy/misc/CMakeLists.txt   |   1 +
 .../clang-tidy/misc/MiscTidyModule.cpp             |   3 +
 .../NonPrivateMemberVariablesInClassesCheck.cpp    |  93 ++++
 .../misc/NonPrivateMemberVariablesInClassesCheck.h |  46 ++
 .../clang-tidy/modernize/MakeSmartPtrCheck.cpp     |   9 +
 .../clang-tidy/readability/CMakeLists.txt          |   1 +
 .../readability/IdentifierNamingCheck.cpp          |  21 +-
 .../readability/ReadabilityTidyModule.cpp          |   3 +
 .../readability/UppercaseLiteralSuffixCheck.cpp    | 236 +++++++++
 .../readability/UppercaseLiteralSuffixCheck.h      |  44 ++
 clang-tools-extra/clang-tidy/utils/ASTUtils.cpp    |  26 +
 clang-tools-extra/clang-tidy/utils/ASTUtils.h      |  12 +
 clang-tools-extra/clangd/AST.cpp                   |  40 +-
 clang-tools-extra/clangd/AST.h                     |   5 +
 clang-tools-extra/clangd/CMakeLists.txt            |   2 -
 clang-tools-extra/clangd/ClangdLSPServer.cpp       | 531 ++++++++++++++-------
 clang-tools-extra/clangd/ClangdLSPServer.h         |  92 ++--
 clang-tools-extra/clangd/ClangdServer.cpp          |   2 +-
 clang-tools-extra/clangd/ClangdServer.h            |   2 +-
 clang-tools-extra/clangd/CodeComplete.cpp          |   2 +-
 clang-tools-extra/clangd/FindSymbols.cpp           |   8 +-
 clang-tools-extra/clangd/JSONRPCDispatcher.cpp     | 208 --------
 clang-tools-extra/clangd/JSONRPCDispatcher.h       |  95 ----
 clang-tools-extra/clangd/ProtocolHandlers.cpp      |  80 ----
 clang-tools-extra/clangd/ProtocolHandlers.h        |  67 ---
 clang-tools-extra/clangd/Quality.cpp               |   5 +
 clang-tools-extra/clangd/Quality.h                 |   1 +
 clang-tools-extra/clangd/TUScheduler.cpp           |   9 +-
 clang-tools-extra/clangd/XRefs.cpp                 |   8 +-
 clang-tools-extra/clangd/index/Background.cpp      |   4 +-
 clang-tools-extra/clangd/index/FileIndex.cpp       |   4 +-
 clang-tools-extra/clangd/index/Index.cpp           |  28 +-
 clang-tools-extra/clangd/index/Index.h             |  34 +-
 clang-tools-extra/clangd/index/Serialization.cpp   |  18 +-
 clang-tools-extra/clangd/index/SymbolCollector.cpp |   6 +-
 .../clangd/index/YAMLSerialization.cpp             |  37 +-
 clang-tools-extra/clangd/tool/ClangdMain.cpp       |   3 +-
 clang-tools-extra/docs/ReleaseNotes.rst            |  31 ++
 .../docs/clang-tidy/checks/cert-dcl16-c.rst        |   9 +
 ...nes-non-private-member-variables-in-classes.rst |  11 +
 .../checks/hicpp-uppercase-literal-suffix.rst      |   9 +
 clang-tools-extra/docs/clang-tidy/checks/list.rst  |   5 +
 ...isc-non-private-member-variables-in-classes.rst |  26 +
 .../readability-uppercase-literal-suffix.rst       |  42 ++
 .../cert-uppercase-literal-suffix-integer.cpp      | 159 ++++++
 ...isc-non-private-member-variables-in-classes.cpp | 380 +++++++++++++++
 .../test/clang-tidy/modernize-make-unique.cpp      |  13 +-
 ...e-literal-suffix-floating-point-opencl-half.cpp |  30 ++
 ...ity-uppercase-literal-suffix-floating-point.cpp | 198 ++++++++
 ...e-literal-suffix-hexadecimal-floating-point.cpp | 155 ++++++
 ...ppercase-literal-suffix-integer-custom-list.cpp | 130 +++++
 ...lity-uppercase-literal-suffix-integer-macro.cpp |  25 +
 ...ability-uppercase-literal-suffix-integer-ms.cpp |  77 +++
 ...eadability-uppercase-literal-suffix-integer.cpp | 245 ++++++++++
 .../readability-uppercase-literal-suffix.h         |  16 +
 .../test/clangd/crash-non-added-files.test         |   2 -
 .../clangd/delimited-input-comment-at-the-end.test |   3 +-
 .../test/clangd/exit-with-shutdown.test            |   2 +
 .../test/clangd/exit-without-shutdown.test         |   2 +
 clang-tools-extra/test/clangd/fixits-command.test  |   2 +-
 .../test/clangd/initialize-sequence.test           |  21 +
 clang-tools-extra/test/clangd/rename.test          |   2 +-
 .../test/clangd/spaces-in-delimited-input.test     |   2 +-
 .../unittests/clangd/FileIndexTests.cpp            |   8 +-
 clang-tools-extra/unittests/clangd/IndexTests.cpp  |  23 +-
 .../unittests/clangd/QualityTests.cpp              |  21 +
 .../unittests/clangd/SymbolCollectorTests.cpp      |  48 +-
 clang/bindings/python/tests/CMakeLists.txt         |   1 +
 clang/include/clang/AST/Expr.h                     |   9 +-
 clang/include/clang/AST/OpenMPClause.h             |  16 +
 clang/include/clang/Basic/BuiltinsAArch64.def      |   2 +
 clang/include/clang/Driver/Options.td              |   4 +
 clang/include/clang/Frontend/CodeGenOptions.def    |   2 +
 clang/include/clang/Frontend/LangStandards.def     |   3 +
 clang/lib/AST/ExprConstant.cpp                     |  13 +
 clang/lib/AST/OpenMPClause.cpp                     | 432 +++++++++++++++++
 clang/lib/AST/StmtPrinter.cpp                      | 451 -----------------
 clang/lib/CodeGen/CGBuiltin.cpp                    |  37 ++
 clang/lib/CodeGen/CGCall.cpp                       |   2 +
 clang/lib/CodeGen/CGLoopInfo.cpp                   |   9 +-
 clang/lib/Driver/ToolChains/Clang.cpp              |   4 +
 clang/lib/Frontend/CompilerInvocation.cpp          |   1 +
 clang/lib/Headers/intrin.h                         |   2 +
 clang/lib/Sema/SemaChecking.cpp                    |   7 +
 clang/lib/Sema/SemaExpr.cpp                        |   2 +-
 clang/test/CodeGen/arm64-microsoft-status-reg.cpp  | 119 +++++
 clang/test/CodeGen/indirect-tls-seg-refs.c         |  10 +
 clang/test/Driver/indirect-tls-seg-refs.c          |   8 +
 clang/test/Driver/unknown-std.c                    |   4 +-
 clang/test/Preprocessor/c17.c                      |   1 +
 clang/test/Sema/builtins-microsoft-arm64.c         |   6 +
 clang/test/Sema/integer-overflow.c                 |   3 +
 clang/test/SemaCXX/enum.cpp                        |   2 +
 compiler-rt/cmake/Modules/AddCompilerRT.cmake      |   2 +-
 lld/ELF/Arch/PPC64.cpp                             |   3 +-
 lld/test/ELF/ppc64-call-reach.s                    |  66 +++
 lldb/include/lldb/Host/HostNativeThreadBase.h      |   1 +
 lldb/include/lldb/Host/windows/HostThreadWindows.h |   1 +
 .../scripted_bkpt/TestScriptedResolver.py          |   4 +
 lldb/source/Host/common/HostNativeThreadBase.cpp   |   4 +
 lldb/source/Host/common/HostThread.cpp             |   2 +-
 lldb/source/Host/windows/HostThreadWindows.cpp     |   4 +
 .../Plugins/SymbolFile/NativePDB/CMakeLists.txt    |   1 +
 llvm/bindings/go/llvm/ir.go                        |   1 -
 llvm/bindings/ocaml/llvm/llvm.mli                  |   6 +-
 llvm/docs/BranchWeightMetadata.rst                 |   8 +-
 llvm/docs/ProgrammersManual.rst                    |  11 +-
 llvm/include/llvm-c/Core.h                         |  40 +-
 llvm/include/llvm/ADT/PostOrderIterator.h          |   3 +
 llvm/include/llvm/Analysis/DivergenceAnalysis.h    | 178 +++++++
 .../include/llvm/Analysis/SyncDependenceAnalysis.h |  86 ++++
 llvm/include/llvm/Analysis/VectorUtils.h           |  21 +-
 llvm/include/llvm/CodeGen/SlotIndexes.h            |  10 +-
 llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h      |   5 +
 llvm/include/llvm/IR/Function.h                    |   2 +-
 llvm/include/llvm/IR/InstrTypes.h                  |  28 --
 llvm/include/llvm/IR/Instructions.h                |  34 +-
 llvm/include/llvm/Support/JSON.h                   |   4 +
 llvm/include/llvm/Transforms/Utils/BuildLibCalls.h |  13 +
 .../Vectorize/LoopVectorizationLegality.h          |   4 +
 llvm/lib/Analysis/CMakeLists.txt                   |   2 +
 llvm/lib/Analysis/DivergenceAnalysis.cpp           | 424 ++++++++++++++++
 llvm/lib/Analysis/SyncDependenceAnalysis.cpp       | 380 +++++++++++++++
 llvm/lib/CodeGen/MachinePipeliner.cpp              |  96 +++-
 llvm/lib/IR/Core.cpp                               |  11 +-
 llvm/lib/IR/Function.cpp                           |   4 +-
 llvm/lib/IR/Instructions.cpp                       | 153 +++---
 llvm/lib/Target/ARM/ARMParallelDSP.cpp             | 221 ++-------
 .../InstCombine/InstCombineMulDivRem.cpp           |   3 +-
 llvm/lib/Transforms/Utils/BuildLibCalls.cpp        |  47 +-
 llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp     |  26 +-
 .../Vectorize/LoopVectorizationLegality.cpp        |  55 +++
 llvm/lib/Transforms/Vectorize/LoopVectorize.cpp    | 126 +++--
 llvm/lib/Transforms/Vectorize/VPlan.cpp            |  24 +-
 llvm/lib/Transforms/Vectorize/VPlan.h              |  21 +-
 .../ARM/ParallelDSP/top-bottom-multi-use.ll        |  74 ---
 .../CodeGen/ARM/ParallelDSP/top-bottom-neg-vec.ll  |  98 ----
 .../test/CodeGen/ARM/ParallelDSP/top-bottom-neg.ll | 210 --------
 .../CodeGen/ARM/ParallelDSP/top-bottom-order.ll    |  54 ---
 llvm/test/CodeGen/ARM/ParallelDSP/top-bottom.ll    | 252 ----------
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad0.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad1.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad10.ll |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad11.ll |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad12.ll |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad2.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad3.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad4.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad5.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad6.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad7.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad8.ll  |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad9.ll  |   0
 .../test/CodeGen/ARM/{ParallelDSP => }/smladx-1.ll |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlald0.ll |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlald1.ll |   0
 llvm/test/CodeGen/ARM/{ParallelDSP => }/smlald2.ll |   0
 .../CodeGen/ARM/{ParallelDSP => }/smlaldx-1.ll     |   0
 .../CodeGen/ARM/{ParallelDSP => }/smlaldx-2.ll     |   0
 llvm/test/CodeGen/Hexagon/swp-copytophi-dag.ll     |  72 +++
 llvm/test/Transforms/LoopVectorize/X86/optsize.ll  |  85 +++-
 .../Transforms/LoopVectorize/X86/small-size.ll     | 172 ++++++-
 .../LoopVectorize/X86/vect.omp.force.small-tc.ll   |  47 +-
 llvm/tools/llvm-exegesis/llvm-exegesis.cpp         |   2 +-
 llvm/tools/llvm-shlib/CMakeLists.txt               |   1 +
 llvm/unittests/Analysis/CMakeLists.txt             |   1 +
 llvm/unittests/Analysis/DivergenceAnalysisTest.cpp | 431 +++++++++++++++++
 llvm/unittests/Support/JSONTest.cpp                |   2 +
 polly/lib/Analysis/ScopBuilder.cpp                 |   2 +-
 173 files changed, 5925 insertions(+), 2373 deletions(-)
 create mode 100644 clang-tools-extra/clang-tidy/misc/NonPrivateMemberVariablesInCl [...]
 create mode 100644 clang-tools-extra/clang-tidy/misc/NonPrivateMemberVariablesInCl [...]
 create mode 100644 clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffix [...]
 create mode 100644 clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.h
 delete mode 100644 clang-tools-extra/clangd/JSONRPCDispatcher.cpp
 delete mode 100644 clang-tools-extra/clangd/JSONRPCDispatcher.h
 delete mode 100644 clang-tools-extra/clangd/ProtocolHandlers.cpp
 delete mode 100644 clang-tools-extra/clangd/ProtocolHandlers.h
 create mode 100644 clang-tools-extra/docs/clang-tidy/checks/cert-dcl16-c.rst
 create mode 100644 clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-non- [...]
 create mode 100644 clang-tools-extra/docs/clang-tidy/checks/hicpp-uppercase-litera [...]
 create mode 100644 clang-tools-extra/docs/clang-tidy/checks/misc-non-private-membe [...]
 create mode 100644 clang-tools-extra/docs/clang-tidy/checks/readability-uppercase- [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/cert-uppercase-literal-suffix [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/misc-non-private-member-varia [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clang-tidy/readability-uppercase-literal [...]
 create mode 100644 clang-tools-extra/test/clangd/initialize-sequence.test
 create mode 100644 clang/test/CodeGen/arm64-microsoft-status-reg.cpp
 create mode 100644 clang/test/CodeGen/indirect-tls-seg-refs.c
 create mode 100644 clang/test/Driver/indirect-tls-seg-refs.c
 create mode 100644 lld/test/ELF/ppc64-call-reach.s
 create mode 100644 llvm/include/llvm/Analysis/DivergenceAnalysis.h
 create mode 100644 llvm/include/llvm/Analysis/SyncDependenceAnalysis.h
 create mode 100644 llvm/lib/Analysis/DivergenceAnalysis.cpp
 create mode 100644 llvm/lib/Analysis/SyncDependenceAnalysis.cpp
 delete mode 100644 llvm/test/CodeGen/ARM/ParallelDSP/top-bottom-multi-use.ll
 delete mode 100644 llvm/test/CodeGen/ARM/ParallelDSP/top-bottom-neg-vec.ll
 delete mode 100644 llvm/test/CodeGen/ARM/ParallelDSP/top-bottom-neg.ll
 delete mode 100644 llvm/test/CodeGen/ARM/ParallelDSP/top-bottom-order.ll
 delete mode 100644 llvm/test/CodeGen/ARM/ParallelDSP/top-bottom.ll
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad0.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad1.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad10.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad11.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad12.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad2.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad3.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad4.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad5.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad6.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad7.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad8.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlad9.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smladx-1.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlald0.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlald1.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlald2.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlaldx-1.ll (100%)
 rename llvm/test/CodeGen/ARM/{ParallelDSP => }/smlaldx-2.ll (100%)
 create mode 100644 llvm/test/CodeGen/Hexagon/swp-copytophi-dag.ll
 create mode 100644 llvm/unittests/Analysis/DivergenceAnalysisTest.cpp
-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

[Tcwg-commits] [toolchain/ci/llvm-monorepo] branch linaro-local/ci/tcwg_kernel/llvm-master-aarch64-lts-allnoconfig updated (a2e822e3ac43 -> 4dfc227da4b1)