Hi All I am new to both luajit and ARM. I have made the changes for the functions asm_tbar, asm_cnew and emit_isk13 for arm64 based on my limited understanding. I have attached the diffs. Please review the diffs and share any suggestions you have. The changes are mostly based on arm32 code for corresponding functions.
The diffs are corresponding to test case in the attached email. Thanks Abhishek Dikshit
Hey,
I didn't really take my time to review the patch, but I can see that you implemented a function for counting leading zeros, which isn't really necessary, because theres a builtin for that (__builtin_clzll).
Also, we are using GitHub's pull request system to submit changes, so that would be a better way show us what you've done.
GitHub repository: https://github.com/cbaylis/luajit-aarch64/tree/aarch64-v2.1-new
Regards, Stefan
On Tue, 2 Aug 2016 22:53:34 +0000 "Dikshit, Abhishek" Abhishek.Dikshit@cavium.com wrote:
Hi All I am new to both luajit and ARM. I have made the changes for the functions asm_tbar, asm_cnew and emit_isk13 for arm64 based on my limited understanding. I have attached the diffs. Please review the diffs and share any suggestions you have. The changes are mostly based on arm32 code for corresponding functions.
The diffs are corresponding to test case in the attached email. Thanks Abhishek Dikshit
Hi
I've had a brief read through, and I've noticed the following: . please remove the spurious Makefile changes . there are several unrelated changes here. Please make them into separate patches . if you look at asm_cnew in lj_asm_x86.h, you can see that there are significant differences for GC_64. Does your implementation match these? . the emit_isk13 changes need to be a separate patch, and make sure that the VIXL licence conditions are followed
It would be easier to review the changes if you submitted a github pull request. It's fine to add a comment to say that it's only for review and/or post a link on the list to ask for comments.
Thanks Charles
On 2 August 2016 at 23:53, Dikshit, Abhishek Abhishek.Dikshit@cavium.com wrote:
Hi All
I am new to both luajit and ARM. I have made the changes for the functions asm_tbar, asm_cnew and emit_isk13 for arm64 based on my limited understanding. I have attached the diffs. Please review the diffs and share any suggestions you have. The changes are mostly based on arm32 code for corresponding functions.
The diffs are corresponding to test case in the attached email.
Thanks
Abhishek Dikshit
---------- Forwarded message ---------- From: Ryan Arnold ryan.arnold@linaro.org To: "Dikshit, Abhishek" Abhishek.Dikshit@cavium.com Cc: "luajit@lists.linaro.org" luajit@lists.linaro.org Date: Wed, 20 Jul 2016 18:34:35 +0000 Subject: Re: Looking forward to contribute. As far as I've heard the FFI IR work has not currently started. Here's the minimal testcase that Charles identified that will expose the FFI IR: local ffi = require("ffi") local typ = ffi.typeof("uint64_t") x=0LL for i=1,100 do x=ffi.cast(typ, i) end print (x
On Wed, Jul 20, 2016 at 1:30 PM, Dikshit, Abhishek < Abhishek.Dikshit@cavium.com> wrote:
Hi All,
I am looking forward to contribute in development of LuaJIT for ARM64.
Please feel free to assign work to me even if it is a minor bug fix.
Thanks
Abhishek Dikshit
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
--
Ryan S. Arnold | Linaro Toolchain Engineering Manager
ryan.arnold@linaro.org | ryanarn on #linaro-tcwg @ freenode.irc.net
T: +1-612-424-1861 <+16124241861>
luajit mailing list luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
Link for review. https://github.com/adikshit/luajit-aarch64/tree/aarch64-v2.1-new
I have created separate patch for isk13 and asm_tbar with asm_cnew.
Abhishek Dikshit
From: Charles Baylis [mailto:charles.baylis@linaro.org] Sent: Wednesday, August 03, 2016 9:46 AM To: Dikshit, Abhishek Cc: luajit@lists.linaro.org; Pinski, Andrew; Jasty, Ananth Subject: Re: asm_tbar, asm_cnew and emit_isk13 changes for review
Hi I've had a brief read through, and I've noticed the following: . please remove the spurious Makefile changes . there are several unrelated changes here. Please make them into separate patches . if you look at asm_cnew in lj_asm_x86.h, you can see that there are significant differences for GC_64. Does your implementation match these? . the emit_isk13 changes need to be a separate patch, and make sure that the VIXL licence conditions are followed It would be easier to review the changes if you submitted a github pull request. It's fine to add a comment to say that it's only for review and/or post a link on the list to ask for comments. Thanks Charles
On 2 August 2016 at 23:53, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote: Hi All I am new to both luajit and ARM. I have made the changes for the functions asm_tbar, asm_cnew and emit_isk13 for arm64 based on my limited understanding. I have attached the diffs. Please review the diffs and share any suggestions you have. The changes are mostly based on arm32 code for corresponding functions.
The diffs are corresponding to test case in the attached email. Thanks Abhishek Dikshit
---------- Forwarded message ---------- From: Ryan Arnold <ryan.arnold@linaro.orgmailto:ryan.arnold@linaro.org> To: "Dikshit, Abhishek" <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> Cc: "luajit@lists.linaro.orgmailto:luajit@lists.linaro.org" <luajit@lists.linaro.orgmailto:luajit@lists.linaro.org> Date: Wed, 20 Jul 2016 18:34:35 +0000 Subject: Re: Looking forward to contribute. As far as I've heard the FFI IR work has not currently started. Here's the minimal testcase that Charles identified that will expose the FFI IR: local ffi = require("ffi") local typ = ffi.typeof("uint64_t") x=0LL for i=1,100 do x=ffi.cast(typ, i) end print (x
On Wed, Jul 20, 2016 at 1:30 PM, Dikshit, Abhishek <Abhishek.Dikshit@cavium.commailto:Abhishek.Dikshit@cavium.com> wrote: Hi All, I am looking forward to contribute in development of LuaJIT for ARM64. Please feel free to assign work to me even if it is a minor bug fix.
Thanks Abhishek Dikshit
_______________________________________________ luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
--
[Image removed by sender.]
Ryan S. Arnold | Linaro Toolchain Engineering Manager
ryan.arnold@linaro.orgmailto:ryan.arnold@linaro.org | ryanarn on #linaro-tcwg @ freenode.irc.nethttp://freenode.irc.net/
T: +1-612-424-1861tel:+16124241861
_______________________________________________ luajit mailing list luajit@lists.linaro.orgmailto:luajit@lists.linaro.org https://lists.linaro.org/mailman/listinfo/luajit
-
Charles Baylis -
Dikshit, Abhishek -
Stefan Pejic