Re: [PATCH 4.14 305/315] arm64: dts: qcom: msm8994-angler: Fix gpio-reserved-ranges 85-88
On Mon, 19 Jul 2021 at 21:01, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
From: Petr Vorel petr.vorel@gmail.com
[ Upstream commit f890f89d9a80fffbfa7ca791b78927e5b8aba869 ]
Reserve GPIO pins 85-88 as these aren't meant to be accessible from the application CPUs (causes reboot). Yet another fix similar to 9134586715e3, 5f8d3ab136d0, which is needed to allow angler to boot after 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").
Fixes: feeaf56ac78d ("arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support")
Signed-off-by: Petr Vorel petr.vorel@gmail.com Reviewed-by: Konrad Dybcio konrad.dybcio@somainline.org Link: https://lore.kernel.org/r/20210415193913.1836153-1-petr.vorel@gmail.com Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org Signed-off-by: Sasha Levin sashal@kernel.org
arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts index dfa08f513dc4..e5850c4d3334 100644 --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts @@ -38,3 +38,7 @@ }; }; };
+&tlmm {
gpio-reserved-ranges = <85 4>;+};
Following build errors noticed on arm64 architecture on on stable-rc linux-4.19.y stable-rc linux-4.14.y
make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc' 'HOSTCC=sccache gcc' Error: /builds/linux/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts:42.1-6 Label or path tlmm not found FATAL ERROR: Syntax error parsing input tree make[3]: *** [scripts/Makefile.lib:294: arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dtb] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/arm64/boot/dts/qcom] Error 2
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
reference build link, build: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/ config: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
steps to reproduce: --------------------- # TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets. # # TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system. # # To install tuxmake on your system globally: # sudo pip3 install -U tuxmake # # See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11 --kconfig defconfig --kconfig-add https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
-- Linaro LKFT https://lkft.linaro.org
On Mon, Jul 19, 2021 at 09:17:17PM +0530, Naresh Kamboju wrote:
On Mon, 19 Jul 2021 at 21:01, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
From: Petr Vorel petr.vorel@gmail.com
[ Upstream commit f890f89d9a80fffbfa7ca791b78927e5b8aba869 ]
Reserve GPIO pins 85-88 as these aren't meant to be accessible from the application CPUs (causes reboot). Yet another fix similar to 9134586715e3, 5f8d3ab136d0, which is needed to allow angler to boot after 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").
Fixes: feeaf56ac78d ("arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support")
Signed-off-by: Petr Vorel petr.vorel@gmail.com Reviewed-by: Konrad Dybcio konrad.dybcio@somainline.org Link: https://lore.kernel.org/r/20210415193913.1836153-1-petr.vorel@gmail.com Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org Signed-off-by: Sasha Levin sashal@kernel.org
arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts index dfa08f513dc4..e5850c4d3334 100644 --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts @@ -38,3 +38,7 @@ }; }; };
+&tlmm {
gpio-reserved-ranges = <85 4>;+};
Following build errors noticed on arm64 architecture on on stable-rc linux-4.19.y stable-rc linux-4.14.y
make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc' 'HOSTCC=sccache gcc' Error: /builds/linux/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts:42.1-6 Label or path tlmm not found FATAL ERROR: Syntax error parsing input tree make[3]: *** [scripts/Makefile.lib:294: arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dtb] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/arm64/boot/dts/qcom] Error 2
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
reference build link, build: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/ config: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
steps to reproduce:
# TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets. # # TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system. # # To install tuxmake on your system globally: # sudo pip3 install -U tuxmake # # See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11 --kconfig defconfig --kconfig-add https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
Now dropped from everywhere, thanks.
greg k-h
On Mon, Jul 19, 2021 at 09:17:17PM +0530, Naresh Kamboju wrote:
On Mon, 19 Jul 2021 at 21:01, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
From: Petr Vorel petr.vorel@gmail.com
[ Upstream commit f890f89d9a80fffbfa7ca791b78927e5b8aba869 ]
Reserve GPIO pins 85-88 as these aren't meant to be accessible from the application CPUs (causes reboot). Yet another fix similar to 9134586715e3, 5f8d3ab136d0, which is needed to allow angler to boot after 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").
Fixes: feeaf56ac78d ("arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support")
Signed-off-by: Petr Vorel petr.vorel@gmail.com Reviewed-by: Konrad Dybcio konrad.dybcio@somainline.org Link: https://lore.kernel.org/r/20210415193913.1836153-1-petr.vorel@gmail.com Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org Signed-off-by: Sasha Levin sashal@kernel.org
arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts index dfa08f513dc4..e5850c4d3334 100644 --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts @@ -38,3 +38,7 @@ }; }; };
+&tlmm {
gpio-reserved-ranges = <85 4>;+};
Following build errors noticed on arm64 architecture on on stable-rc linux-4.19.y stable-rc linux-4.14.y
make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc' 'HOSTCC=sccache gcc' Error: /builds/linux/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts:42.1-6 Label or path tlmm not found FATAL ERROR: Syntax error parsing input tree make[3]: *** [scripts/Makefile.lib:294: arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dtb] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/arm64/boot/dts/qcom] Error 2
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
reference build link, build: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/ config: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
steps to reproduce:
# TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets.
# TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system.
# To install tuxmake on your system globally: # sudo pip3 install -U tuxmake
# See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11 --kconfig defconfig --kconfig-add https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
Now dropped from everywhere, thanks.
It should be working since v5.9, thus applicable to linux-5.10.y (longterm) and the two newer stable branches. As I described it before, I'd drop it from linux-4.19.y and linux-4.14.y (unless 3edfb7bd76bd from 4.20 is planning to be backported to it, which I don't think so).
The only branch which needs to adapt this patch is linux-5.4.y (use msmgpio). I can send a patch for it during this week.
Kind regards, Petr
greg k-h
On Mon, 19 Jul 2021 at 21:01, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
From: Petr Vorel petr.vorel@gmail.com
[ Upstream commit f890f89d9a80fffbfa7ca791b78927e5b8aba869 ]
Reserve GPIO pins 85-88 as these aren't meant to be accessible from the application CPUs (causes reboot). Yet another fix similar to 9134586715e3, 5f8d3ab136d0, which is needed to allow angler to boot after 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").
Fixes: feeaf56ac78d ("arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support")
Signed-off-by: Petr Vorel petr.vorel@gmail.com Reviewed-by: Konrad Dybcio konrad.dybcio@somainline.org Link: https://lore.kernel.org/r/20210415193913.1836153-1-petr.vorel@gmail.com Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org Signed-off-by: Sasha Levin sashal@kernel.org
arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts index dfa08f513dc4..e5850c4d3334 100644 --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts @@ -38,3 +38,7 @@ }; }; };
+&tlmm {
gpio-reserved-ranges = <85 4>;+};
Following build errors noticed on arm64 architecture on on stable-rc linux-4.19.y stable-rc linux-4.14.y
make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc' 'HOSTCC=sccache gcc' Error: /builds/linux/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts:42.1-6 Label or path tlmm not found FATAL ERROR: Syntax error parsing input tree make[3]: *** [scripts/Makefile.lib:294: arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dtb] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/arm64/boot/dts/qcom] Error 2
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Yes, this patch needs modification, because tlmm was added in v5.9 in 7c865b09b0a1 ("arm64: dts: qcom: msm8994: Modernize the DTS style"). Before it was msmgpio, thus substitute to it should fix it. I can verify it and send correct patches, but this problem started since 3edfb7bd76bd (v4.20), thus I'd prefer just skip linux-4.19.y and linux-4.14.y (unless 3edfb7bd76bd is planning to be backported to it, which I don't think so).
Kind regards, Petr
reference build link, build: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/ config: https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
steps to reproduce:
# TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets.
# TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system.
# To install tuxmake on your system globally: # sudo pip3 install -U tuxmake
# See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime podman --target-arch arm64 --toolchain gcc-11 --kconfig defconfig --kconfig-add https://builds.tuxbuild.com/1vXT4jBYUbNdKdLS1wz6gmXPVLM/config
-
Greg Kroah-Hartman -
Naresh Kamboju -
Petr Vorel