On Fri, Oct 23, 2020 at 10:51 AM Linus Torvalds torvalds@linux-foundation.org wrote:
On Fri, Oct 23, 2020 at 10:00 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
[Old patch from yesterday]
After applying your patch on top on linux next tag 20201015 there are two observations,
- i386 build failed. please find build error build
Yes, this was expected. That patch explicitly only works on x86-64, because 32-bit needs the double register handling for 64-bit values (mainly loff_t).
- x86_64 kasan test PASS and the reported error not found.
Ok, good. That confirms that the problem you reported is indeed the register allocation.
The patch I sent an hour ago (the one based on Rasmus' one from yesterday) should fix things too, and - unlike yesterday's - work on 32-bit.
But I'll wait for confirmation (and hopefully a sign-off from Rasmus so that I can give him authorship) before actually committing it.
Linus
My test vm failed to boot since
commit d55564cfc222326e944893eff0c4118353e349ec x86: Make __put_user() generate an out-of-line call
The patch also fixed it.
Thanks! Song