After commit cbc654d18d37 ("bitops: Add __attribute_const__ to generic
ffs()-family implementations"), which allows GCC's value range tracker
to see past ffs(), GCC 8 on ARM thinks that it might be possible that
"ffs(rq) - 8" used here:
v = FIELD_PREP(PCI_EXP_DEVCTL_READRQ, ffs(rq) - 8);
could wrap below 0, leading to a very large value, which would be out of
range for the FIELD_PREP() usage:
drivers/pci/pci.c: In function 'pcie_set_readrq':
include/linux/compiler_types.h:572:38: error: call to '__compiletime_assert_471' declared with attribute error: FIELD_PREP: value too large for the field
...
drivers/pci/pci.c:5896:6: note: in expansion of macro 'FIELD_PREP'
v = FIELD_PREP(PCI_EXP_DEVCTL_READRQ, ffs(rq) - 8);
^~~~~~~~~~
If the result of the ffs() is bounds checked before being used in
FIELD_PREP(), the value tracker seems happy again. :)
Fixes: cbc654d18d37 ("bitops: Add __attribute_const__ to generic ffs()-family implementations")
Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
Closes: https://lore.kernel.org/linux-pci/CA+G9fYuysVr6qT8bjF6f08WLyCJRG7aXAeSd2F7=…
Signed-off-by: Kees Cook <kees(a)kernel.org>
---
Cc: Bjorn Helgaas <bhelgaas(a)google.com>
Cc: Anders Roxell <anders.roxell(a)linaro.org>
Cc: Naresh Kamboju <naresh.kamboju(a)linaro.org>
Cc: lkft-triage(a)lists.linaro.org
Cc: Linux Regressions <regressions(a)lists.linux.dev>
Cc: Arnd Bergmann <arnd(a)arndb.de>
Cc: Dan Carpenter <dan.carpenter(a)linaro.org>
Cc: Ben Copeland <benjamin.copeland(a)linaro.org>
Cc: <lkft-triage(a)lists.linaro.org>
Cc: <linux-pci(a)vger.kernel.org>
Cc: <linux-kernel(a)vger.kernel.org>
---
drivers/pci/pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b0f4d98036cd..005b92e6585e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -5932,6 +5932,7 @@ int pcie_set_readrq(struct pci_dev *dev, int rq)
{
u16 v;
int ret;
+ unsigned int firstbit;
struct pci_host_bridge *bridge = pci_find_host_bridge(dev->bus);
if (rq < 128 || rq > 4096 || !is_power_of_2(rq))
@@ -5949,7 +5950,10 @@ int pcie_set_readrq(struct pci_dev *dev, int rq)
rq = mps;
}
- v = FIELD_PREP(PCI_EXP_DEVCTL_READRQ, ffs(rq) - 8);
+ firstbit = ffs(rq);
+ if (firstbit < 8)
+ return -EINVAL;
+ v = FIELD_PREP(PCI_EXP_DEVCTL_READRQ, firstbit - 8);
if (bridge->no_inc_mrrs) {
int max_mrrs = pcie_get_readrq(dev);
--
2.34.1
Total jobs: 57
Total errors: 30 (52.63%)
LAVA errors: 0 (0.00%)
Test errors: 29 (50.88%)
Job errors: 1 (1.75%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: sm8550-hdk
Total jobs: 5
Total errors: 4 (80.00%)
Error type: Test
Error count: 4 (80.00%)
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 1 (20.00%)
IDs:
sm8550-hdk-01:
8439143
Error: No match for error type 'Test', message 'tradefed - adb device lost[124d1c34]'
Count: 3 (60.00%)
IDs:
sm8550-hdk-01:
8439108 8439109 8439110
Device type: dragonboard-845c
Total jobs: 50
Total errors: 26 (52.00%)
Error type: Test
Error count: 25 (50.00%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[f3a58ae3]'
Count: 4 (8.00%)
IDs:
db845c-04:
8433962 8434359 8434368 8434678
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 3 (6.00%)
IDs:
db845c-03:
8434614
db845c-04:
8434605
db845c-06:
8434607
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 1 (2.00%)
IDs:
db845c-06:
8434612
Error: No match for error type 'Test', message 'tradefed - adb device lost[e875976d]'
Count: 4 (8.00%)
IDs:
db845c-06:
8433961 8433964 8434369 8434602
Error: Device NOT found!
Count: 1 (2.00%)
IDs:
db845c-04:
8434597
Error: No match for error type 'Test', message 'lava-test-interactive timed out after 600 seconds'
Count: 3 (6.00%)
IDs:
db845c-03:
8434579 8434581
db845c-06:
8434582
Error: No match for error type 'Test', message 'tradefed - adb device lost[476f370a]'
Count: 3 (6.00%)
IDs:
db845c-10:
8433932 8434361 8434559
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 2 (4.00%)
IDs:
db845c-06:
8433942 8434558
Error: No match for error type 'Test', message 'tradefed - adb device lost[d966d3f5]'
Count: 4 (8.00%)
IDs:
db845c-03:
8433960 8433963 8434360 8434557
Error type: Job
Error count: 1 (2.00%)
Error: wait for prompt timed out
Count: 1 (2.00%)
IDs:
db845c-06:
8433933
Device type: x86
Total jobs: 1
Total errors: 0 (0.00%)
Device type: rk3399-rock-pi-4b
Total jobs: 1
Total errors: 0 (0.00%)
Total jobs: 189
Total errors: 99 (52.38%)
LAVA errors: 0 (0.00%)
Test errors: 77 (40.74%)
Job errors: 19 (10.05%)
Infra errors: 3 (1.59%)
Canceled jobs: 0 (0.00%)
Device type: x15
Total jobs: 1
Total errors: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 27
Total errors: 7 (25.93%)
Error type: Test
Error count: 6 (22.22%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[d8a1879f]'
Count: 1 (3.70%)
IDs:
rb5-07:
8435704
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 3 (11.11%)
IDs:
rb5-03:
8435556 8435665
rb5-07:
8435686
Error: No match for error type 'Test', message 'lava-test-interactive timed out after 600 seconds'
Count: 2 (7.41%)
IDs:
rb5-03:
8435558 8435561
Error type: Infrastructure
Error count: 1 (3.70%)
Error: Connection closed
Count: 1 (3.70%)
IDs:
rb5-01:
8435683
Device type: sm8550-hdk
Total jobs: 11
Total errors: 3 (27.27%)
Error type: Test
Error count: 3 (27.27%)
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 3 (27.27%)
IDs:
sm8550-hdk-01:
8435469 8435713 8435716
Device type: hi960-hikey
Total jobs: 17
Total errors: 7 (41.18%)
Error type: Test
Error count: 6 (35.29%)
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 5 (29.41%)
IDs:
hi960-hikey-01:
8434669 8434697 8435473 8435631
hi960-hikey-02:
8435394
Error: No match for error type 'Test', message 'tradefed - adb device lost[6A522E130177F475]'
Count: 1 (5.88%)
IDs:
hi960-hikey-01:
8434670
Error type: Infrastructure
Error count: 1 (5.88%)
Error: No match for error type 'Infrastructure', message 'wait-device-boardid timed out after 1174 seconds'
Count: 1 (5.88%)
IDs:
hi960-hikey-04:
8434667
Device type: dragonboard-845c
Total jobs: 133
Total errors: 82 (61.65%)
Error type: Test
Error count: 62 (46.62%)
Error: No match for error type 'Test', message 'lava-test-interactive timed out after 600 seconds'
Count: 18 (13.53%)
IDs:
db845c-03:
8433350
db845c-04:
8433293 8433299 8433353 8433872 8433901
db845c-06:
8433283 8433286 8433295 8433323 8433329
8433857 8433914
db845c-10:
8433327 8433859 8433900 8433909 8433910
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 6 (4.51%)
IDs:
db845c-03:
8433787
db845c-04:
8433779
db845c-06:
8433325 8433830 8433871
db845c-09:
8433242
Error: No match for error type 'Test', message 'tradefed - adb device lost[476f370a]'
Count: 11 (8.27%)
IDs:
db845c-10:
8433284 8433297 8433331 8433375 8433761
8433778 8433791 8433794 8433813 8433845
8433870
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 297 seconds'
Count: 1 (0.75%)
IDs:
db845c-03:
8433807
Error: No match for error type 'Test', message 'tradefed - adb device lost[e875976d]'
Count: 5 (3.76%)
IDs:
db845c-06:
8433245 8433374 8433399 8433792 8433796
Error: No match for error type 'Test', message 'tradefed - adb device lost[d966d3f5]'
Count: 6 (4.51%)
IDs:
db845c-03:
8433398 8433402 8433768 8433783 8433785
8433790
Error: No match for error type 'Test', message 'tradefed - adb device lost[f3a58ae3]'
Count: 8 (6.02%)
IDs:
db845c-04:
8433241 8433244 8433373 8433380 8433400
8433415 8433782 8433786
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 584 seconds'
Count: 1 (0.75%)
IDs:
db845c-03:
8433763
Error: Device NOT found!
Count: 3 (2.26%)
IDs:
db845c-03:
8433352
db845c-04:
8433264 8433762
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 1 (0.75%)
IDs:
db845c-04:
8433339
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 596 seconds'
Count: 1 (0.75%)
IDs:
db845c-03:
8433334
Error: No match for error type 'Test', message 'tradefed - adb device lost[a6622a22]'
Count: 1 (0.75%)
IDs:
db845c-09:
8433243
Error type: Job
Error count: 19 (14.29%)
Error: wait for prompt timed out
Count: 7 (5.26%)
IDs:
db845c-03:
8433463
db845c-04:
8433469
db845c-06:
8433465
db845c-10:
8433466 8433473 8433759 8433904
Error: No match for error type 'Job', message 'login-action timed out after 874 seconds'
Count: 1 (0.75%)
IDs:
db845c-04:
8433903
Error: No match for error type 'Job', message 'login-action timed out after 872 seconds'
Count: 4 (3.01%)
IDs:
db845c-03:
8433471
db845c-04:
8433443
db845c-06:
8433764
db845c-10:
8433462
Error: No match for error type 'Job', message 'login-action timed out after 873 seconds'
Count: 3 (2.26%)
IDs:
db845c-03:
8433442 8433474 8433760
Error: No match for error type 'Job', message 'login-action timed out after 801 seconds'
Count: 1 (0.75%)
IDs:
db845c-10:
8433470
Error: No match for error type 'Job', message 'login-action timed out after 871 seconds'
Count: 3 (2.26%)
IDs:
db845c-03:
8433460
db845c-04:
8433461 8433464
Error type: Infrastructure
Error count: 1 (0.75%)
Error: No match for error type 'Infrastructure', message 'wait-device-boardid timed out after 1172 seconds'
Count: 1 (0.75%)
IDs:
db845c-05:
8433249
Hi,
We are a electric bicycle manufacturer with a production capacity of 20,000
units annually. Our warehouses in Europe, the US allow for fast shipping
within 3-7 days.
If you’re interested in purchasing electric bicycles, we can provide you
with a price based on your location.
We also welcome inquiries about becoming an authorized dealer in your
region.
Our electric bicycle options include: 26” Fat Tire eBikes, 20”
Moped-Style
Fat Tire eBikes ,26” Full Suspension eBikes
20” Folding Full Suspension eBikes, High-end Mid-Motor Soft-Tail Mountain
Bikes,
Electric Cargo Trikes, 5600W eScooters and 8000W Dirt eBikes,
We offer flexible battery and motor options to suit your needs.
Best regards,
Robin Tan
The Electric Bicycle Expert
