On Mon, 21 Sep 2020 at 17:29, Petr Vorel <pvorel(a)suse.cz> wrote:
>
> Hi Cyril,
>
> > The file wasn't properly maintained for last ten years, 99% of the
> > patches touching it were only removing removed tests. We should stop
> > pretending that it's useful anyhow it clearly does not contain well
> > selected set of tests for quick testrun anymore.
We have been using quickhit as a smoke test across all available devices
because it runs in a minute. With this file removed what could be the next best
tests for a quick smoke test ?
Since we are using and testing this quickhit shall we keep it ?
>
> > Signed-off-by: Cyril Hrubis <chrubis(a)suse.cz>
> > CC: "Bird, Tim" <Tim.Bird(a)sony.com>
> > CC: Petr Vorel <pvorel(a)suse.cz>
> Reviewed-by: Petr Vorel <pvorel(a)suse.cz>
>
> Kind regards,
> Petr
>
- Naresh
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
On Mon, 21 Sep 2020 at 06:34, Stuart Little <achirvasub(a)gmail.com> wrote:
>
> I am trying to compile for an x86_64 machine (Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz). The config file I am currently using is at
>
> https://termbin.com/xin7
>
> The build for 5.9.0-rc6 fails with the following errors:
>
arm and mips allmodconfig build breaks due to this error.
>
> drivers/dax/super.c:325:6: error: redefinition of ‘dax_supported’
> 325 | bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
> | ^~~~~~~~~~~~~
> In file included from drivers/dax/super.c:16:
> ./include/linux/dax.h:162:20: note: previous definition of ‘dax_supported’ was here
> 162 | static inline bool dax_supported(struct dax_device *dax_dev,
> | ^~~~~~~~~~~~~
> CC lib/memregion.o
> CC [M] drivers/gpu/drm/drm_gem_vram_helper.o
> make[2]: *** [scripts/Makefile.build:283: drivers/dax/super.o] Error 1
> make[1]: *** [scripts/Makefile.build:500: drivers/dax] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> --- end ---
>
> That's earlier on, and then later, at the end of the (failed) build:
>
> make: *** [Makefile:1784: drivers] Error 2
>
> The full build log is at
>
> https://termbin.com/ihxj
>
> but I do not see anything else amiss. 5.9.0-rc5 built fine last week.
Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org>
On Fri, 18 Sep 2020 at 11:18, Dan Williams <dan.j.williams(a)intel.com> wrote:
>
> From: Jan Kara <jack(a)suse.cz>
>
> DM was calling generic_fsdax_supported() to determine whether a device
> referenced in the DM table supports DAX. However this is a helper for "leaf" device drivers so that
> they don't have to duplicate common generic checks. High level code
> should call dax_supported() helper which that calls into appropriate
> helper for the particular device. This problem manifested itself as
> kernel messages:
>
> dm-3: error: dax access failed (-95)
>
> when lvm2-testsuite run in cases where a DM device was stacked on top of
> another DM device.
>
> Fixes: 7bf7eac8d648 ("dax: Arrange for dax_supported check to span multiple devices")
> Cc: <stable(a)vger.kernel.org>
> Tested-by: Adrian Huang <ahuang12(a)lenovo.com>
> Signed-off-by: Jan Kara <jack(a)suse.cz>
> Acked-by: Mike Snitzer <snitzer(a)redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams(a)intel.com>
> ---
> Changes since v1 [1]:
> - Add missing dax_read_lock() around dax_supported()
>
> [1]: http://lore.kernel.org/r/20200916151445.450-1-jack@suse.cz
>
> drivers/dax/super.c | 4 ++++
> drivers/md/dm-table.c | 10 +++++++---
> include/linux/dax.h | 11 +++++++++--
> 3 files changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index e5767c83ea23..b6284c5cae0a 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -325,11 +325,15 @@ EXPORT_SYMBOL_GPL(dax_direct_access);
> bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
> int blocksize, sector_t start, sector_t len)
> {
> + if (!dax_dev)
> + return false;
> +
> if (!dax_alive(dax_dev))
> return false;
>
> return dax_dev->ops->dax_supported(dax_dev, bdev, blocksize, start, len);
> }
> +EXPORT_SYMBOL_GPL(dax_supported);
arm build error while building with allmodconfig.
../drivers/dax/super.c:325:6: error: redefinition of ‘dax_supported’
325 | bool dax_supported(struct dax_device *dax_dev, struct
block_device *bdev,
| ^~~~~~~~~~~~~
In file included from ../drivers/dax/super.c:16:
../include/linux/dax.h:162:20: note: previous definition of
‘dax_supported’ was here
162 | static inline bool dax_supported(struct dax_device *dax_dev,
| ^~~~~~~~~~~~~
make[3]: *** [../scripts/Makefile.build:283: drivers/dax/super.o] Error 1
Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org>
Ref:
https://builds.tuxbuild.com/IO690jFQDp0qP9zFuWBqpA/build.log