On Tue, Sep 08, 2020 at 03:07:49PM +0200, Bartosz Golaszewski wrote:

From: Bartosz Golaszewski bgolaszewski@baylibre.com

If the module init function fails after creating the debugs directory, it's never removed. Add proper cleanup calls to avoid this resource leak.

Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com

Fixes: 9202ba2397d1 ("gpio: mockup: implement event injecting over debugfs") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com

---

drivers/gpio/gpio-mockup.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index bc345185db26..1652897fdf90 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -552,6 +552,7 @@ static int __init gpio_mockup_init(void) err = platform_driver_register(&gpio_mockup_driver); if (err) { gpio_mockup_err("error registering platform driver\n");

• debugfs_remove_recursive(gpio_mockup_dbg_dir);
  

  return err; }

@@ -582,6 +583,7 @@ static int __init gpio_mockup_init(void) gpio_mockup_err("error registering device"); platform_driver_unregister(&gpio_mockup_driver); gpio_mockup_unregister_pdevs();

• 	debugfs_remove_recursive(gpio_mockup_dbg_dir);
  return PTR_ERR(pdev);
  

  }

2.26.1