From: Dexuan Cui decui@microsoft.com
Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj.
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com --- drivers/hv/vmbus_drv.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 6a86746..4f3faf5 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -1378,6 +1378,8 @@ void vmbus_device_unregister(struct hv_device *device_obj) pr_debug("child device %s unregistered\n", dev_name(&device_obj->device));
+ kset_unregister(device_obj->channels_kset); + /* * Kick off the process of unregistering the device. * This will call vmbus_remove() and eventually vmbus_device_release()
On Tue, Nov 14, 2017 at 06:53:32AM -0700, kys@exchange.microsoft.com wrote:
From: Dexuan Cui decui@microsoft.com
Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj.
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: stable@vger.kernel.org
Why is this marked for stable when the patch it "fixes" is in 4.15-rc1?
On Tue, 28 Nov 2017 16:56:05 +0100 Greg KH gregkh@linuxfoundation.org wrote:
On Tue, Nov 14, 2017 at 06:53:32AM -0700, kys@exchange.microsoft.com wrote:
From: Dexuan Cui decui@microsoft.com
Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj.
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: stable@vger.kernel.org
Why is this marked for stable when the patch it "fixes" is in 4.15-rc1?
It doesn't need to go to stable.
From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Stephen Hemminger Sent: Tuesday, November 28, 2017 9:30 AM To: Greg KH gregkh@linuxfoundation.org Cc: olaf@aepfle.de; Stephen Hemminger sthemmin@microsoft.com; jasowang@redhat.com; linux-kernel@vger.kernel.org; stable@vger.kernel.org; apw@canonical.com; marcelo.cerri@canonical.com; devel@linuxdriverproject.org; vkuznets@redhat.com; leann.ogasawara@canonical.com Subject: Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset
On Tue, 28 Nov 2017 16:56:05 +0100 Greg KH gregkh@linuxfoundation.org wrote:
On Tue, Nov 14, 2017 at 06:53:32AM -0700, kys@exchange.microsoft.com
wrote:
From: Dexuan Cui decui@microsoft.com
Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj.
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: stable@vger.kernel.org
Why is this marked for stable when the patch it "fixes" is in 4.15-rc1?
It doesn't need to go to stable.
Hi Greg, May I know the status of the patch?
Thanks, -- Dexuan
On Mon, Dec 11, 2017 at 08:41:44PM +0000, Dexuan Cui wrote:
From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Stephen Hemminger Sent: Tuesday, November 28, 2017 9:30 AM To: Greg KH gregkh@linuxfoundation.org Cc: olaf@aepfle.de; Stephen Hemminger sthemmin@microsoft.com; jasowang@redhat.com; linux-kernel@vger.kernel.org; stable@vger.kernel.org; apw@canonical.com; marcelo.cerri@canonical.com; devel@linuxdriverproject.org; vkuznets@redhat.com; leann.ogasawara@canonical.com Subject: Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset
On Tue, 28 Nov 2017 16:56:05 +0100 Greg KH gregkh@linuxfoundation.org wrote:
On Tue, Nov 14, 2017 at 06:53:32AM -0700, kys@exchange.microsoft.com
wrote:
From: Dexuan Cui decui@microsoft.com
Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj.
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: stable@vger.kernel.org
Why is this marked for stable when the patch it "fixes" is in 4.15-rc1?
It doesn't need to go to stable.
Hi Greg, May I know the status of the patch?
It's still in my "to-apply" queue. As it's only a 4.15-final thing, don't worry, it will get there...
thanks,
greg k-h
From: Greg KH [mailto:gregkh@linuxfoundation.org] Sent: Monday, December 11, 2017 12:59 PM To: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger stephen@networkplumber.org; olaf@aepfle.de; Stephen Hemminger sthemmin@microsoft.com; jasowang@redhat.com; linux-kernel@vger.kernel.org; stable@vger.kernel.org; apw@canonical.com; marcelo.cerri@canonical.com; devel@linuxdriverproject.org; vkuznets@redhat.com; leann.ogasawara@canonical.com Subject: Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset
On Mon, Dec 11, 2017 at 08:41:44PM +0000, Dexuan Cui wrote:
From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Stephen Hemminger Sent: Tuesday, November 28, 2017 9:30 AM To: Greg KH gregkh@linuxfoundation.org Cc: olaf@aepfle.de; Stephen Hemminger sthemmin@microsoft.com; jasowang@redhat.com; linux-kernel@vger.kernel.org;
stable@vger.kernel.org;
apw@canonical.com; marcelo.cerri@canonical.com; devel@linuxdriverproject.org; vkuznets@redhat.com; leann.ogasawara@canonical.com Subject: Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset
On Tue, 28 Nov 2017 16:56:05 +0100 Greg KH gregkh@linuxfoundation.org wrote:
On Tue, Nov 14, 2017 at 06:53:32AM -0700,
kys@exchange.microsoft.com
wrote:
From: Dexuan Cui decui@microsoft.com
Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
Without the patch, a device can't be thoroughly destroyed, because vmbus_device_register() -> kset_create_and_add() still holds a reference to the hv_device's device.kobj.
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: stable@vger.kernel.org
Why is this marked for stable when the patch it "fixes" is in 4.15-rc1?
It doesn't need to go to stable.
Hi Greg, May I know the status of the patch?
It's still in my "to-apply" queue. As it's only a 4.15-final thing, don't worry, it will get there...
thanks,
greg k-h
Thanks a lot, Greg!
-- Dexuan
linux-stable-mirror@lists.linaro.org
-
Dexuan Cui -
Greg KH -
kys＠exchange.microsoft.com -
Stephen Hemminger