Hello I found this failure on stable 5.13.16-rc1[1] and cannot reproduce it on 5.14, seems we are missing commit[2] on 5.13.y, could anyone help check it?
[1] # nvme_trtype=tcp ./check nvme/014 nvme/014 (flush a NVMeOF block device-backed ns) [passed] runtime 30.745s ... 22.110s # lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:0 0 465.8G 0 disk ├─sda1 8:1 0 1G 0 part /boot ├─sda2 8:2 0 16G 0 part /mnt/dmtest/data ├─sda3 8:3 0 15G 0 part /mnt/xfstests/mnt1 ├─sda4 8:4 0 1K 0 part ├─sda5 8:5 0 15G 0 part /mnt/xfstests/mnt2 ├─sda6 8:6 0 7.9G 0 part [SWAP] ├─sda7 8:7 0 5G 0 part /mnt/xfstests/logwrites ├─sda8 8:8 0 1G 0 part /mnt/dmtest/metadata └─sda9 8:9 0 404.9G 0 part / zram0 252:0 0 8G 0 disk [SWAP] nvme0n1 259:3 0 1G 0 disk
[ 133.791507] run blktests nvme/014 at 2021-09-12 08:08:17 [ 133.908750] loop0: detected capacity change from 0 to 2097152 [ 133.927551] nvmet: adding nsid 1 to subsystem blktests-subsystem-1 [ 133.942518] nvmet_tcp: enabling port 0 (127.0.0.1:4420) [ 133.977746] nvmet: creating controller 1 for subsystem blktests-subsystem-1 for NQN nqn.2014-08.org.nvmexpress:uuid:c4c5023e9bcd4cb5889e9510622eb88c. [ 133.994170] nvme nvme0: creating 4 I/O queues. [ 133.999881] nvme nvme0: mapped 4/0/0 default/read/poll queues. [ 134.008683] nvme nvme0: new ctrl: NQN "blktests-subsystem-1", addr 127.0.0.1:4420 [ 151.223049] nvme nvme0: using deprecated NVME_IOCTL_IO_CMD ioctl on the char device! [ 155.675634] nvme nvme0: Removing ctrl: NQN "blktests-subsystem-1" [ 155.682902] block nvme0n1: no available path - failing I/O [ 155.689137] block nvme0n1: no available path - failing I/O [ 155.695295] Buffer I/O error on dev nvme0n1, logical block 32, async page read
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... 5396fdac56d8 nvme: fix refcounting imbalance when all paths are down
On Tue, Sep 14, 2021 at 10:28 PM Sagi Grimberg sagi@grimberg.me wrote:
Hello I found this failure on stable 5.13.16-rc1[1] and cannot reproduce it on 5.14, seems we are missing commit[2] on 5.13.y, could anyone help check it?
Was it picked up and didn't apply correctly?
Hi Sagi I tried apply that patch to stable branch, but failed to do that, would you or Hannes mind help backport it, thanks.
[linux-stable-rc ((daeb634aa75f...))]$ git am 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch Applying: nvme: fix refcounting imbalance when all paths are down error: patch failed: drivers/nvme/host/nvme.h:716 error: drivers/nvme/host/nvme.h: patch does not apply Patch failed at 0001 nvme: fix refcounting imbalance when all paths are down hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
[linux-stable-rc ((daeb634aa75f...))]$ patch -p1 < 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch patching file drivers/nvme/host/core.c Hunk #1 succeeded at 3761 (offset -46 lines). Hunk #2 succeeded at 3771 (offset -46 lines). Hunk #3 succeeded at 3790 (offset -46 lines). patching file drivers/nvme/host/multipath.c Hunk #1 succeeded at 757 (offset -3 lines). patching file drivers/nvme/host/nvme.h Hunk #1 FAILED at 716. Hunk #2 succeeded at 775 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file drivers/nvme/host/nvme.h.rej
On Wed, Sep 15, 2021 at 08:41:21PM +0800, Yi Zhang wrote:
On Tue, Sep 14, 2021 at 10:28 PM Sagi Grimberg sagi@grimberg.me wrote:
Hello I found this failure on stable 5.13.16-rc1[1] and cannot reproduce it on 5.14, seems we are missing commit[2] on 5.13.y, could anyone help check it?
Was it picked up and didn't apply correctly?
Hi Sagi I tried apply that patch to stable branch, but failed to do that, would you or Hannes mind help backport it, thanks.
[linux-stable-rc ((daeb634aa75f...))]$ git am 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch Applying: nvme: fix refcounting imbalance when all paths are down error: patch failed: drivers/nvme/host/nvme.h:716 error: drivers/nvme/host/nvme.h: patch does not apply Patch failed at 0001 nvme: fix refcounting imbalance when all paths are down hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
[linux-stable-rc ((daeb634aa75f...))]$ patch -p1 < 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch patching file drivers/nvme/host/core.c Hunk #1 succeeded at 3761 (offset -46 lines). Hunk #2 succeeded at 3771 (offset -46 lines). Hunk #3 succeeded at 3790 (offset -46 lines). patching file drivers/nvme/host/multipath.c Hunk #1 succeeded at 757 (offset -3 lines). patching file drivers/nvme/host/nvme.h Hunk #1 FAILED at 716. Hunk #2 succeeded at 775 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file drivers/nvme/host/nvme.h.rej
5.13 is only going to be around for a 2-3 more days, please move to 5.14.y at this point in time. No need to do any extra work for 5.13.y at this point in time as it is about to be end-of-life.
thanks,
greg k-h
On Wed, Sep 15, 2021 at 9:00 PM Greg KH gregkh@linuxfoundation.org wrote:
On Wed, Sep 15, 2021 at 08:41:21PM +0800, Yi Zhang wrote:
On Tue, Sep 14, 2021 at 10:28 PM Sagi Grimberg sagi@grimberg.me wrote:
Hello I found this failure on stable 5.13.16-rc1[1] and cannot reproduce it on 5.14, seems we are missing commit[2] on 5.13.y, could anyone help check it?
Was it picked up and didn't apply correctly?
Hi Sagi I tried apply that patch to stable branch, but failed to do that, would you or Hannes mind help backport it, thanks.
[linux-stable-rc ((daeb634aa75f...))]$ git am 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch Applying: nvme: fix refcounting imbalance when all paths are down error: patch failed: drivers/nvme/host/nvme.h:716 error: drivers/nvme/host/nvme.h: patch does not apply Patch failed at 0001 nvme: fix refcounting imbalance when all paths are down hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
[linux-stable-rc ((daeb634aa75f...))]$ patch -p1 < 0001-nvme-fix-refcounting-imbalance-when-all-paths-are-do.patch patching file drivers/nvme/host/core.c Hunk #1 succeeded at 3761 (offset -46 lines). Hunk #2 succeeded at 3771 (offset -46 lines). Hunk #3 succeeded at 3790 (offset -46 lines). patching file drivers/nvme/host/multipath.c Hunk #1 succeeded at 757 (offset -3 lines). patching file drivers/nvme/host/nvme.h Hunk #1 FAILED at 716. Hunk #2 succeeded at 775 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file drivers/nvme/host/nvme.h.rej
5.13 is only going to be around for a 2-3 more days, please move to 5.14.y at this point in time. No need to do any extra work for 5.13.y at this point in time as it is about to be end-of-life.
Got it, thanks for the update.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
Sagi Grimberg -
Yi Zhang