Request to backport commit id: 15924b0503630016dee4dbb945a8df4df659070b to 6.5/scsi-fixes
(Re-sending email since the previous email was undeliverable due to HTML content)
Hi Team,
This is a request to backport the following fix to 6.5/scsi-fixes. This was merged into Linus' tree.
This fix fixes a crash due to a null pointer exception when a lun reset is issued from sgreset for a lun. With this fix, there is no longer a crash.
I have another fix, which I have tested, dependent on this fix. It is currently in the pipeline. I'll send out a patch for that fix when the internal review is complete.
Please let me know if you need any more information to backport this fix.
commit 15924b0503630016dee4dbb945a8df4df659070b Author: Karan Tilak Kumar kartilak@cisco.com Date: Thu Aug 17 11:21:46 2023 -0700
scsi: fnic: Replace sgreset tag with max_tag_id
sgreset is issued with a SCSI command pointer. The device reset code assumes that it was issued on a hardware queue, and calls block multiqueue layer. However, the assumption is broken, and there is no hardware queue associated with the sgreset, and this leads to a crash due to a null pointer exception.
Fix the code to use the max_tag_id as a tag which does not overlap with the other tags issued by mid layer.
Tested by running FC traffic for a few minutes, and by issuing sgreset on the device in parallel. Without the fix, the crash is observed right away. With this fix, no crash is observed.
Reviewed-by: Sesidhar Baddela sebaddel@cisco.com Tested-by: Karan Tilak Kumar kartilak@cisco.com Signed-off-by: Karan Tilak Kumar kartilak@cisco.com Link: https://lore.kernel.org/r/20230817182146.229059-1-kartilak@cisco.com Signed-off-by: Martin K. Petersen martin.petersen@oracle.com
Thanks, Karan
On Thu, Sep 14, 2023 at 04:20:24AM +0000, Karan Tilak Kumar (kartilak) wrote:
(Re-sending email since the previous email was undeliverable due to HTML content)
Hi Team,
This is a request to backport the following fix to 6.5/scsi-fixes. This was merged into Linus' tree.
What is "6.5/scsi-fixes"?
This fix fixes a crash due to a null pointer exception when a lun reset is issued from sgreset for a lun. With this fix, there is no longer a crash.
I have another fix, which I have tested, dependent on this fix. It is currently in the pipeline. I'll send out a patch for that fix when the internal review is complete.
Please let me know if you need any more information to backport this fix.
It doesn't apply as-is so how did you test this on the 6.5 tree? Please provide a working, and tested, backport and we will be glad to queue it up for the stable trees.
thanks,
greg k-h
Hi Greg,
Thanks for your response.
What is "6.5/scsi-fixes"?
6.5/scsi-fixes is a branch on Martin K Petersen's repo. I see now that there's a new branch: 6.6/scsi-fixes.
It doesn't apply as-is so how did you test this on the 6.5 tree? Please provide a working, and tested, backport and we will be glad to queue it up for the stable trees.
I had previously tested the patch on Martin's 6.5/scsi-fixes tree. However, I saw that there is a new tree: 6.6/scsi-fixes, and the patch has been applied there. I needed to submit a new patch which was dependent on these changes. So, I ported my new patch to 6.6/scsi-fixes and tested it there. So, please ignore this request for a backport. I have submitted my new patch based off the 6.6/scsi-fixes tree.
Regards, Karan
-----Original Message----- From: Greg KH gregkh@linuxfoundation.org Sent: Saturday, September 16, 2023 4:37 AM To: Karan Tilak Kumar (kartilak) kartilak@cisco.com Cc: stable@vger.kernel.org; Arulprabhu Ponnusamy (arulponn) arulponn@cisco.com; Sesidhar Baddela (sebaddel) sebaddel@cisco.com; martin.petersen@oracle.com Subject: Re: Request to backport commit id: 15924b0503630016dee4dbb945a8df4df659070b to 6.5/scsi-fixes
On Thu, Sep 14, 2023 at 04:20:24AM +0000, Karan Tilak Kumar (kartilak) wrote:
(Re-sending email since the previous email was undeliverable due to HTML content)
Hi Team,
This is a request to backport the following fix to 6.5/scsi-fixes. This was merged into Linus' tree.
What is "6.5/scsi-fixes"?
This fix fixes a crash due to a null pointer exception when a lun reset is issued from sgreset for a lun. With this fix, there is no longer a crash.
I have another fix, which I have tested, dependent on this fix. It is currently in the pipeline. I'll send out a patch for that fix when the internal review is complete.
Please let me know if you need any more information to backport this fix.
It doesn't apply as-is so how did you test this on the 6.5 tree? Please provide a working, and tested, backport and we will be glad to queue it up for the stable trees.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
Karan Tilak Kumar (kartilak)