The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 1ea32c83c699df32689d329b2415796b7bfc2f6e Mon Sep 17 00:00:00 2001
From: Stefan Berger stefanb@linux.ibm.com Date: Thu, 29 Aug 2019 20:09:06 -0400 Subject: [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts
The tpm_tis_core has to set the TPM_CHIP_FLAG_IRQ before probing for interrupts since there is no other place in the code that would set it.
Cc: linux-stable@vger.kernel.org Fixes: 570a36097f30 ("tpm: drop 'irq' from struct tpm_vendor_specific") Signed-off-by: Stefan Berger stefanb@linux.ibm.com Signed-off-by: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index ffa9048d8f6c..270f43acbb77 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -981,6 +981,7 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, }
tpm_chip_start(chip); + chip->flags |= TPM_CHIP_FLAG_IRQ; if (irq) { tpm_tis_probe_irq_single(chip, intmask, IRQF_SHARED, irq);
On Thu, Oct 03, 2019 at 09:46:29AM +0200, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
thanks,
greg k-h
Inspecting next week.
/Jarkko
On Thu, Oct 03, 2019 at 03:32:46PM +0300, Jarkko Sakkinen wrote:
On Thu, Oct 03, 2019 at 09:46:29AM +0200, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
thanks,
greg k-h
Inspecting next week.
It looks to me like it's not relevant for 4.19 and older because it needs 5b359c7c43727 ("tpm_tis_core: Turn on the TPM before probing IRQ's"), which isn't present in 4.19.
On Thu, Oct 03, 2019 at 09:25:17AM -0400, Sasha Levin wrote:
On Thu, Oct 03, 2019 at 03:32:46PM +0300, Jarkko Sakkinen wrote:
On Thu, Oct 03, 2019 at 09:46:29AM +0200, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
thanks,
greg k-h
Inspecting next week.
It looks to me like it's not relevant for 4.19 and older because it needs 5b359c7c43727 ("tpm_tis_core: Turn on the TPM before probing IRQ's"), which isn't present in 4.19.
Thanks. I'll take no action.
/Jarkko
linux-stable-mirror@lists.linaro.org