On Fri, Jan 04, 2019 at 09:03:10PM +0000, Sasha Levin wrote:
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag, fixing commit: a7d85e06ed80 crypto: cfb - add support for Cipher FeedBack mode.
The bot has tested the following trees: v4.20.0, v4.19.13.
v4.20.0: Failed to apply! Possible dependencies: 7da66670775d ("crypto: testmgr - add AES-CFB tests")
v4.19.13: Failed to apply! Possible dependencies: 7da66670775d ("crypto: testmgr - add AES-CFB tests") dfb89ab3f0a7 ("crypto: tcrypt - add OFB functional tests")
How should we proceed with this patch?
-- Thanks, Sasha
The following will need to be applied to 4.19 and 4.20 first. Both had Cc stable:
fa4600734b74 ("crypto: cfb - fix decryption") 7da66670775d ("crypto: testmgr - add AES-CFB tests")
Herbert, why was CFB accepted without any test vectors in the first place?
- Eric
On Fri, Jan 04, 2019 at 07:07:48PM -0800, Eric Biggers wrote:
Herbert, why was CFB accepted without any test vectors in the first place?
That was an oversight. Longer term we should restructure how the test vectors are stored by moving them in with the generic implementation. That should also ensure that we would never add an algorithm without both a generic implementation as well as test vectors.
Cheers,
linux-stable-mirror@lists.linaro.org
-
Eric Biggers -
Herbert Xu