Hi Bryan,

Thank you for the patch.

On Tue, Aug 22, 2023 at 09:06:23PM +0100, Bryan O'Donoghue wrote:

check_clock doesn't account for vfe_lite which means that vfe_lite will never get validated by this routine. Add the clock name to the expected set to remediate.

Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 170") Cc: stable@vger.kernel.org Signed-off-by: Bryan O'Donoghue bryan.odonoghue@linaro.org

Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

---

drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 938f373bcd1fd..b021f81cef123 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -535,7 +535,8 @@ static int vfe_check_clock_rates(struct vfe_device *vfe) struct camss_clock *clock = &vfe->clock[i]; if (!strcmp(clock->name, "vfe0") ||

•     !strcmp(clock->name, "vfe1")) {
  

•     !strcmp(clock->name, "vfe1") ||
  

•     !strcmp(clock->name, "vfe_lite")) {
  u64 min_rate = 0;
  unsigned long rate;