On 2024/10/23 1:44, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
selftests: mm: fix the incorrect usage() info of khugepaged
to the 6.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: selftests-mm-fix-the-incorrect-usage-info-of-khugepa.patch and it can be found in the queue-6.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
Hi, I don't think this patch needs to be added to the stable tree because this just fixes usage information, as Andrew had previously said: https://lore.kernel.org/lkml/20241017001441.2db5adaaa63dc3faa0934204@linux-f...
commit ad8b93ffe0a86e3b6be297826cd34b12080fc877 Author: Nanyong Sun sunnanyong@huawei.com Date: Tue Oct 15 10:02:57 2024 +0800
selftests: mm: fix the incorrect usage() info of khugepaged [ Upstream commit 3e822bed2fbd1527d88f483342b1d2a468520a9a ] The mount option of tmpfs should be huge=advise, not madvise which is not supported and may mislead the users. Link: https://lkml.kernel.org/r/20241015020257.139235-1-sunnanyong@huawei.com Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Kefeng Wang <wangkefeng.wang@huawei.com> Cc: Shuah Khan <shuah@kernel.org> Cc: Zach O'Keefe <zokeefe@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c index 829320a519e72..89dec42986825 100644 --- a/tools/testing/selftests/mm/khugepaged.c +++ b/tools/testing/selftests/mm/khugepaged.c @@ -1091,7 +1091,7 @@ static void usage(void) fprintf(stderr, "\n\t"file,all" mem_type requires kernel built with\n"); fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=y\n"); fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs must be\n");
- fprintf(stderr, "\tmounted with huge=madvise option for khugepaged tests to work\n");
- fprintf(stderr, "\tmounted with huge=advise option for khugepaged tests to work\n"); fprintf(stderr, "\n\tSupported Options:\n"); fprintf(stderr, "\t\t-h: This help message.\n"); fprintf(stderr, "\t\t-s: mTHP size, expressed as page order.\n");
.
On Wed, Oct 23, 2024 at 09:22:35AM +0800, Nanyong Sun wrote:
On 2024/10/23 1:44, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
selftests: mm: fix the incorrect usage() info of khugepaged
to the 6.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: selftests-mm-fix-the-incorrect-usage-info-of-khugepa.patch and it can be found in the queue-6.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
Hi, I don't think this patch needs to be added to the stable tree because this just fixes usage information, as Andrew had previously said: https://lore.kernel.org/lkml/20241017001441.2db5adaaa63dc3faa0934204@linux-f...
I'll drop it, but really - why not? It's a cheap fix that is very unlikely to introduce regressions and it improves the user's experience.
linux-stable-mirror@lists.linaro.org