Hello Rafael,
On Tue, Oct 11, 2022 at 10:20:50AM +0100, Mel Gorman wrote:
On Mon, Oct 10, 2022 at 08:29:05PM +0200, Rafael J. Wysocki wrote:
That's less than the previous 5/10 failures but I cannot be certain it helped without running a lot more boot tests. The failure happens in the same function as before.
I've overlooked the fact that acpi_install_fixed_event_handler() enables the event on success, so it is a bug to call it when the handler is not ready.
It should help to only enable the event after running cmos_do_probe() where the driver data pointer is set, so please try the attached patch.
I'm hitting this issue on the 6.0 stable releases (aka 6.0.y) and looking at the stable tree I see this hasn't been merged... I just got bitten by this on 6.0.12.
Greg, if Rafael agrees, I think you should apply 4919d3eb2ec0 and 0782b66ed2fb to the 6.0.y tree.
Thank you in advance.
Cheers,
On Mon, Dec 12, 2022 at 7:25 PM Mathieu Chouquet-Stringer me@mathieu.digital wrote:
Hello Rafael,On Tue, Oct 11, 2022 at 10:20:50AM +0100, Mel Gorman wrote:
On Mon, Oct 10, 2022 at 08:29:05PM +0200, Rafael J. Wysocki wrote:
That's less than the previous 5/10 failures but I cannot be certain it helped without running a lot more boot tests. The failure happens in the same function as before.
I've overlooked the fact that acpi_install_fixed_event_handler() enables the event on success, so it is a bug to call it when the handler is not ready.
It should help to only enable the event after running cmos_do_probe() where the driver data pointer is set, so please try the attached patch.
I'm hitting this issue on the 6.0 stable releases (aka 6.0.y) and looking at the stable tree I see this hasn't been merged... I just got bitten by this on 6.0.12.
Greg, if Rafael agrees, I think you should apply 4919d3eb2ec0 and 0782b66ed2fb to the 6.0.y tree.
This is fine with me, please send an inclusion request to Greg and the "stable" list.
linux-stable-mirror@lists.linaro.org
-
Mathieu Chouquet-Stringer -
Rafael J. Wysocki