On 07/01/2020 5:38 pm, Naresh Kamboju wrote:

Following build error on stable-rc 5.4.9-rc1 for arm architecture.

dma/direct.c: In function 'dma_direct_possible': dma/direct.c:329:3: error: too many arguments to function 'dma_capable' dma_capable(dev, dma_addr, size, true); ^~~~~~~~~~~

Not sure that $SUBJECT comes into it at all, but by the look of it I guess "dma-direct: exclude dma_direct_map_resource from the min_low_pfn check" implicitly depends on 130c1ccbf553 ("dma-direct: unify the dma_capable definitions") too.

Robin.

In file included from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/dma-direct.h:12:0, from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/kernel/dma/direct.c:10: /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/arch/arm/include/asm/dma-direct.h:17:20: note: declared here static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) ^~~~~~~~~~~ In file included from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/init.h:5:0, from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/memblock.h:12, from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/kernel/dma/direct.c:7: dma/direct.c: In function 'dma_direct_map_resource': dma/direct.c:378:16: error: too many arguments to function 'dma_capable' if (unlikely(!dma_capable(dev, dma_addr, size, false))) { ^ /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ In file included from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/dma-direct.h:12:0, from /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/kernel/dma/direct.c:10: /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/arch/arm/include/asm/dma-direct.h:17:20: note: declared here static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) ^~~~~~~~~~~ /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/scripts/Makefile.build:265: recipe for target 'kernel/dma/direct.o' failed

Full build log link, https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-5.4/DI...