Allow the liteuart driver to be compile tested by fixing the broken Kconfig dependencies.
Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver") Cc: stable@vger.kernel.org # 5.11 Cc: Filip Kokosinski fkokosinski@antmicro.com Cc: Mateusz Holenko mholenko@antmicro.com Cc: Stafford Horne shorne@gmail.com Signed-off-by: Johan Hovold johan@kernel.org --- drivers/tty/serial/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 6ff94cfcd9db..67de892e0947 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE
config SERIAL_LITEUART tristate "LiteUART serial port support" + depends on LITEX || COMPILE_TEST depends on HAS_IOMEM - depends on OF || COMPILE_TEST - depends on LITEX + depends on OF select SERIAL_CORE help This driver is for the FPGA-based LiteUART serial controller from LiteX
On Mon, Nov 15, 2021 at 02:37:43PM +0100, Johan Hovold wrote:
Allow the liteuart driver to be compile tested by fixing the broken Kconfig dependencies.
Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver") Cc: stable@vger.kernel.org # 5.11 Cc: Filip Kokosinski fkokosinski@antmicro.com Cc: Mateusz Holenko mholenko@antmicro.com Cc: Stafford Horne shorne@gmail.com Signed-off-by: Johan Hovold johan@kernel.org
Reviewed-by: Stafford Horne shorne@gmail.com
drivers/tty/serial/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 6ff94cfcd9db..67de892e0947 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE config SERIAL_LITEUART tristate "LiteUART serial port support"
- depends on LITEX || COMPILE_TEST depends on HAS_IOMEM
- depends on OF || COMPILE_TEST
- depends on LITEX
- depends on OF select SERIAL_CORE help This driver is for the FPGA-based LiteUART serial controller from LiteX
-- 2.32.0
On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold johan@kernel.org wrote:
Allow the liteuart driver to be compile tested by fixing the broken Kconfig dependencies.
...
config SERIAL_LITEUART tristate "LiteUART serial port support"
depends on LITEX || COMPILE_TEST depends on HAS_IOMEM
depends on OF || COMPILE_TESTdepends on LITEX
depends on OF
AFAICS this is optional and prevents compile testing in some cases.
select SERIAL_CORE help This driver is for the FPGA-based LiteUART serial controller from LiteX
On Tue, Nov 16, 2021 at 05:44:14PM +0200, Andy Shevchenko wrote:
On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold johan@kernel.org wrote:
Allow the liteuart driver to be compile tested by fixing the broken Kconfig dependencies.
...
config SERIAL_LITEUART tristate "LiteUART serial port support"
depends on LITEX || COMPILE_TEST depends on HAS_IOMEM
depends on OF || COMPILE_TESTdepends on LITEX
depends on OFAFAICS this is optional and prevents compile testing in some cases.
Yeah, you're right; that clause should stay. I'll send a v2. Thanks.
select SERIAL_CORE help This driver is for the FPGA-based LiteUART serial controller from LiteX
Johan
linux-stable-mirror@lists.linaro.org
-
Andy Shevchenko -
Johan Hovold -
Stafford Horne