Fix RX_TERMINATION_FORCE_ENABLE define value from 0x0089 to 0x00A9 according to MIPI Alliance MPHY specification.
Fixes: e785060ea3a1 ("ufs: definitions for phy interface") Cc: stable@vger.kernel.org Signed-off-by: Pedro Sousa sousa@synopsys.com --- drivers/scsi/ufs/unipro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h index 23129d7..c77e365 100644 --- a/drivers/scsi/ufs/unipro.h +++ b/drivers/scsi/ufs/unipro.h @@ -52,7 +52,7 @@ #define RX_HS_UNTERMINATED_ENABLE 0x00A6 #define RX_ENTER_HIBERN8 0x00A7 #define RX_BYPASS_8B10B_ENABLE 0x00A8 -#define RX_TERMINATION_FORCE_ENABLE 0x0089 +#define RX_TERMINATION_FORCE_ENABLE 0x00A9 #define RX_MIN_ACTIVATETIME_CAPABILITY 0x008F #define RX_HIBERN8TIME_CAPABILITY 0x0092 #define RX_REFCLKFREQ 0x00EB
Hi, I tried to look it up in the unipro spec V1.6 (2013) - but it wasn't there. Is this attribute introduced on a later version? Thanks, Avri ________________________________________ From: Pedro Sousa PedroM.Sousa@synopsys.com Sent: Thursday, April 18, 2019 10:13 PM To: alim.akhtar@samsung.com; Avri Altman; martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org; stable@vger.kernel.org; Pedro Sousa Subject: [PATCH] scsi: ufs: Fix RX_TERMINATION_FORCE_ENABLE define value
Fix RX_TERMINATION_FORCE_ENABLE define value from 0x0089 to 0x00A9 according to MIPI Alliance MPHY specification.
Fixes: e785060ea3a1 ("ufs: definitions for phy interface") Cc: stable@vger.kernel.org Signed-off-by: Pedro Sousa sousa@synopsys.com --- drivers/scsi/ufs/unipro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h index 23129d7..c77e365 100644 --- a/drivers/scsi/ufs/unipro.h +++ b/drivers/scsi/ufs/unipro.h @@ -52,7 +52,7 @@ #define RX_HS_UNTERMINATED_ENABLE 0x00A6 #define RX_ENTER_HIBERN8 0x00A7 #define RX_BYPASS_8B10B_ENABLE 0x00A8 -#define RX_TERMINATION_FORCE_ENABLE 0x0089 +#define RX_TERMINATION_FORCE_ENABLE 0x00A9 #define RX_MIN_ACTIVATETIME_CAPABILITY 0x008F #define RX_HIBERN8TIME_CAPABILITY 0x0092 #define RX_REFCLKFREQ 0x00EB -- 2.7.4
Hi, Avri
Hi, I tried to look it up in the unipro spec V1.6 (2013) - but it wasn't there. Is this attribute introduced on a later version? Thanks, Avri
It is in M-phy spec, RX_Termination_Force_Enable should be 0xA9, I think, here is typo. But currently no driver uses it.
//Bean
From: Pedro Sousa PedroM.Sousa@synopsys.com Sent: Thursday, April 18, 2019 10:13 PM To: alim.akhtar@samsung.com; Avri Altman; martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org; stable@vger.kernel.org; Pedro Sousa Subject: [PATCH] scsi: ufs: Fix RX_TERMINATION_FORCE_ENABLE define value
Fix RX_TERMINATION_FORCE_ENABLE define value from 0x0089 to 0x00A9 according to MIPI Alliance MPHY specification.
Fixes: e785060ea3a1 ("ufs: definitions for phy interface") Cc: stable@vger.kernel.org Signed-off-by: Pedro Sousa sousa@synopsys.com
drivers/scsi/ufs/unipro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h index 23129d7..c77e365 100644 --- a/drivers/scsi/ufs/unipro.h +++ b/drivers/scsi/ufs/unipro.h @@ -52,7 +52,7 @@ #define RX_HS_UNTERMINATED_ENABLE 0x00A6 #define RX_ENTER_HIBERN8 0x00A7 #define RX_BYPASS_8B10B_ENABLE 0x00A8 -#define RX_TERMINATION_FORCE_ENABLE 0x0089 +#define RX_TERMINATION_FORCE_ENABLE 0x00A9 #define RX_MIN_ACTIVATETIME_CAPABILITY 0x008F #define RX_HIBERN8TIME_CAPABILITY 0x0092
#define RX_REFCLKFREQ 0x00EB
2.7.4
Hi Bean, Avri,
From: Bean Huo (beanhuo) beanhuo@micron.com Date: Thu, Apr 18, 2019 at 22:51:01
Hi, Avri
Hi, I tried to look it up in the unipro spec V1.6 (2013) - but it wasn't there. Is this attribute introduced on a later version? Thanks, Avri
It is in M-phy spec, RX_Termination_Force_Enable should be 0xA9, I think, here is typo. But currently no driver uses it.
//Bean
That's correct I've looked it up in M-phy spec. Thank you for checking.
Despite not being in use I am correcting it since I am planning to use it in a future submission.
Thank you, Pedro
linux-stable-mirror@lists.linaro.org
-
Avri Altman -
Bean Huo (beanhuo) -
Martin K. Petersen -
Pedro Sousa