On Thu, Mar 14, 2019 at 09:50:36AM -0600, Daniel Díaz wrote:

Hello!

While trying to add Perf tests to LKFT [1], we encountered some problems building it for two specific combinations:

• 4.4 and x86-64
• 4.14 and x86-32

On 4.4, this is what the build failure looks like: | bench/mem-memcpy-x86-64-asm.S:4:10: fatal error: ../../../arch/x86/lib/memcpy_64.S: No such file or directory | #include "../../../arch/x86/lib/memcpy_64.S" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This was fixed in mainline by commit 7d7d1bf1d1da ("perf bench: Copy kernel files needed to build mem{cpy,set} x86_64 benchmarks"). Instead of just cherry-picking, it requires a proper backport as it needs to copy the existing files in 4.4, not the ones contained in that commit (which are from v4.7-rc5+).

Ok, can you create a backported version of this? Or just a "sync the kernel headers with perf" patch is good, I think we need that for all of the LTS branches as I haven't been paying attention to that, sorry.

On 4.14, this is what the build failure looks like: | In file included from util/libunwind/x86_32.c:33:0: | util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id': | util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function); did you mean 'UNW_EINVAL'? | return -EINVAL; | ^~~~~~ | UNW_EINVAL

This was fixed by 44df1afdb174 ("perf tools: Fix compile error with libunwind x86"); it applies cleanly on top of v4.14.106.

Now queued up, thanks!

greg k-h