When I do LTP test, LTP test case ksm06 caused panic at break_ksm_pmd_entry -> pmd_leaf (Huge page table but False) -> pte_present (panic)
The reason is pmd_leaf is not defined, So like commit 501b81046701 ("mips: mm: add p?d_leaf() definitions") add p?d_leaf() definition for LoongArch.
v2: add Fixes: in commit message.
Fixes: 09cfefb7fa70 ("LoongArch: Add memory management") Signed-off-by: Hongchen Zhang zhanghongchen@loongson.cn --- arch/loongarch/include/asm/pgtable.h | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h index 370c6568ceb8..ea54653b7aab 100644 --- a/arch/loongarch/include/asm/pgtable.h +++ b/arch/loongarch/include/asm/pgtable.h @@ -243,6 +243,9 @@ static inline void pmd_clear(pmd_t *pmdp)
#define pmd_phys(pmd) PHYSADDR(pmd_val(pmd))
+#define pmd_leaf(pmd) ((pmd_val(pmd) & _PAGE_HUGE) != 0) +#define pud_leaf(pud) ((pud_val(pud) & _PAGE_HUGE) != 0) + #ifndef CONFIG_TRANSPARENT_HUGEPAGE #define pmd_page(pmd) (pfn_to_page(pmd_phys(pmd) >> PAGE_SHIFT)) #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
base-commit: a47fc304d2b678db1a5d760a7d644dac9b067752
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html/#opt...
Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree. Subject: [PATCH v2] LoongArch: add p?d_leaf() definitions Link: https://lore.kernel.org/stable/20230906084351.3533-1-zhanghongchen%40loongso...
On 06.09.23 10:43, Hongchen Zhang wrote:
When I do LTP test, LTP test case ksm06 caused panic at break_ksm_pmd_entry -> pmd_leaf (Huge page table but False) -> pte_present (panic)
The reason is pmd_leaf is not defined, So like commit 501b81046701 ("mips: mm: add p?d_leaf() definitions") add p?d_leaf() definition for LoongArch.
v2: add Fixes: in commit message.
This belongs under the "---". I assume whoever picks that up can fix it up.
Fixes: 09cfefb7fa70 ("LoongArch: Add memory management") Signed-off-by: Hongchen Zhang zhanghongchen@loongson.cn
Acked-by: David Hildenbrand david@redhat.com
We should CC stable. I assume whoever picks that up can fix it up.
On 2023/9/6 下午4:45, David Hildenbrand wrote:
On 06.09.23 10:43, Hongchen Zhang wrote:
When I do LTP test, LTP test case ksm06 caused panic at break_ksm_pmd_entry -> pmd_leaf (Huge page table but False) -> pte_present (panic)
The reason is pmd_leaf is not defined, So like commit 501b81046701 ("mips: mm: add p?d_leaf() definitions") add p?d_leaf() definition for LoongArch.
v2: add Fixes: in commit message.
This belongs under the "---". I assume whoever picks that up can fix it up.
OK, let me change it under the "---".
Fixes: 09cfefb7fa70 ("LoongArch: Add memory management") Signed-off-by: Hongchen Zhang zhanghongchen@loongson.cn
Acked-by: David Hildenbrand david@redhat.com
We should CC stable. I assume whoever picks that up can fix it up.
OK,let me add Cc: stable@ the commit message.
On 06.09.23 11:05, Hongchen Zhang wrote:
On 2023/9/6 下午4:45, David Hildenbrand wrote:
On 06.09.23 10:43, Hongchen Zhang wrote:
When I do LTP test, LTP test case ksm06 caused panic at break_ksm_pmd_entry -> pmd_leaf (Huge page table but False) -> pte_present (panic)
The reason is pmd_leaf is not defined, So like commit 501b81046701 ("mips: mm: add p?d_leaf() definitions") add p?d_leaf() definition for LoongArch.
v2: add Fixes: in commit message.
This belongs under the "---". I assume whoever picks that up can fix it up.
OK, let me change it under the "---".
Fixes: 09cfefb7fa70 ("LoongArch: Add memory management") Signed-off-by: Hongchen Zhang zhanghongchen@loongson.cn
Acked-by: David Hildenbrand david@redhat.com
We should CC stable. I assume whoever picks that up can fix it up.
OK,let me add Cc: stable@ the commit message.
Probably no need to resend.
linux-stable-mirror@lists.linaro.org
-
David Hildenbrand -
Hongchen Zhang -
kernel test robot