From: Vincent Mailhol mailhol.vincent@wanadoo.fr
After calling netif_receive_skb(skb), dereferencing skb is unsafe. Especially, the can_frame cf which aliases skb memory is dereferenced just after the call netif_receive_skb(skb).
Reordering the lines solves the issue.
Fixes: b21d18b51b31 ("can: Topcliff: Add PCH_CAN driver.") Link: https://lore.kernel.org/all/20211123111654.621610-1-mailhol.vincent@wanadoo.... Cc: stable@vger.kernel.org Signed-off-by: Vincent Mailhol mailhol.vincent@wanadoo.fr Signed-off-by: Marc Kleine-Budde mkl@pengutronix.de --- drivers/net/can/pch_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index 92a54a5fd4c5..964c8a09226a 100644 --- a/drivers/net/can/pch_can.c +++ b/drivers/net/can/pch_can.c @@ -692,11 +692,11 @@ static int pch_can_rx_normal(struct net_device *ndev, u32 obj_num, int quota) cf->data[i + 1] = data_reg >> 8; }
- netif_receive_skb(skb); rcv_pkts++; stats->rx_packets++; quota--; stats->rx_bytes += cf->len; + netif_receive_skb(skb);
pch_fifo_thresh(priv, obj_num); obj_num++;
base-commit: 4dbb0dad8e63fcd0b5a117c2861d2abe7ff5f186
Hello:
This series was applied to netdev/net.git (master) by Marc Kleine-Budde mkl@pengutronix.de:
On Tue, 7 Dec 2021 11:24:12 +0100 you wrote:
From: Vincent Mailhol mailhol.vincent@wanadoo.fr
After calling netif_receive_skb(skb), dereferencing skb is unsafe. Especially, the can_frame cf which aliases skb memory is dereferenced just after the call netif_receive_skb(skb).
Reordering the lines solves the issue.
[...]
Here is the summary with links: - [net,1/9] can: pch_can: pch_can_rx_normal: fix use after free https://git.kernel.org/netdev/net/c/94cddf1e9227 - [net,2/9] can: sja1000: fix use after free in ems_pcmcia_add_card() https://git.kernel.org/netdev/net/c/3ec6ca6b1a8e - [net,3/9] can: m_can: Disable and ignore ELO interrupt https://git.kernel.org/netdev/net/c/f58ac1adc76b - [net,4/9] can: m_can: m_can_read_fifo: fix memory leak in error branch https://git.kernel.org/netdev/net/c/31cb32a590d6 - [net,5/9] can: m_can: pci: fix iomap_read_fifo() and iomap_write_fifo() https://git.kernel.org/netdev/net/c/d737de2d7cc3 - [net,6/9] can: m_can: pci: fix incorrect reference clock rate https://git.kernel.org/netdev/net/c/8c03b8bff765 - [net,7/9] Revert "can: m_can: remove support for custom bit timing" https://git.kernel.org/netdev/net/c/ea768b2ffec6 - [net,8/9] can: m_can: make custom bittiming fields const https://git.kernel.org/netdev/net/c/ea22ba40debe - [net,9/9] can: m_can: pci: use custom bit timings for Elkhart Lake https://git.kernel.org/netdev/net/c/ea4c1787685d
You are awesome, thank you!
linux-stable-mirror@lists.linaro.org
-
Marc Kleine-Budde -
patchwork-bot+netdevbpf＠kernel.org