Hi folks,
I recently started seeing spurious test failures with rbtree tests, resulting in boot delays and random "hung task" warnings. The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters c46ecce431eb lib/interval_tree_test.c: allow full tree search 223f8911eace lib/rbtree_test.c: make input module parameters 0b548e33e6cb lib/rbtree-test: lower default params
The first three patches for v4.4.y and v4.9.y are the minimum set of context patches needed to avoid conflicts when applying commit 0b548e33e6cb.
I tested all kernel versions with the patches applied and rbtree testing enabled to ensure that no new problems are introduced.
Please consider applying those patches to the respective releases.
Thanks, Guenter
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
Hi folks,
I recently started seeing spurious test failures with rbtree tests, resulting in boot delays and random "hung task" warnings. The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters c46ecce431eb lib/interval_tree_test.c: allow full tree search 223f8911eace lib/rbtree_test.c: make input module parameters 0b548e33e6cb lib/rbtree-test: lower default params
The first three patches for v4.4.y and v4.9.y are the minimum set of context patches needed to avoid conflicts when applying commit 0b548e33e6cb.
I tested all kernel versions with the patches applied and rbtree testing enabled to ensure that no new problems are introduced.
Please consider applying those patches to the respective releases.
All now queued up, thanks!
greg k-h
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
Hi folks,
I recently started seeing spurious test failures with rbtree tests, resulting in boot delays and random "hung task" warnings. The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters c46ecce431eb lib/interval_tree_test.c: allow full tree search
Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't going to work well:
lib/interval_tree_test.c: In function ‘interval_tree_test_init’: lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’? unsigned long last = search_all ? max_endpoint : queries[j]; ^~~~~~~~~~~~ tracepoint
So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they build for you?
confused,
greg k-h
On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote:
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
Hi folks,
I recently started seeing spurious test failures with rbtree tests, resulting in boot delays and random "hung task" warnings. The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters c46ecce431eb lib/interval_tree_test.c: allow full tree search
Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't going to work well:
lib/interval_tree_test.c: In function ‘interval_tree_test_init’: lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’? unsigned long last = search_all ? max_endpoint : queries[j]; ^~~~~~~~~~~~ tracepoint
So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they build for you?
I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users to limit scope of endpoint") and for some reason dropped that from my e-mail.
Sorry :-(.
Guenter
On Fri, Dec 14, 2018 at 06:19:08AM -0800, Guenter Roeck wrote:
On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote:
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
Hi folks,
I recently started seeing spurious test failures with rbtree tests, resulting in boot delays and random "hung task" warnings. The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters c46ecce431eb lib/interval_tree_test.c: allow full tree search
Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't going to work well:
lib/interval_tree_test.c: In function ‘interval_tree_test_init’: lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’? unsigned long last = search_all ? max_endpoint : queries[j]; ^~~~~~~~~~~~ tracepoint
So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they build for you?
I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users to limit scope of endpoint") and for some reason dropped that from my e-mail.
I've grabbed a8ec14d4f6aa8e and all other patches for 4.9, 4.4 and 3.18 (and made sure they build fine). Thank you.
-- Thanks, Sasha
On 12/17/18 2:56 PM, Sasha Levin wrote:
On Fri, Dec 14, 2018 at 06:19:08AM -0800, Guenter Roeck wrote:
On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote:
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
Hi folks,
I recently started seeing spurious test failures with rbtree tests, resulting in boot delays and random "hung task" warnings. The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters c46ecce431eb lib/interval_tree_test.c: allow full tree search
Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't going to work well:
lib/interval_tree_test.c: In function ‘interval_tree_test_init’: lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’? unsigned long last = search_all ? max_endpoint : queries[j]; ^~~~~~~~~~~~ tracepoint
So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they build for you?
I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users to limit scope of endpoint") and for some reason dropped that from my e-mail.
I've grabbed a8ec14d4f6aa8e and all other patches for 4.9, 4.4 and 3.18 (and made sure they build fine). Thank you.
Thanks, appreciate it, and again sorry for the mess-up.
Guenter
linux-stable-mirror@lists.linaro.org
-
Greg Kroah-Hartman -
Guenter Roeck -
Sasha Levin