[Public]
Thank you, Jiri, for your feedback. I've dropped this patch from DC v.3.2.297. We will follow-up on this separately and merge it after you do confirm the issue you reported is fixed.
Thanks, Roman
-----Original Message----- From: Jiri Slaby jirislaby@kernel.org Sent: Monday, August 19, 2024 4:37 AM To: Li, Roman Roman.Li@amd.com; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Harry.Wentland@amd.com; Li, Sun peng (Leo) Sunpeng.Li@amd.com; Siqueira, Rodrigo Rodrigo.Siqueira@amd.com; Pillai, Aurabindo Aurabindo.Pillai@amd.com; Lin, Wayne Wayne.Lin@amd.com; Gutierrez, Agustin Agustin.Gutierrez@amd.com; Chung, ChiaHsuan (Tom) ChiaHsuan.Chung@amd.com; Zuo, Jerry Jerry.Zuo@amd.com; Mohamed, Zaeem Zaeem.Mohamed@amd.com Subject: Re: RE: [PATCH 12/13] drm/amd/display: Fix a typo in revert commit
On 16. 08. 24, 21:30, Li, Roman wrote:
[Public]
Wiil update commit message as:
drm/amd/display: Fix MST DSC lightup
[Why] Secondary monitor does not come up due to MST DSC bw calculation
regression.
This patch is only related to this. It does not fix that issue on its own at all.
[How] Fix bug in try_disable_dsc()
This update is worse than the original, IMO.
Could you write saner commit logs in the whole amdgpu overall?
If you insist on those [why] and [how] parts, something like: """ [Why] The linked commit below misreverted one hunk in try_disable_dsc().
[How] Fix that by using proper (original) 'max_kbps' instead of bogus 'stream_kbps'. ""
Fixes: 4b6564cb120c ("drm/amd/display: Fix MST BW calculation Regression")
Cc: mario.limonciello@amd.com Cc: alexander.deucher@amd.com Cc: stable@vger.kernel.org Reported-by: jirislaby@kernel.org
Care to fix up your machinery so that listed people are really CCed? I received a copy of neither the original (4b6564cb120c), nor this one.
Nor any mentions in the linked #3495 at all.
I would have told you that 4b6564cb120c is bogus. Immediately when it hit me as it differs from our (SUSE) in-tree revert in exactly this hunk. If I have known about this in the first place...
And you would have received a Tested-by if it had worked.
Given all the above, amdgpu workflow appears to be very ill. Please fix it.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3495 Closes: https://bugzilla.suse.com/show_bug.cgi?id=1228093 Reviewed-by: Roman Li roman.li@amd.com Signed-off-by: Fangzhi Zuo Jerry.Zuo@amd.com Signed-off-by: Roman Li roman.li@amd.com Tested-by: Daniel Wheeler daniel.wheeler@amd.com
-----Original Message----- From: Roman.Li@amd.com Roman.Li@amd.com Sent: Thursday, August 15, 2024 6:45 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Harry.Wentland@amd.com; Li, Sun peng (Leo) Sunpeng.Li@amd.com; Siqueira, Rodrigo Rodrigo.Siqueira@amd.com; Pillai, Aurabindo Aurabindo.Pillai@amd.com; Li, Roman Roman.Li@amd.com; Lin, Wayne Wayne.Lin@amd.com; Gutierrez, Agustin Agustin.Gutierrez@amd.com; Chung, ChiaHsuan (Tom) ChiaHsuan.Chung@amd.com; Zuo, Jerry Jerry.Zuo@amd.com;
Mohamed,
Zaeem Zaeem.Mohamed@amd.com; Zuo, Jerry Jerry.Zuo@amd.com Subject: [PATCH 12/13] drm/amd/display: Fix a typo in revert commit
From: Fangzhi Zuo Jerry.Zuo@amd.com
A typo is fixed for "drm/amd/display: Fix MST BW calculation Regression"
Fixes: 4b6564cb120c ("drm/amd/display: Fix MST BW calculation Regression")
Reviewed-by: Roman Li roman.li@amd.com Signed-off-by: Fangzhi Zuo Jerry.Zuo@amd.com Signed-off-by: Roman Li roman.li@amd.com
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c |
2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 958fad0d5307..5e08ca700c3f 100644
a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -1066,7 +1066,7 @@ static int try_disable_dsc(struct drm_atomic_state *state, vars[next_index].dsc_enabled = false; vars[next_index].bpp_x16 = 0; } else {
vars[next_index].pbn =kbps_to_peak_pbn(params[next_index].bw_range.stream_kbps, fec_overhead_multiplier_x1000);
vars[next_index].pbn =kbps_to_peak_pbn(params[next_index].bw_range.max_kbps, fec_overhead_multiplier_x1000); ret = drm_dp_atomic_find_time_slots(state,
params[next_index].port->mgr,
params[next_index].port,
thanks,
js suse labs
On 19. 08. 24, 16:29, Li, Roman wrote:
Thank you, Jiri, for your feedback. I've dropped this patch from DC v.3.2.297. We will follow-up on this separately and merge it after you do confirm the issue you reported is fixed.
The patch is all fine and very welcome to be upstream as soon as possible. With this patch, it works as expected.
But the process is broken. Your and Fangzhi Zuo's send-email setup to the least.
BTW you write in the commit log: Fixes: 4b6564cb120c ("drm/amd/display: Fix MST BW calculation Regression")
But: $ git show 4b6564cb120c fatal: ambiguous argument '4b6564cb120c': unknown revision or path not in the working tree.
Instead, it is: commit 338567d17627064dba63cf063459605e782f71d2 Author: Fangzhi Zuo Jerry.Zuo@amd.com Date: Mon Jul 29 10:23:03 2024 -0400
drm/amd/display: Fix MST BW calculation Regression
So apparently, someone in the process rebases the tree or something. Which is another breakage (non-reliable SHAs).
thanks,
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Jiri:
Please kindly let me know the kernel branch you are using to validate the fix. I'll provide with two additional patches on top of ("drm/amd/display: Fix MST BW calculation Regression")
Regards, Jerry
-----Original Message----- From: Jiri Slaby jirislaby@kernel.org Sent: Tuesday, August 20, 2024 12:49 AM To: Li, Roman Roman.Li@amd.com; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Harry.Wentland@amd.com; Li, Sun peng (Leo) Sunpeng.Li@amd.com; Siqueira, Rodrigo Rodrigo.Siqueira@amd.com; Pillai, Aurabindo Aurabindo.Pillai@amd.com; Lin, Wayne Wayne.Lin@amd.com; Gutierrez, Agustin Agustin.Gutierrez@amd.com; Chung, ChiaHsuan (Tom) ChiaHsuan.Chung@amd.com; Zuo, Jerry Jerry.Zuo@amd.com; Mohamed, Zaeem Zaeem.Mohamed@amd.com; Limonciello, Mario Mario.Limonciello@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; stable@vger.kernel.org Subject: Re: [PATCH 12/13] drm/amd/display: Fix a typo in revert commit
On 19. 08. 24, 16:29, Li, Roman wrote:
Thank you, Jiri, for your feedback. I've dropped this patch from DC v.3.2.297. We will follow-up on this separately and merge it after you do confirm the
issue you reported is fixed.
The patch is all fine and very welcome to be upstream as soon as possible. With this patch, it works as expected.
But the process is broken. Your and Fangzhi Zuo's send-email setup to the least.
BTW you write in the commit log: Fixes: 4b6564cb120c ("drm/amd/display: Fix MST BW calculation Regression")
But: $ git show 4b6564cb120c fatal: ambiguous argument '4b6564cb120c': unknown revision or path not in the working tree.
Instead, it is: commit 338567d17627064dba63cf063459605e782f71d2 Author: Fangzhi Zuo Jerry.Zuo@amd.com Date: Mon Jul 29 10:23:03 2024 -0400
drm/amd/display: Fix MST BW calculation RegressionSo apparently, someone in the process rebases the tree or something. Which is another breakage (non-reliable SHAs).
thanks,
js suse labs
On 20. 08. 24, 20:28, Zuo, Jerry wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Jiri:
Please kindly let me know the kernel branch you are using to validate the fix. I'll provide with two additional patches on top of ("drm/amd/display: Fix MST BW calculation Regression")
Hi,
whatever you prefer. E.g. even drm-next is fine here. Currently I run 6.10-stable plus the patch.
thanks,
[Public]
Hi Jiri:
Please apply above two patches on top of latest https://gitlab.freedesktop.org/agd5f/linux/-/commits/amd-staging-drm-next, and give a sanity test on 4k60 over Lenovo HDMI output.
The patch posted in the gitlab forum has been broken down to below three patches:
"0001-drm-amd-display-Fix-MST-BW-calculation-Regression.patch" already merged to amd-staging-drm-next. "0002-drm-amd-display-Fix-a-mistake-in-revert-commit.patch" will be merged to amd-staging-drm-next after your validation. "0003-drm-amd-display-Fix-Synaptics-Cascaded-DSC-Determina.patch" merged to amd-staging-drm-next this week.
Regards, Jerry
-----Original Message----- From: Jiri Slaby jirislaby@kernel.org Sent: Tuesday, August 20, 2024 12:49 AM To: Li, Roman Roman.Li@amd.com; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Harry.Wentland@amd.com; Li, Sun peng (Leo) Sunpeng.Li@amd.com; Siqueira, Rodrigo Rodrigo.Siqueira@amd.com; Pillai, Aurabindo Aurabindo.Pillai@amd.com; Lin, Wayne Wayne.Lin@amd.com; Gutierrez, Agustin Agustin.Gutierrez@amd.com; Chung, ChiaHsuan (Tom) ChiaHsuan.Chung@amd.com; Zuo, Jerry Jerry.Zuo@amd.com; Mohamed, Zaeem Zaeem.Mohamed@amd.com; Limonciello, Mario Mario.Limonciello@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; stable@vger.kernel.org Subject: Re: [PATCH 12/13] drm/amd/display: Fix a typo in revert commit
On 19. 08. 24, 16:29, Li, Roman wrote:
Thank you, Jiri, for your feedback. I've dropped this patch from DC v.3.2.297. We will follow-up on this separately and merge it after you do confirm the
issue you reported is fixed.
The patch is all fine and very welcome to be upstream as soon as possible. With this patch, it works as expected.
But the process is broken. Your and Fangzhi Zuo's send-email setup to the least.
BTW you write in the commit log: Fixes: 4b6564cb120c ("drm/amd/display: Fix MST BW calculation Regression")
But: $ git show 4b6564cb120c fatal: ambiguous argument '4b6564cb120c': unknown revision or path not in the working tree.
Instead, it is: commit 338567d17627064dba63cf063459605e782f71d2 Author: Fangzhi Zuo Jerry.Zuo@amd.com Date: Mon Jul 29 10:23:03 2024 -0400
drm/amd/display: Fix MST BW calculation RegressionSo apparently, someone in the process rebases the tree or something. Which is another breakage (non-reliable SHAs).
thanks,
js suse labs
linux-stable-mirror@lists.linaro.org
-
Jiri Slaby -
Li, Roman -
Zuo, Jerry