Hi,

Please do not add this patch to stable kernel, as there is another upstream commit which reverts this patch,

13b99d3 Revert "scsi: qedi: Allocate IRQs based on msix_cnt"

Thanks, Nilesh

-----Original Message----- From: Sasha Levin sashal@kernel.org Sent: Saturday, December 7, 2019 2:48 AM To: nilesh.javali@cavium.com Cc: stable-commits@vger.kernel.org Subject: [EXT] Patch "scsi: qedi: Allocate IRQs based on msix_cnt" has been added to the 4.19-stable tree

External Email

---------------------------------------------------------------------- This is a note to let you know that I've just added the patch titled

scsi: qedi: Allocate IRQs based on msix_cnt

to the 4.19-stable tree which can be found at:

https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-...

The filename of the patch is:

scsi-qedi-allocate-irqs-based-on-msix_cnt.patch

and it can be found in the queue-4.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,

please let stable@vger.kernel.org know about it.

commit 858d07cc26891658bb0c2c3aeee3ca4f84012655

Author: Nilesh Javali nilesh.javali@cavium.com

Date: Wed Nov 21 01:25:18 2018 -0800

scsi: qedi: Allocate IRQs based on msix_cnt

[ Upstream commit 1a291bce5eaf5374627d337157544aa6499ce34a ]

The driver load on some systems failed with error,

[0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed.

Allocate the IRQs based on MSIX count obtained from qed module instead of

number of queues.

Signed-off-by: Nilesh Javali nilesh.javali@cavium.com

Reviewed-by: Lee Duncan lduncan@suse.com

Signed-off-by: Martin K. Petersen martin.petersen@oracle.com

Signed-off-by: Sasha Levin sashal@kernel.org

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c

index 763c7628356b1..a81ea8f6c2087 100644

--- a/drivers/scsi/qedi/qedi_main.c

+++ b/drivers/scsi/qedi/qedi_main.c

@@ -1304,7 +1304,7 @@ static int qedi_request_msix_irq(struct qedi_ctx *qedi)

int i, rc, cpu;

cpu = cpumask_first(cpu_online_mask);

- for (i = 0; i < MIN_NUM_CPUS_MSIX(qedi); i++) {

+ for (i = 0; i < qedi->int_info.msix_cnt; i++) {

rc = request_irq(qedi->int_info.msix[i].vector,

qedi_msix_handler, 0, "qedi",

&qedi->fp_array[i]);