From: Shubhrajyoti Datta shubhrajyoti.datta@xilinx.com
Update the console index. Once the serial node is found update it to the console index.
Fixes: 18cc7ac8a28e ("Revert "serial: uartps: Register own uart console and driver structures"") Signed-off-by: Shubhrajyoti Datta shubhrajyoti.datta@xilinx.com Cc: stable stable@vger.kernel.org Signed-off-by: Michal Simek michal.simek@xilinx.com ---
Greg: Would be good if you can take this patch to 5.7 and also to stable trees. --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 672cfa075e28..b9d672af8b65 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1465,6 +1465,7 @@ static int cdns_uart_probe(struct platform_device *pdev) cdns_uart_uart_driver.nr = CDNS_UART_NR_PORTS; #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE cdns_uart_uart_driver.cons = &cdns_uart_console; + cdns_uart_console.index = id; #endif
rc = uart_register_driver(&cdns_uart_uart_driver);
On Thu, Apr 30, 2020 at 10:11:21AM +0200, Michal Simek wrote:
From: Shubhrajyoti Datta shubhrajyoti.datta@xilinx.com
Update the console index. Once the serial node is found update it to the console index.
Fixes: 18cc7ac8a28e ("Revert "serial: uartps: Register own uart console and driver structures"") Signed-off-by: Shubhrajyoti Datta shubhrajyoti.datta@xilinx.com Cc: stable stable@vger.kernel.org Signed-off-by: Michal Simek michal.simek@xilinx.com
Greg: Would be good if you can take this patch to 5.7 and also to stable trees.
WHy? I don't understand what bug this fixes/resolves, please be much more descriptive in your changelog text showing this if you wish for it to be backported to a stable tree. As it is, this just looks like you are adding a new feature.
thanks,
greg k-h
On 30. 04. 20 10:49, Greg Kroah-Hartman wrote:
On Thu, Apr 30, 2020 at 10:11:21AM +0200, Michal Simek wrote:
From: Shubhrajyoti Datta shubhrajyoti.datta@xilinx.com
Update the console index. Once the serial node is found update it to the console index.
Fixes: 18cc7ac8a28e ("Revert "serial: uartps: Register own uart console and driver structures"") Signed-off-by: Shubhrajyoti Datta shubhrajyoti.datta@xilinx.com Cc: stable stable@vger.kernel.org Signed-off-by: Michal Simek michal.simek@xilinx.com
Greg: Would be good if you can take this patch to 5.7 and also to stable trees.
WHy? I don't understand what bug this fixes/resolves, please be much more descriptive in your changelog text showing this if you wish for it to be backported to a stable tree. As it is, this just looks like you are adding a new feature.
ok. Will send v2 with better description.
Thanks, Michal
linux-stable-mirror@lists.linaro.org