On 10/17/2019 7:01 PM, Martin K. Petersen wrote:
Hannes,
The BUILD_NVME define never got defined anywhere, causing NVMe commands to be treated as SCSI commands when freeing the buffers. This was causing a stuck discovery and a horrible crash in lpfc_set_rrq_active() later on.
Applied to 5.4/scsi-fixes, thanks!
The offending patches that introduced the define are:
From 12.2.0.0: scsi: lpfc: Move SCSI and NVME Stats to hardware queue structures commit 4c47efc140fa926f00aa59c248458d95bd7b5eab From 12.4.0.0: scsi: lpfc: Merge per-protocol WQ/CQ pairs into single per-cpu pair commit c00f62e6c5468ed0673c583f1ff284274e817410
The 12.2 patch just misses some stats - no big deal. But the 12.4 patch introduces a logic error, and is in the head of the stable tree.
I assume that 5.4/scsi-fixes will get merged into 5.4 pre-release, and that the stable tree will rebase to pick it up ?
-- james
James,
I assume that 5.4/scsi-fixes will get merged into 5.4 pre-release,
Yes.
and that the stable tree will rebase to pick it up ?
stable/master is tracking Linus until final release.
If you want the stats issue fixed in 5.3, it's best to wait for Hannes' commit to be merged by Linus. You can then request a stable backport.
linux-stable-mirror@lists.linaro.org
-
James Smart -
Martin K. Petersen