On Wed, Nov 29, 2017 at 01:00:25PM +1100, NeilBrown wrote:

Subject: [PATCH] md: forbid a RAID5 from having both a bitmap and a journal.

commit 230b55fa8d64007339319539f8f8e68114d08529 upstream.

Having both a bitmap and a journal is pointless. Attempting to do so can corrupt the bitmap if the journal replay happens before the bitmap is initialized. Rather than try to avoid this corruption, simply refuse to allow arrays with both a bitmap and a journal. So:

• if raid5_run sees both are present, fail.
• if adding a bitmap finds a journal is present, fail
• if adding a journal finds a bitmap is present, fail.

Cc: stable@vger.kernel.org (4.10+) Signed-off-by: NeilBrown neilb@suse.com Tested-by: Joshua Kinard kumba@gentoo.org Acked-by: Joshua Kinard kumba@gentoo.org Signed-off-by: Shaohua Li shli@fb.com

---

drivers/md/bitmap.c | 6 ++++++ drivers/md/md.c | 2 +- drivers/md/raid5.c | 7 +++++++ 3 files changed, 14 insertions(+), 1 deletion(-)

This commit only had problems due to a filename change.

Oops, I should have caught that one, sorry about that. Thanks for the patch.

greg k-h