If mmc_get_ext_csd success, the ext_csd are not freed. Add the missing kfree() calls.
Signed-off-by: Wenbin Mei wenbin.mei@mediatek.com Fixes: c4ac38c6539b ("mmc: mtk-sd: Add HS400 online tuning support") Cc: stable@vger.kernel.org --- drivers/mmc/host/mtk-sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 943940b44e83..632775217d35 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -2291,8 +2291,10 @@ static int msdc_execute_hs400_tuning(struct mmc_host *mmc, struct mmc_card *card sdr_set_field(host->base + PAD_DS_TUNE, PAD_DS_TUNE_DLY1, i); ret = mmc_get_ext_csd(card, &ext_csd); - if (!ret) + if (!ret) { result_dly1 |= (1 << i); + kfree(ext_csd); + } } host->hs400_tuning = false;
On Tue, 7 Dec 2021 at 08:50, Wenbin Mei wenbin.mei@mediatek.com wrote:
If mmc_get_ext_csd success, the ext_csd are not freed. Add the missing kfree() calls.
Signed-off-by: Wenbin Mei wenbin.mei@mediatek.com Fixes: c4ac38c6539b ("mmc: mtk-sd: Add HS400 online tuning support") Cc: stable@vger.kernel.org
We don't need the stable tag in this case, as commit c4ac38c6539b was introduced in v5.16-rc1. In any case, thanks for adding the fixes tag, it certainly helps!
Applied for fixes, thanks!
Kind regards Uffe
drivers/mmc/host/mtk-sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 943940b44e83..632775217d35 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -2291,8 +2291,10 @@ static int msdc_execute_hs400_tuning(struct mmc_host *mmc, struct mmc_card *card sdr_set_field(host->base + PAD_DS_TUNE, PAD_DS_TUNE_DLY1, i); ret = mmc_get_ext_csd(card, &ext_csd);
if (!ret)
if (!ret) { result_dly1 |= (1 << i);kfree(ext_csd);} } host->hs400_tuning = false;-- 2.25.1
linux-stable-mirror@lists.linaro.org
-
Ulf Hansson -
Wenbin Mei