From: Bhaumik Bhatt bbhatt@codeaurora.org
Set the BHI and BHIe pointers to NULL as part of clean-up. This makes sure that stale pointers are not accessed after powering MHI down.
Cc: stable@vger.kernel.org Suggested-by: Hemant Kumar hemantk@codeaurora.org Signed-off-by: Bhaumik Bhatt bbhatt@codeaurora.org Reviewed-by: Jeffrey Hugo quic_jhugo@quicinc.com Reviewed-by: Hemant Kumar hemantk@codeaurora.org Reviewed-by: Manivannan Sadhasivam manivannan.sadhasivam@linaro.org Link: https://lore.kernel.org/r/1620330705-40192-3-git-send-email-bbhatt@codeauror... Signed-off-by: Manivannan Sadhasivam manivannan.sadhasivam@linaro.org --- drivers/bus/mhi/core/init.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index 11c7a3d3c9bf..1cc2f225d3d1 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -1132,6 +1132,9 @@ void mhi_unprepare_after_power_down(struct mhi_controller *mhi_cntrl) mhi_cntrl->rddm_image = NULL; }
+ mhi_cntrl->bhi = NULL; + mhi_cntrl->bhie = NULL; + mhi_deinit_dev_ctxt(mhi_cntrl); } EXPORT_SYMBOL_GPL(mhi_unprepare_after_power_down);
On Fri, Jun 25, 2021 at 06:03:51PM +0530, Manivannan Sadhasivam wrote:
From: Bhaumik Bhatt bbhatt@codeaurora.org
Set the BHI and BHIe pointers to NULL as part of clean-up. This makes sure that stale pointers are not accessed after powering MHI down.
Cc: stable@vger.kernel.org
Why is this needed for stable, but patch 5/10 is not?
And what commit does this fix? How far back should it go?
And is this really fixing anything?
thanks,
greg k-h
On Fri, Jun 25, 2021 at 02:38:58PM +0200, Greg KH wrote:
On Fri, Jun 25, 2021 at 06:03:51PM +0530, Manivannan Sadhasivam wrote:
From: Bhaumik Bhatt bbhatt@codeaurora.org
Set the BHI and BHIe pointers to NULL as part of clean-up. This makes sure that stale pointers are not accessed after powering MHI down.
Cc: stable@vger.kernel.org
Why is this needed for stable, but patch 5/10 is not?
Shoot! This one relies on 5/10 and fixes a corner case where the BHI/BHIe pointers might be used after MHI powerdown. But this requires backporting the patches 5-10 cleanly (a series).
So I guess the stable tag should be removed for this patch. We will test this series on stable kernels (on how far) and make sure this doesn't break anything. Then we can share the commit IDs to be backported with details?
Thanks, Mani
And what commit does this fix? How far back should it go?
And is this really fixing anything?
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org