[PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP - Linux-stable-mirror

5 Aug 2022

The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware versions
that have no issues.
This patch is reverting 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
because using FLAG_SEND_ZLP in this context is not safe.
See:
https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Li...
reported by:
Ronald Wahl ronald.wahl@raritan.com
https://bugzilla.kernel.org/show_bug.cgi?id=216327
https://bugs.archlinux.org/task/75491
--
drivers/net/usb/ax88179_178a.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 0ad468a00064..aff39bf3161d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1680,7 +1680,7 @@ static const struct driver_info ax88179_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1693,7 +1693,7 @@ static const struct driver_info ax88178a_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1706,7 +1706,7 @@ static const struct driver_info cypress_GX3_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1719,7 +1719,7 @@ static const struct driver_info dlink_dub1312_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1732,7 +1732,7 @@ static const struct driver_info sitecom_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1745,7 +1745,7 @@ static const struct driver_info samsung_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1758,7 +1758,7 @@ static const struct driver_info lenovo_info = {
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
-	.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1771,7 +1771,7 @@ static const struct driver_info belkin_info = {
    .link_reset = ax88179_link_reset,
    .reset	= ax88179_reset,
    .stop	= ax88179_stop,
-	.flags	= FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags	= FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1784,7 +1784,7 @@ static const struct driver_info toshiba_info = {
    .link_reset = ax88179_link_reset,
    .reset	= ax88179_reset,
    .stop = ax88179_stop,
-	.flags	= FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags	= FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1797,7 +1797,7 @@ static const struct driver_info mct_info = {
    .link_reset = ax88179_link_reset,
    .reset	= ax88179_reset,
    .stop	= ax88179_stop,
-	.flags	= FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags	= FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1810,7 +1810,7 @@ static const struct driver_info at_umc2000_info = {
    .link_reset = ax88179_link_reset,
    .reset  = ax88179_reset,
    .stop   = ax88179_stop,
-	.flags  = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags  = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1823,7 +1823,7 @@ static const struct driver_info at_umc200_info = {
    .link_reset = ax88179_link_reset,
    .reset  = ax88179_reset,
    .stop   = ax88179_stop,
-	.flags  = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags  = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };
@@ -1836,7 +1836,7 @@ static const struct driver_info at_umc2000sp_info = {
    .link_reset = ax88179_link_reset,
    .reset  = ax88179_reset,
    .stop   = ax88179_stop,
-	.flags  = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+	.flags  = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
 };

    