Hi Greg and Sasha,
On Tue, 10 Aug 2021 16:45:34 +0000 SeongJae Park sj38.park@gmail.com wrote:
From: SeongJae Park sjpark@amazon.de
When running a test program, 'run_one()' checks if the program has the execution permission and fails if it doesn't. However, it's easy to mistakenly missing the permission, as some common tools like 'diff' don't support the permission change well[1]. Compared to that, making mistakes in the test program's path would only rare, as those are explicitly listed in 'TEST_PROGS'. Therefore, it might make more sense to resolve the situation on our own and run the program.
For the reason, this commit makes the test program runner function to still print the warning message but try parsing the interpreter of the program and explicitly run it with the interpreter, in the case.
[1] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/
Suggested-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Signed-off-by: SeongJae Park sjpark@amazon.de
This patch has merged into the mainline by the commit 303f8e2d0200 ("selftests/kselftest/runner/run_one(): allow running non-executable files"). However, this patch has not added to v5.15.y, while there are some selftests having no execution permission, including that for DAMON. As a result, the selftests always fail unless this patch is manually applied. Could you please add this patch to v5.15.y? I confirmed this patch can cleanly cherry-picked on the latest v5.15.y.
Thanks, SJ
On Tue, Apr 25, 2023 at 12:46:37AM +0000, SeongJae Park wrote:
Hi Greg and Sasha,
On Tue, 10 Aug 2021 16:45:34 +0000 SeongJae Park sj38.park@gmail.com wrote:
From: SeongJae Park sjpark@amazon.de
When running a test program, 'run_one()' checks if the program has the execution permission and fails if it doesn't. However, it's easy to mistakenly missing the permission, as some common tools like 'diff' don't support the permission change well[1]. Compared to that, making mistakes in the test program's path would only rare, as those are explicitly listed in 'TEST_PROGS'. Therefore, it might make more sense to resolve the situation on our own and run the program.
For the reason, this commit makes the test program runner function to still print the warning message but try parsing the interpreter of the program and explicitly run it with the interpreter, in the case.
[1] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/
Suggested-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Signed-off-by: SeongJae Park sjpark@amazon.de
This patch has merged into the mainline by the commit 303f8e2d0200 ("selftests/kselftest/runner/run_one(): allow running non-executable files"). However, this patch has not added to v5.15.y, while there are some selftests having no execution permission, including that for DAMON. As a result, the selftests always fail unless this patch is manually applied. Could you please add this patch to v5.15.y? I confirmed this patch can cleanly cherry-picked on the latest v5.15.y.
Now queued up, thanks.
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
SeongJae Park