From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out the userland hv_kvp_daemon needs the info of operation, adapter_id and addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall through" warnings") Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com --- drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c index a7513a8a8e37..d6106e1a0d4a 100644 --- a/drivers/hv/hv_kvp.c +++ b/drivers/hv/hv_kvp.c @@ -353,6 +353,9 @@ static void process_ib_ipinfo(void *in_msg, void *out_msg, int op)
out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
+ /* fallthrough */ + + case KVP_OP_GET_IP_INFO: utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id, MAX_ADAPTER_ID_SIZE, UTF16_LITTLE_ENDIAN, @@ -405,7 +408,11 @@ kvp_send_key(struct work_struct *dummy) process_ib_ipinfo(in_msg, message, KVP_OP_SET_IP_INFO); break; case KVP_OP_GET_IP_INFO: - /* We only need to pass on message->kvp_hdr.operation. */ + /* + * We only need to pass on the info of operation, adapter_id + * and addr_family to the userland kvp daemon. + */ + process_ib_ipinfo(in_msg, message, KVP_OP_GET_IP_INFO); break; case KVP_OP_SET: switch (in_msg->body.kvp_set.data.value_type) { @@ -446,9 +453,9 @@ kvp_send_key(struct work_struct *dummy)
}
- break; - - case KVP_OP_GET: + /* + * The key is always a string - utf16 encoding. + */ message->body.kvp_set.data.key_size = utf16s_to_utf8s( (wchar_t *)in_msg->body.kvp_set.data.key, @@ -456,6 +463,17 @@ kvp_send_key(struct work_struct *dummy) UTF16_LITTLE_ENDIAN, message->body.kvp_set.data.key, HV_KVP_EXCHANGE_MAX_KEY_SIZE - 1) + 1; + + break; + + case KVP_OP_GET: + message->body.kvp_get.data.key_size = + utf16s_to_utf8s( + (wchar_t *)in_msg->body.kvp_get.data.key, + in_msg->body.kvp_get.data.key_size, + UTF16_LITTLE_ENDIAN, + message->body.kvp_get.data.key, + HV_KVP_EXCHANGE_MAX_KEY_SIZE - 1) + 1; break;
case KVP_OP_DELETE:
From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent: Wednesday, October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out the userland hv_kvp_daemon needs the info of operation, adapter_id and addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall through" warnings") Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent: Wednesday, October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out the userland hv_kvp_daemon needs the info of operation, adapter_id and addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall
through" warnings")
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
We need it to fix a regression introduced by me in: Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall through" warnings")
The faulty patch is being meged into the old stable kernels... So we need to take this patch ASAP. Thanks!
-- Dexuan
On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent: Wednesday, October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out the userland hv_kvp_daemon needs the info of operation, adapter_id and addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall
through" warnings")
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :)
greg k-h
From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 11:57 To: Dexuan Cui decui@microsoft.com
On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent:
Wednesday,
October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns
out
the userland hv_kvp_daemon needs the info of operation, adapter_id
and
addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall
through" warnings")
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :)
greg k-h
Hi Greg, KY has added his Signed-off-by in the mail.
I'll ask the other HV maintainers to take a look as well.
Thanks, -- Dexuan
On Thu, Nov 01, 2018 at 07:22:28PM +0000, Dexuan Cui wrote:
From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 11:57 To: Dexuan Cui decui@microsoft.com
On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent:
Wednesday,
October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns
out
the userland hv_kvp_daemon needs the info of operation, adapter_id
and
addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall
through" warnings")
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :)
greg k-h
Hi Greg, KY has added his Signed-off-by in the mail.
I'll ask the other HV maintainers to take a look as well.
Ok, then I'll look at it after 4.20-rc1 is out, nothing I can do until then anyway...
thanks,
greg k-h
From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 21:54 To: Dexuan Cui decui@microsoft.com Cc: Michael Kelley mikelley@microsoft.com; KY Srinivasan kys@microsoft.com; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen Hemminger sthemmin@microsoft.com; vkuznets vkuznets@redhat.com; Sasha Levin Alexander.Levin@microsoft.com; Haiyang Zhang haiyangz@microsoft.com; Stable@vger.kernel.org Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up
On Thu, Nov 01, 2018 at 07:22:28PM +0000, Dexuan Cui wrote:
From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 11:57 To: Dexuan Cui decui@microsoft.com
On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent:
Wednesday,
October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it
turns
out
the userland hv_kvp_daemon needs the info of operation, adapter_id
and
addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size
of
0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may
fall
through" warnings")
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :)
greg k-h
Hi Greg, KY has added his Signed-off-by in the mail.
I'll ask the other HV maintainers to take a look as well.
Ok, then I'll look at it after 4.20-rc1 is out, nothing I can do until then anyway...
thanks,
greg k-h
Hi Greg, Can you please take a look at the patch now?
The patch has received
Reviewed-by: Michael Kelley mikelley@microsoft.com Signed-off-by: Haiyang Zhang haiyangz@microsoft.com Signed-off-by: K. Y. Srinivasan kys@microsoft.com
Thanks, -- Dexuan
On Sun, Nov 11, 2018 at 04:18:03AM +0000, Dexuan Cui wrote:
From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 21:54 To: Dexuan Cui decui@microsoft.com Cc: Michael Kelley mikelley@microsoft.com; KY Srinivasan kys@microsoft.com; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen Hemminger sthemmin@microsoft.com; vkuznets vkuznets@redhat.com; Sasha Levin Alexander.Levin@microsoft.com; Haiyang Zhang haiyangz@microsoft.com; Stable@vger.kernel.org Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up
On Thu, Nov 01, 2018 at 07:22:28PM +0000, Dexuan Cui wrote:
From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 11:57 To: Dexuan Cui decui@microsoft.com
On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent:
Wednesday,
October 17, 2018 10:10 PM > From: Dexuan Cui decui@microsoft.com > > In kvp_send_key(), we do need call process_ib_ipinfo() if > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it
turns
out
> the userland hv_kvp_daemon needs the info of operation, adapter_id
and
> addr_family. With the incorrect fc62c3b1977d, the host can't get the > VM's IP via KVP. > > And, fc62c3b1977d added a "break;", but actually forgot to initialize > the key_size/value in the case of KVP_OP_SET, so the default key_size
of
> 0 is passed to the kvp daemon, and the pool files > /var/lib/hyperv/.kvp_pool_* can't be updated. > > This patch effectively rolls back the previous fc62c3b1977d, and > correctly fixes the "this statement may fall through" warnings. > > This patch is tested on WS 2012 R2 and 2016. > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may
fall
through" warnings") > Signed-off-by: Dexuan Cui decui@microsoft.com > Cc: K. Y. Srinivasan kys@microsoft.com > Cc: Haiyang Zhang haiyangz@microsoft.com > Cc: Stephen Hemminger sthemmin@microsoft.com > Cc: Stable@vger.kernel.org > Signed-off-by: K. Y. Srinivasan kys@microsoft.com > --- > drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :)
greg k-h
Hi Greg, KY has added his Signed-off-by in the mail.
I'll ask the other HV maintainers to take a look as well.
Ok, then I'll look at it after 4.20-rc1 is out, nothing I can do until then anyway...
thanks,
greg k-h
Hi Greg, Can you please take a look at the patch now?
It's in my queue, sorry, it's big right now due to travel...
-----Original Message----- From: gregkh@linuxfoundation.org gregkh@linuxfoundation.org Sent: Thursday, November 1, 2018 11:57 AM To: Dexuan Cui decui@microsoft.com Cc: Michael Kelley mikelley@microsoft.com; KY Srinivasan kys@microsoft.com; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen Hemminger sthemmin@microsoft.com; vkuznets vkuznets@redhat.com; Sasha Levin Alexander.Levin@microsoft.com; Haiyang Zhang haiyangz@microsoft.com; Stable@vger.kernel.org Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up
On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote:
From: Michael Kelley mikelley@microsoft.com Sent: Wednesday, October 24, 2018 08:38 From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent:
Wednesday,
October 17, 2018 10:10 PM
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it
turns out
the userland hv_kvp_daemon needs the info of operation, adapter_id
and
addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size
of
0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall
through" warnings")
Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
Reviewed-by: Michael Kelley mikelley@microsoft.com
Hi Greg, Can you please take a look at this patch?
Greg,
I have already signed-off on this patch.
K. Y
Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :)
greg k-h
-----Original Message----- From: kys@linuxonhyperv.com kys@linuxonhyperv.com Sent: Thursday, October 18, 2018 1:10 AM To: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen Hemminger sthemmin@microsoft.com; Michael Kelley mikelley@microsoft.com; vkuznets vkuznets@redhat.com Cc: Dexuan Cui decui@microsoft.com; KY Srinivasan kys@microsoft.com; Haiyang Zhang haiyangz@microsoft.com; Stable@vger.kernel.org Subject: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up
From: Dexuan Cui decui@microsoft.com
In kvp_send_key(), we do need call process_ib_ipinfo() if message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out the userland hv_kvp_daemon needs the info of operation, adapter_id and addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP via KVP.
And, fc62c3b1977d added a "break;", but actually forgot to initialize the key_size/value in the case of KVP_OP_SET, so the default key_size of 0 is passed to the kvp daemon, and the pool files /var/lib/hyperv/.kvp_pool_* can't be updated.
This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes the "this statement may fall through" warnings.
This patch is tested on WS 2012 R2 and 2016.
Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall through" warnings") Signed-off-by: Dexuan Cui decui@microsoft.com Cc: K. Y. Srinivasan kys@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com Cc: Stephen Hemminger sthemmin@microsoft.com Cc: Stable@vger.kernel.org Signed-off-by: K. Y. Srinivasan kys@microsoft.com
Signed-off-by: Haiyang Zhang haiyangz@microsoft.com
Thanks!
linux-stable-mirror@lists.linaro.org